mirror/zx2c4.cgit
1
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2025-08-02 09:05:01 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't truncate valid cachefiles

Browse source 
An embarrassing thinko in cgit_check_cache() would truncate valid cachefiles
in the following situation:
  1) process A notices a missing/expired cachefile
  2) process B gets scheduled, locks, fills and unlocks the cachefile
  3) process A gets scheduled, locks the cachefile, notices that the cachefile
     now exist/is not expired anymore, and continues to overwrite it with an
     empty lockfile.

Thanks to Linus for noticing (again).

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
This commit is contained in:
Lars Hjemli 2006-12-11 22:53:50 +01:00
parent 44923f8953
commit fbaf1171b4
3 changed files with 16 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
cache.c
View file

@ -99,6 +99,11 @@ int cache_unlock(struct cacheitem *item)
return (rename(fmt("%s.lock", item->name), item->name) == 0);
}
int cache_cancel_lock(struct cacheitem *item)
{
return (unlink(fmt("%s.lock", item->name)) == 0);
}
int cache_expired(struct cacheitem *item)
{
if (item->ttl < 0)