mirror/zx2c4.cgit
1
0
Fork 0
mirror of https://git.zx2c4.com/cgit synced 2025-06-24 02:38:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Convert cgit_print_error to a variadic function

Browse source 
This removes many uses of "fmt" which uses a fixed size static pool of
fixed size buffers.  Instead of relying on these, we now pass around
argument lists for as long as possible before using a strbuf to render
content of an arbitrary size.

Signed-off-by: John Keeping <john@keeping.me.uk>
This commit is contained in:
John Keeping 2013-04-06 11:23:52 +01:00 • committed by Jason A. Donenfeld
parent d2e20e3814
commit ed5bd30ebe
11 changed files with 57 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ui-diff.c
View file

@ -369,12 +369,12 @@ void cgit_print_diff(const char *new_rev, const char *old_rev,
get_sha1(new_rev, new_rev_sha1);
type = sha1_object_info(new_rev_sha1, &size);
if (type == OBJ_BAD) {
cgit_print_error(fmt("Bad object name: %s", new_rev));
cgit_print_error("Bad object name: %s", new_rev);
return;
}
commit = lookup_commit_reference(new_rev_sha1);
if (!commit || parse_commit(commit)) {
cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1)));
cgit_print_error("Bad commit: %s", sha1_to_hex(new_rev_sha1));
return;
}
@ -388,12 +388,12 @@ void cgit_print_diff(const char *new_rev, const char *old_rev,
if (!is_null_sha1(old_rev_sha1)) {
type = sha1_object_info(old_rev_sha1, &size);
if (type == OBJ_BAD) {
cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1)));
cgit_print_error("Bad object name: %s", sha1_to_hex(old_rev_sha1));
return;
}
commit2 = lookup_commit_reference(old_rev_sha1);
if (!commit2 || parse_commit(commit2)) {
cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1)));
cgit_print_error("Bad commit: %s", sha1_to_hex(old_rev_sha1));
return;
}
}