mirror/pcottle.learnGitBranching
1
0
Fork 0
mirror of https://github.com/pcottle/learnGitBranching.git synced 2025-07-04 11:44:27 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Scroll bar FF fixes Issue #51

Browse source
This commit is contained in:
Peter Cottle 2013-02-21 09:12:32 -08:00
parent d1962d2a2e
commit f8a92580bd
7 changed files with 27 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

1
README.md
View file

@ -90,4 +90,5 @@ Or reported an issue that was successfully closed!
* Mael P ("maelp") * Mael P ("maelp")
* "flying-sheep" * "flying-sheep"
* "arianvp" * "arianvp"
* "MaPePeR"

16
build/bundle.js
View file

@ -18388,7 +18388,13 @@ var CommandLineHistoryView = Backbone.View.extend({
var cD = $('#commandDisplay')[0]; var cD = $('#commandDisplay')[0];
var t = $('#terminal')[0]; var t = $('#terminal')[0];
var shouldScroll = (cD.clientHeight > t.clientHeight); console.log('I AM CHECKING scroll ehight');
console.log(cD, t);
console.log(cD.clientHeight, t.clientHeight);
// firefox hack
var shouldScroll = (cD.clientHeight > t.clientHeight) ||
($(window).height() < cD.clientHeight);
$(t).toggleClass('scrolling', shouldScroll); $(t).toggleClass('scrolling', shouldScroll);
if (shouldScroll) { if (shouldScroll) {
t.scrollTop = t.scrollHeight; t.scrollTop = t.scrollHeight;
@ -24461,7 +24467,13 @@ var CommandLineHistoryView = Backbone.View.extend({
var cD = $('#commandDisplay')[0]; var cD = $('#commandDisplay')[0];
var t = $('#terminal')[0]; var t = $('#terminal')[0];
var shouldScroll = (cD.clientHeight > t.clientHeight); console.log('I AM CHECKING scroll ehight');
console.log(cD, t);
console.log(cD.clientHeight, t.clientHeight);
// firefox hack
var shouldScroll = (cD.clientHeight > t.clientHeight) ||
($(window).height() < cD.clientHeight);
$(t).toggleClass('scrolling', shouldScroll); $(t).toggleClass('scrolling', shouldScroll);
if (shouldScroll) { if (shouldScroll) {
t.scrollTop = t.scrollHeight; t.scrollTop = t.scrollHeight;

2
build/bundle.min.d4974b81.js → build/bundle.min.3421e8e8.js
View file

File diff suppressed because one or more lines are too long

2
build/bundle.min.js vendored
View file

File diff suppressed because one or more lines are too long

2
build/main.657245d8.css → build/main.61a783f2.css
View file

@ -589,7 +589,7 @@ li.rebaseEntry a#toggleButton {
position: relative; position: relative;
font-size: 14px; font-size: 14px;
top: -5px; top: -5px;
right; -5px; right: -5px;
} }
li.rebaseEntry.notPicked { li.rebaseEntry.notPicked {

4
index.html
View file

@ -13,7 +13,7 @@
<meta property="og:image" content="http://pcottle.github.com/learnGitBranching/assets/learnGitBranching.png"/> <meta property="og:image" content="http://pcottle.github.com/learnGitBranching/assets/learnGitBranching.png"/>
<meta property="og:description" content="A interactive Git visualization tool to educate and challenge!"/> <meta property="og:description" content="A interactive Git visualization tool to educate and challenge!"/>
<link rel="stylesheet" href="build/main.657245d8.css" type="text/css" charset="utf-8"> <link rel="stylesheet" href="build/main.61a783f2.css" type="text/css" charset="utf-8">
<link rel="stylesheet" href="src/style/font-awesome.css" type="text/css" charset="utf-8"> <link rel="stylesheet" href="src/style/font-awesome.css" type="text/css" charset="utf-8">
</head> </head>
<body> <body>
@ -409,7 +409,7 @@
For a much easier time perusing the source, see the individual files at: For a much easier time perusing the source, see the individual files at:
https://github.com/pcottle/learnGitBranching https://github.com/pcottle/learnGitBranching
--> -->
<script src="build/bundle.min.d4974b81.js"></script> <script src="build/bundle.min.3421e8e8.js"></script>
<!-- The advantage of github pages: super-easy, simple, slick static hostic. <!-- The advantage of github pages: super-easy, simple, slick static hostic.
The downside? No raw logs to parse for analytics, so I have to include The downside? No raw logs to parse for analytics, so I have to include

8
src/js/views/commandViews.js
View file

@ -357,7 +357,13 @@ var CommandLineHistoryView = Backbone.View.extend({
var cD = $('#commandDisplay')[0]; var cD = $('#commandDisplay')[0];
var t = $('#terminal')[0]; var t = $('#terminal')[0];
var shouldScroll = (cD.clientHeight > t.clientHeight); console.log('I AM CHECKING scroll ehight');
console.log(cD, t);
console.log(cD.clientHeight, t.clientHeight);
// firefox hack
var shouldScroll = (cD.clientHeight > t.clientHeight) ||
($(window).height() < cD.clientHeight);
$(t).toggleClass('scrolling', shouldScroll); $(t).toggleClass('scrolling', shouldScroll);
if (shouldScroll) { if (shouldScroll) {
t.scrollTop = t.scrollHeight; t.scrollTop = t.scrollHeight;