mirror/pcottle.learnGitBranching
1
0
Fork 0
mirror of https://github.com/pcottle/learnGitBranching.git synced 2025-06-29 17:27:22 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

now to move to everything being able to async process comamdns event-based distribution

Browse source
This commit is contained in:
Peter Cottle 2012-12-27 14:58:25 -08:00
parent eb0458c299
commit d46728d973
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
build/bundle.js
View file

@ -4578,7 +4578,7 @@ var CommandBuffer = Backbone.Model.extend({
this.setTimeout(); this.setTimeout();
}, this); }, this);
// find a command with no error // find a command with no error (aka unprocessed)
while (popped.get('error') && this.buffer.length) { while (popped.get('error') && this.buffer.length) {
popped = this.buffer.pop(); popped = this.buffer.pop();
} }
@ -16595,7 +16595,7 @@ var CommandBuffer = Backbone.Model.extend({
this.setTimeout(); this.setTimeout();
}, this); }, this);
// find a command with no error // find a command with no error (aka unprocessed)
while (popped.get('error') && this.buffer.length) { while (popped.get('error') && this.buffer.length) {
popped = this.buffer.pop(); popped = this.buffer.pop();
} }

2
src/js/models/collections.js
View file

@ -68,7 +68,7 @@ var CommandBuffer = Backbone.Model.extend({
this.setTimeout(); this.setTimeout();
}, this); }, this);
// find a command with no error // find a command with no error (aka unprocessed)
while (popped.get('error') && this.buffer.length) { while (popped.get('error') && this.buffer.length) {
popped = this.buffer.pop(); popped = this.buffer.pop();
} }

8
todo.txt
View file

@ -10,12 +10,9 @@ Medium things:
Commands Commands
======== ========
[ ] multiple things can process!!!
[ ] sip from buffer with post-command hooks. ideally the git engine [ ] sip from buffer with post-command hooks. ideally the git engine
knows nothing about the level being played knows nothing about the level being played
[ ] refactor 'processCommand'
[ ] text input from the commandPromptView must flow down into
filters. no hacky stuff anymore where it's part of the option parser,
wtf
Small things to implement: Small things to implement:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@ -35,6 +32,9 @@ Big Bugs to fix:
Done things: Done things:
(I only started this on Dec 17th 2012 to get a better sense of what was done) (I only started this on Dec 17th 2012 to get a better sense of what was done)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[x] text input from the commandPromptView must flow down into
filters. no hacky stuff anymore where it's part of the option parser,
wtf
[x] ok fuckit here is the deal. Command model has minimal logic -- it calls [x] ok fuckit here is the deal. Command model has minimal logic -- it calls
to a parse waterfall that expands any shortcuts needed, handles any instant to a parse waterfall that expands any shortcuts needed, handles any instant
commands, and then finally will handle the dispatching. I think this will be commands, and then finally will handle the dispatching. I think this will be