mirror/pcottle.learnGitBranching
1
0
Fork 0
mirror of https://github.com/pcottle/learnGitBranching.git synced 2025-06-29 17:27:22 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Firefox prompt huge fix, Issue #59

Browse source
This commit is contained in:
Peter Cottle 2013-03-02 10:39:54 -08:00
parent a7c2b8936c
commit d17d131d24
7 changed files with 18 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
build/bundle.js
View file

@ -19580,7 +19580,7 @@ var CommandPromptView = Backbone.View.extend({
}, },
onKeyDown: function(e) { onKeyDown: function(e) {
var el = e.srcElement; var el = e.srcElement || e.currentTarget;
this.updatePrompt(el); this.updatePrompt(el);
}, },
@ -19637,7 +19637,7 @@ var CommandPromptView = Backbone.View.extend({
cursorUpdate: function(commandLength, selectionStart, selectionEnd) { cursorUpdate: function(commandLength, selectionStart, selectionEnd) {
if (selectionStart === undefined || selectionEnd === undefined) { if (selectionStart === undefined || selectionEnd === undefined) {
selectionStart = commandLength - 1; selectionStart = Math.max(commandLength - 1, 0);
selectionEnd = commandLength; selectionEnd = commandLength;
} }
@ -26203,7 +26203,7 @@ var CommandPromptView = Backbone.View.extend({
}, },
onKeyDown: function(e) { onKeyDown: function(e) {
var el = e.srcElement; var el = e.srcElement || e.currentTarget;
this.updatePrompt(el); this.updatePrompt(el);
}, },
@ -26260,7 +26260,7 @@ var CommandPromptView = Backbone.View.extend({
cursorUpdate: function(commandLength, selectionStart, selectionEnd) { cursorUpdate: function(commandLength, selectionStart, selectionEnd) {
if (selectionStart === undefined || selectionEnd === undefined) { if (selectionStart === undefined || selectionEnd === undefined) {
selectionStart = commandLength - 1; selectionStart = Math.max(commandLength - 1, 0);
selectionEnd = commandLength; selectionEnd = commandLength;
} }

2
build/bundle.min.b47122e1.js → build/bundle.min.9d2f4d92.js
View file

File diff suppressed because one or more lines are too long

2
build/bundle.min.js vendored
View file

File diff suppressed because one or more lines are too long

4
build/main.c4a547fb.css → build/main.fd4e7757.css
View file

@ -1049,6 +1049,10 @@ div.gitDemonstrationView {
height: 100%; height: 100%;
} }
#commandLineBar {
min-height: 30px;
}
#interfaceWrapper { #interfaceWrapper {
width: 100%; width: 100%;
height: 100%; height: 100%;

4
index.html
View file

@ -13,7 +13,7 @@
<meta property="og:image" content="http://pcottle.github.com/learnGitBranching/assets/learnGitBranching.png"/> <meta property="og:image" content="http://pcottle.github.com/learnGitBranching/assets/learnGitBranching.png"/>
<meta property="og:description" content="A interactive Git visualization tool to educate and challenge!"/> <meta property="og:description" content="A interactive Git visualization tool to educate and challenge!"/>
<link rel="stylesheet" href="build/main.c4a547fb.css" type="text/css" charset="utf-8"> <link rel="stylesheet" href="build/main.fd4e7757.css" type="text/css" charset="utf-8">
<link rel="stylesheet" href="src/style/font-awesome.css" type="text/css" charset="utf-8"> <link rel="stylesheet" href="src/style/font-awesome.css" type="text/css" charset="utf-8">
</head> </head>
<body> <body>
@ -412,7 +412,7 @@
For a much easier time perusing the source, see the individual files at: For a much easier time perusing the source, see the individual files at:
https://github.com/pcottle/learnGitBranching https://github.com/pcottle/learnGitBranching
--> -->
<script src="build/bundle.min.b47122e1.js"></script> <script src="build/bundle.min.9d2f4d92.js"></script>
<!-- The advantage of github pages: super-easy, simple, slick static hostic. <!-- The advantage of github pages: super-easy, simple, slick static hostic.
The downside? No raw logs to parse for analytics, so I have to include The downside? No raw logs to parse for analytics, so I have to include

4
src/js/views/commandViews.js
View file

@ -74,7 +74,7 @@ var CommandPromptView = Backbone.View.extend({
}, },
onKeyDown: function(e) { onKeyDown: function(e) {
var el = e.srcElement; var el = e.srcElement || e.currentTarget;
this.updatePrompt(el); this.updatePrompt(el);
}, },
@ -131,7 +131,7 @@ var CommandPromptView = Backbone.View.extend({
cursorUpdate: function(commandLength, selectionStart, selectionEnd) { cursorUpdate: function(commandLength, selectionStart, selectionEnd) {
if (selectionStart === undefined || selectionEnd === undefined) { if (selectionStart === undefined || selectionEnd === undefined) {
selectionStart = commandLength - 1; selectionStart = Math.max(commandLength - 1, 0);
selectionEnd = commandLength; selectionEnd = commandLength;
} }

4
src/style/main.css
View file

@ -1049,6 +1049,10 @@ div.gitDemonstrationView {
height: 100%; height: 100%;
} }
#commandLineBar {
min-height: 30px;
}
#interfaceWrapper { #interfaceWrapper {
width: 100%; width: 100%;
height: 100%; height: 100%;