ugly ugly bug with circular fields

src/js/git/index.js

@@ -363,7 +363,7 @@ GitEngine.prototype.makeOrigin = function(treeString) {
 };
 
 GitEngine.prototype.setLocalToTrackRemote = function(localBranch, remoteBranch) {
-  remoteBranch.addLocalBranchThatTracksThis(localBranch);
+  remoteBranch.addLocalBranchThatTracksThis(localBranch.get('id'));
   localBranch.setRemoteTrackingBranchID(remoteBranch.get('id'));
 
   if (!this.command) {

src/js/models/commandModel.js

@@ -116,8 +116,8 @@ var Command = Backbone.Model.extend({
     }
   },
 
-  oneArgImpliedHead: function(args, option) {
-    this.validateArgBounds(args, 0, 1, option);
+  oneArgImpliedHead: function(args) {
+    this.validateArgBounds(args, 0, 1);
     // and if it's one, add a HEAD to the back
     if (args.length === 0) {
       args.push('HEAD');

src/js/visuals/animation/animationFactory.js

@@ -138,6 +138,9 @@ AnimationFactory.refreshTree = function(animationQueue, gitVisuals) {
 AnimationFactory.genHighlightPromiseAnimation = function(commit, destObj) {
   // could be branch or node
   var visObj = destObj.get('visBranch') || destObj.get('visNode');
+  if (!visObj) {
+    debugger;
+  }
   var visNode = commit.get('visNode');
   return new PromiseAnimation(makeHighlightAnimation(visNode, visObj));
 };

src/js/visuals/visBranch.js

@@ -60,6 +60,12 @@ var VisBranch = VisBase.extend({
     }
 
     this.get('branch').set('visBranch', this);
+    if (this.get('branch').get('id') === 'o/master') {
+      console.log('set visbranch on this', this.get('branch'), this);
+      window.debugVisBranch = this;
+      window.debugBranch = this.get('branch');
+      debugger;
+    }
     var id = this.get('branch').get('id');
 
     if (id == 'HEAD') {

src/js/visuals/visNode.js

@@ -141,9 +141,6 @@ var VisNode = VisBase.extend({
   },
 
   highlightTo: function(visObj, speed, easing) {
-    if (!visObj) {
-      debugger;
-    }
     // a small function to highlight the color of a node for demonstration purposes
     var color = visObj.get('fill');