Resolves #486 -- easier to understand button labels when interactive rebasing

This commit is contained in:
Peter Cottle 2018-09-30 21:47:09 -07:00
parent cf6fec06e7
commit 780f53e226
3 changed files with 21 additions and 4 deletions

View file

@ -164,7 +164,6 @@ var RebaseEntryView = Backbone.View.extend({
}, },
render: function() { render: function() {
var json = this.model.toJSON();
this.$el.append(this.template(this.model.toJSON())); this.$el.append(this.template(this.model.toJSON()));
// hacky :( who would have known jquery barfs on ids with %'s and quotes // hacky :( who would have known jquery barfs on ids with %'s and quotes

View file

@ -770,6 +770,19 @@ li.rebaseEntry a#toggleButton {
li.rebaseEntry.notPicked { li.rebaseEntry.notPicked {
opacity: 0.2; opacity: 0.2;
} }
li.rebaseEntry.notPicked span.showWhenPicked {
display: none;
}
li.rebaseEntry span.showWhenNotPicked {
display: none;
}
li.rebaseEntry.notPicked span.showWhenNotPicked {
display: inline;
}
/* Modal Views */ /* Modal Views */
div.modalView.box.inFront.show { div.modalView.box.inFront.show {

View file

@ -394,7 +394,7 @@
<% if (solutionOrder && solutionOrder.length) { %> <% if (solutionOrder && solutionOrder.length) { %>
<p class="solutionText"> <p class="solutionText">
For the solution, order the commits as For the solution, order the commits as
<%= solutionOrder.join(', ') %> <%= solutionOrder.join(', ') %>. You may need to omit or pick commits.
</p> </p>
<% } %> <% } %>
<p class="helperText"> <p class="helperText">
@ -452,7 +452,12 @@
<%= id %> <%= id %>
</span> </span>
<a id="toggleButton" class="uiButton uiButtonPink"> <a id="toggleButton" class="uiButton uiButtonPink">
Pick <span class="showWhenPicked">
Omit
</span>
<span class="showWhenNotPicked">
Pick
</span>
</a> </a>
</div> </div>
</li> </li>