From 638a711c4d5bfd49fb9b7fa42222ccd122f278e6 Mon Sep 17 00:00:00 2001 From: Hongarc Date: Sat, 13 Apr 2019 09:31:07 +0700 Subject: [PATCH] use `every` instead of _.uniq Array.every is better for check all pass --- src/js/graph/treeCompare.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/js/graph/treeCompare.js b/src/js/graph/treeCompare.js index 9b37bc60..ad3324f4 100644 --- a/src/js/graph/treeCompare.js +++ b/src/js/graph/treeCompare.js @@ -98,11 +98,9 @@ TreeCompare.compareAllBranchesWithinTrees = function(treeA, treeB) { treeB.branches ); - var result = true; - _.uniq(allBranches, function(info, branch) { - result = result && this.compareBranchWithinTrees(treeA, treeB, branch); - }, this); - return result; + return Object.keys(allBranches).every(function(branch) { + return this.compareBranchWithinTrees(treeA, treeB, branch); + }.bind(this)); }; TreeCompare.compareAllTagsWithinTrees = function(treeA, treeB) {