mirror/pcottle.learnGitBranching
1
0
Fork 0
mirror of https://github.com/pcottle/learnGitBranching.git synced 2025-06-27 16:38:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #564 from Hongarc/unused

Browse source 
chore: use `every` instead of `uniq`
This commit is contained in:
Peter Cottle 2019-04-21 12:52:37 -07:00 • committed by GitHub
commit 48f38817f5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/js/graph/treeCompare.js
View file

@ -98,11 +98,9 @@ TreeCompare.compareAllBranchesWithinTrees = function(treeA, treeB) {
treeB.branches
);
var result = true;
_.uniq(allBranches, function(info, branch) {
result = result && this.compareBranchWithinTrees(treeA, treeB, branch);
}, this);
return result;
return Object.keys(allBranches).every(function(branch) {
return this.compareBranchWithinTrees(treeA, treeB, branch);
}.bind(this));
};
TreeCompare.compareAllTagsWithinTrees = function(treeA, treeB) {

2
src/js/stores/LevelStore.js
View file

@ -3,8 +3,6 @@
var AppConstants = require('../constants/AppConstants');
var AppDispatcher = require('../dispatcher/AppDispatcher');
var EventEmitter = require('events').EventEmitter;
var _ = require('underscore');
var assign = require('object-assign');
var levelSequences = require('../../levels').levelSequences;
var sequenceInfo = require('../../levels').sequenceInfo;