From 23397adec2382e5356362b030dcf6bc38215cf17 Mon Sep 17 00:00:00 2001 From: Peter Cottle Date: Fri, 3 Aug 2018 10:21:39 -0700 Subject: [PATCH] Resolves #477 -- scope binding issue with refresh --- src/js/visuals/index.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/js/visuals/index.js b/src/js/visuals/index.js index f7a274ef..70678ff3 100644 --- a/src/js/visuals/index.js +++ b/src/js/visuals/index.js @@ -48,7 +48,9 @@ function GitVisuals(options) { this.flipFraction = 0.65; var Main = require('../app'); - Main.getEvents().on('refreshTree', this.refreshTree, this); + var that = this; + this._onRefreshTree = function() { that.refreshTree(); }; + Main.getEvents().on('refreshTree', this._onRefreshTree, this); } GitVisuals.prototype.defer = function(action) { @@ -100,7 +102,7 @@ GitVisuals.prototype.tearDown = function() { // these over time. However we aren't calling tearDown in // some places... but this is an improvement var Main = require('../app'); - Main.getEvents().removeListener('refreshTree', this.refreshTree); + Main.getEvents().removeListener('refreshTree', this._onRefreshTree); }; GitVisuals.prototype.assignGitEngine = function(gitEngine) { @@ -949,4 +951,3 @@ function blendHueStrings(hueStrings) { } exports.GitVisuals = GitVisuals; -