mirror of
https://github.com/pcottle/learnGitBranching.git
synced 2025-07-12 23:54:27 +02:00
got rid of every underscore bind i think -- 1500 line diff
This commit is contained in:
parent
3833319476
commit
2257668f9d
21 changed files with 229 additions and 230 deletions
|
@ -272,9 +272,9 @@ var LevelBuilder = Level.extend({
|
|||
deferred: whenDoneEditing
|
||||
});
|
||||
whenDoneEditing.promise
|
||||
.then(_.bind(function(levelObj) {
|
||||
.then(function(levelObj) {
|
||||
this.startDialogObj = levelObj;
|
||||
}, this))
|
||||
}.bind(this))
|
||||
.fail(function() {
|
||||
// nothing to do, they dont want to edit it apparently
|
||||
})
|
||||
|
@ -316,10 +316,10 @@ var LevelBuilder = Level.extend({
|
|||
]
|
||||
});
|
||||
askForHintView.getPromise()
|
||||
.then(_.bind(this.defineHint, this))
|
||||
.fail(_.bind(function() {
|
||||
.then(this.defineHint, this))
|
||||
.fail(function() {
|
||||
this.level.hint = {'en_US': ''};
|
||||
}, this))
|
||||
}.bind(this))
|
||||
.done(function() {
|
||||
askForHintDeferred.resolve();
|
||||
});
|
||||
|
@ -337,13 +337,13 @@ var LevelBuilder = Level.extend({
|
|||
]
|
||||
});
|
||||
askForStartView.getPromise()
|
||||
.then(_.bind(function() {
|
||||
.then(function() {
|
||||
// oh boy this is complex
|
||||
var whenEditedDialog = Q.defer();
|
||||
// the undefined here is the command that doesnt need resolving just yet...
|
||||
this.editDialog(undefined, whenEditedDialog);
|
||||
return whenEditedDialog.promise;
|
||||
}, this))
|
||||
}.bind(this))
|
||||
.fail(function() {
|
||||
// if they dont want to edit the start dialog, do nothing
|
||||
})
|
||||
|
@ -352,14 +352,14 @@ var LevelBuilder = Level.extend({
|
|||
});
|
||||
}
|
||||
|
||||
chain = chain.done(_.bind(function() {
|
||||
chain = chain.done(function() {
|
||||
// ok great! lets just give them the goods
|
||||
new MarkdownPresenter({
|
||||
fillerText: JSON.stringify(this.getExportObj(), null, 2),
|
||||
previewText: intl.str('share-json')
|
||||
});
|
||||
command.finishWith(deferred);
|
||||
}, this));
|
||||
}.bind(this));
|
||||
|
||||
masterDeferred.resolve();
|
||||
},
|
||||
|
|
|
@ -204,7 +204,7 @@ var Level = Sandbox.extend({
|
|||
// If the goal visualization gets dragged to the right side of the screen, then squeeze the main
|
||||
// repo visualization a bit to make room. This way, you could have the goal window hang out on
|
||||
// the right side of the screen and still see the repo visualization.
|
||||
this.goalVis.customEvents.on('drag', _.bind(function(event, ui) {
|
||||
this.goalVis.customEvents.on('drag', function(event, ui) {
|
||||
if (ui.position.left > 0.5 * $(window).width()) {
|
||||
if (!$('#goalPlaceholder').is(':visible')) {
|
||||
$('#goalPlaceholder').show();
|
||||
|
@ -216,7 +216,7 @@ var Level = Sandbox.extend({
|
|||
this.mainVis.myResize();
|
||||
}
|
||||
}
|
||||
}, this));
|
||||
}.bind(this));
|
||||
|
||||
return this.goalCanvasHolder;
|
||||
},
|
||||
|
@ -242,14 +242,14 @@ var Level = Sandbox.extend({
|
|||
|
||||
showSolution: function(command, deferred) {
|
||||
var toIssue = this.level.solutionCommand;
|
||||
var issueFunc = _.bind(function() {
|
||||
var issueFunc = function() {
|
||||
this.isShowingSolution = true;
|
||||
Main.getEventBaton().trigger(
|
||||
'commandSubmitted',
|
||||
toIssue
|
||||
);
|
||||
log.showLevelSolution(this.getEnglishName());
|
||||
}, this);
|
||||
}.bind(this);
|
||||
|
||||
var commandStr = command.get('rawStr');
|
||||
if (!this.testOptionOnString(commandStr, 'noReset')) {
|
||||
|
@ -368,16 +368,16 @@ var Level = Sandbox.extend({
|
|||
initGitShim: function(options) {
|
||||
// ok we definitely want a shim here
|
||||
this.gitShim = new GitShim({
|
||||
beforeCB: _.bind(this.beforeCommandCB, this),
|
||||
afterCB: _.bind(this.afterCommandCB, this),
|
||||
afterDeferHandler: _.bind(this.afterCommandDefer, this)
|
||||
beforeCB: this.beforeCommandCB, this),
|
||||
afterCB: this.afterCommandCB, this),
|
||||
afterDeferHandler: this.afterCommandDefer, this)
|
||||
});
|
||||
},
|
||||
|
||||
undo: function() {
|
||||
this.gitCommandsIssued.pop();
|
||||
Level.__super__.undo.apply(this, arguments);
|
||||
},
|
||||
}.bind(this)
|
||||
|
||||
afterCommandCB: function(command) {
|
||||
if (command.get('error')) {
|
||||
|
@ -516,13 +516,13 @@ var Level = Sandbox.extend({
|
|||
},
|
||||
|
||||
getInstantCommands: function() {
|
||||
var getHint = _.bind(function() {
|
||||
var getHint = function() {
|
||||
var hint = intl.getHint(this.level);
|
||||
if (!hint || !hint.length) {
|
||||
return intl.str('no-hint');
|
||||
}
|
||||
return hint;
|
||||
}, this);
|
||||
}.bind(this);
|
||||
|
||||
return [
|
||||
[/^help$|^\?$/, function() {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue