diff --git a/src/constants.js b/src/constants.js index 11b4c14f..2303388b 100644 --- a/src/constants.js +++ b/src/constants.js @@ -14,6 +14,8 @@ var TIME = { }; var GRAPHICS = { + arrowHeadSize: 8, + nodeRadius: 17, curveControlPointOffset: 50, defaultEasing: 'easeInOut', diff --git a/src/tree.js b/src/tree.js index ed862ec6..14de8a47 100644 --- a/src/tree.js +++ b/src/tree.js @@ -674,12 +674,17 @@ var VisEdge = Backbone.Model.extend({ str += coords(headPos); // arrow head - // TODO default sizing? fill the arrow head? var delta = GRAPHICS.arrowHeadSize || 10; str += ' L' + coords(offset2d(headPos, -delta, delta)); str += ' L' + coords(offset2d(headPos, delta, delta)); str += ' L' + coords(headPos); + // then go back, so we can fill correctly + str += 'C'; + str += coords(offset(headPos, 1)) + ' '; + str += coords(offset(tailPos, -1)) + ' '; + str += coords(tailPos); + return str; }, @@ -698,7 +703,8 @@ var VisEdge = Backbone.Model.extend({ 'stroke-width': GRAPHICS.visBranchStrokeWidth, 'stroke': this.getStrokeColor(), 'stroke-linecap': 'round', - 'stroke-linejoin': 'round' + 'stroke-linejoin': 'round', + 'fill': this.getStrokeColor() }); path.toBack(); this.set('path', path); diff --git a/todo.txt b/todo.txt index e3837e9c..594a7228 100644 --- a/todo.txt +++ b/todo.txt @@ -6,15 +6,12 @@ animation factory? stuff like: -highlightCommit(50, 'targetColor') // during search -clearHighlightsAllNodes - ALSO other big things: -- Division in their rings based on how many / what branches they are part of - Color on branch edges?? Big Graphic things: ~~~~~~~~~~~~~~~~~~~~~~~~~ - colored branch edges. basically -- node rings, really think we should do it - When you are rebasing and you hit the bottom, all the nodes go in the wrong spot... We need some kind of "update everything but this set of nodes" thing... - averaging colors! @@ -31,6 +28,6 @@ Small things to implement: Bugs to fix: -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~