mirror/pcottle.learnGitBranching
1
0
Fork 0
mirror of https://github.com/pcottle/learnGitBranching.git synced 2025-06-28 08:50:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

and for model destory TODO polyfill TODO mixin

Browse source
This commit is contained in:
Peter Cottle 2015-04-11 12:13:19 -07:00
parent d4e0887bc7
commit 1427ba0e58
3 changed files with 54 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/js/models/commandModel.js
View file

@ -201,7 +201,6 @@ var Command = Backbone.Model.extend({
},
addWarning: function(msg) {
console.log('this is the warning', msg);
this.get('warnings').push(msg);
// change numWarnings so the change event fires. This is bizarre -- Backbone can't
// detect if an array changes, so adding an element does nothing

6
src/js/react_views/CommandView.jsx
View file

@ -18,11 +18,17 @@ var CommandView = React.createClass({
componentDidMount: function() {
this.props.command.on('change', this.updateStateFromModel, this);
this.props.command.on('destroy', this.onModelDestroy, this);
this.updateStateFromModel();
},
componentWillUnmount: function() {
this.props.command.off('change', this.updateStateFromModel, this);
this.props.command.off('destroy', this.onModelDestroy, this);
},
onModelDestroy: function() {
React.unmountComponentAtNode(this.getDOMNode().parentNode);
},
updateStateFromModel: function() {