plugins/lspkind: refactoring + tests (#259)

plugins/completion/lspkind.nix

@@ -8,28 +8,22 @@ with lib; let
   cfg = config.plugins.lspkind;
   helpers = import ../helpers.nix {inherit lib;};
 in {
-  options.plugins.lspkind = {
+  options.plugins.lspkind =
+    helpers.extraOptionsOptions
+    // {
       enable = mkEnableOption "lspkind.nvim";
 
       package = helpers.mkPackageOption "lspkind" pkgs.vimPlugins.lspkind-nvim;
 
-    mode = mkOption {
+      mode =
-      type = with types; nullOr (enum ["text" "text_symbol" "symbol_text" "symbol"]);
+        helpers.defaultNullOpts.mkEnum
-      default = null;
+        ["text" "text_symbol" "symbol_text" "symbol"]
-      description = "Defines how annotations are shown";
+        "symbol_text"
-    };
+        "Defines how annotations are shown";
 
-    preset = mkOption {
+      preset = helpers.defaultNullOpts.mkEnum ["default" "codicons"] "codicons" "Default symbol map";
-      type = with types; nullOr (enum ["default" "codicons"]);
-      default = null;
-      description = "Default symbol map";
-    };
 
-    symbolMap = mkOption {
+      symbolMap = helpers.mkNullOrOption (types.attrsOf types.str) "Override preset symbols";
-      type = with types; nullOr (attrsOf str);
-      default = null;
-      description = "Override preset symbols";
-    };
 
       cmp = {
         enable = mkOption {
@@ -38,29 +32,19 @@ in {
           description = "Integrate with nvim-cmp";
         };
 
-      maxWidth = mkOption {
+        maxWidth =
-        type = with types; nullOr int;
+          helpers.mkNullOrOption types.int
-        default = null;
+          "Maximum number of characters to show in the popup";
-        description = "Maximum number of characters to show in the popup";
-      };
 
-      ellipsisChar = mkOption {
+        ellipsisChar =
-        type = with types; nullOr str;
+          helpers.mkNullOrOption types.str
-        default = null;
+          "Character to show when the popup exceeds maxwidth";
-        description = "Character to show when the popup exceeds maxwidth";
-      };
 
-      menu = mkOption {
+        menu = helpers.mkNullOrOption (types.attrsOf types.str) "Show source names in the popup";
-        type = with types; nullOr (attrsOf str);
-        default = null;
-        description = "Show source names in the popup";
-      };
 
-      after = mkOption {
+        after =
-        type = with types; nullOr types.str;
+          helpers.mkNullOrOption types.str
-        default = null;
+          "Function to run after calculating the formatting. function(entry, vim_item, kind)";
-        description = "Function to run after calculating the formatting. function(entry, vim_item, kind)";
-      };
       };
     };
 
@@ -80,7 +64,8 @@ in {
           menu = cfg.cmp.menu;
         }
         else {}
-      );
+      )
+      // cfg.extraOptions;
   in
     mkIf cfg.enable {
       extraPlugins = [cfg.package];

tests/plugins/lspkind.nix

@@ -0,0 +1,23 @@
+{
+  # Empty configuration
+  empty = {
+    plugins.lspkind.enable = true;
+  };
+
+  # All the upstream default options of lspkind
+  defaults = {
+    plugins.lspkind = {
+      enable = true;
+      mode = "symbol_text";
+      preset = "codicons";
+      symbolMap = null;
+      cmp = {
+        enable = true;
+        maxWidth = 50;
+        ellipsisChar = "...";
+        menu = null;
+        after = null;
+      };
+    };
+  };
+}