plugins: remove all use of lib.nixvim.mkPackageOption

plugins/ai/chatgpt.nix

@@ -13,9 +13,8 @@ helpers.neovim-plugin.mkNeovimPlugin {
   maintainers = [ maintainers.GaetanLepage ];
 
   extraOptions = {
-    curlPackage = helpers.mkPackageOption {
+    curlPackage = lib.mkPackageOption pkgs "curl" {
-      name = "curl";
+      nullable = true;
-      default = pkgs.curl;
     };
   };
 

plugins/completion/cmp/sources/cmp-fish.nix

@@ -13,9 +13,8 @@ in
   meta.maintainers = [ maintainers.GaetanLepage ];
 
   options.plugins.cmp-fish = {
-    fishPackage = helpers.mkPackageOption {
+    fishPackage = lib.mkPackageOption pkgs "fish" {
-      name = "fish";
+      nullable = true;
-      default = pkgs.fish;
     };
   };
 

plugins/completion/coq.nix

@@ -16,11 +16,14 @@ helpers.neovim-plugin.mkNeovimPlugin {
   ];
 
   extraOptions = {
+    # TODO: should this enable option be replaced with `nullable = true` in the package option?
     installArtifacts = mkEnableOption "and install coq-artifacts";
-    artifactsPackage = mkOption {
+    artifactsPackage = mkPackageOption pkgs "coq-artifacts" {
-      type = types.package;
+      extraDescription = "Installed when `installArtifacts` is enabled.";
-      description = "Package to use for coq-artifacts (when enabled with installArtifacts)";
+      default = [
-      default = pkgs.vimPlugins.coq-artifacts;
+        "vimPlugins"
+        "coq-artifacts"
+      ];
     };
   };
 

plugins/filetrees/neo-tree.nix

@@ -62,9 +62,8 @@ in
         "nvim-web-devicons"
       ] { nullable = true; };
 
-      gitPackage = helpers.mkPackageOption {
+      gitPackage = lib.mkPackageOption pkgs "git" {
-        name = "git";
+        nullable = true;
-        default = pkgs.git;
       };
 
       sources =

plugins/filetrees/nvim-tree.nix

@@ -46,9 +46,8 @@ in
       "nvim-web-devicons"
     ] { nullable = true; };
 
-    gitPackage = helpers.mkPackageOption {
+    gitPackage = lib.mkPackageOption pkgs "git" {
-      name = "git";
+      nullable = true;
-      default = pkgs.git;
     };
 
     disableNetrw = helpers.defaultNullOpts.mkBool false "Disable netrw";

plugins/git/committia.nix

@@ -1,5 +1,6 @@
 {
   helpers,
+  lib,
   pkgs,
   ...
 }:
@@ -47,9 +48,8 @@ helpers.vim-plugin.mkVimPlugin {
   };
 
   extraOptions = {
-    gitPackage = helpers.mkPackageOption {
+    gitPackage = lib.mkPackageOption pkgs "git" {
-      name = "git";
+      nullable = true;
-      default = pkgs.git;
     };
   };
 

plugins/git/fugitive.nix

@@ -13,9 +13,8 @@ helpers.vim-plugin.mkVimPlugin {
 
   # In typical tpope fashion, this plugin has no config options
   extraOptions = {
-    gitPackage = helpers.mkPackageOption {
+    gitPackage = lib.mkPackageOption pkgs "git" {
-      name = "git";
+      nullable = true;
-      default = pkgs.git;
     };
   };
 

plugins/git/git-conflict.nix

@@ -13,9 +13,8 @@ helpers.neovim-plugin.mkNeovimPlugin {
   maintainers = [ maintainers.GaetanLepage ];
 
   extraOptions = {
-    gitPackage = helpers.mkPackageOption {
+    gitPackage = lib.mkPackageOption pkgs "git" {
-      name = "git";
+      nullable = true;
-      default = pkgs.git;
     };
   };
 

plugins/git/git-worktree.nix

@@ -16,9 +16,8 @@ in
 
       package = helpers.mkPluginPackageOption "git-worktree" pkgs.vimPlugins.git-worktree-nvim;
 
-      gitPackage = helpers.mkPackageOption {
+      gitPackage = lib.mkPackageOption pkgs "git" {
-        name = "git";
+        nullable = true;
-        default = pkgs.git;
       };
 
       enableTelescope = mkEnableOption "telescope integration";

plugins/git/gitblame.nix

@@ -4,7 +4,7 @@
   ...
 }:
 let
-  inherit (lib.nixvim) defaultNullOpts mkPackageOption;
+  inherit (lib.nixvim) defaultNullOpts;
   types = lib.nixvim.nixvimTypes;
 in
 lib.nixvim.neovim-plugin.mkNeovimPlugin {
@@ -128,9 +128,8 @@ lib.nixvim.neovim-plugin.mkNeovimPlugin {
   };
 
   extraOptions = {
-    gitPackage = mkPackageOption {
+    gitPackage = lib.mkPackageOption pkgs "git" {
-      name = "git";
+      nullable = true;
-      default = pkgs.git;
     };
   };
 

plugins/git/gitgutter.nix

@@ -16,9 +16,8 @@ in
 
       package = helpers.mkPluginPackageOption "gitgutter" pkgs.vimPlugins.gitgutter;
 
-      gitPackage = helpers.mkPackageOption {
+      gitPackage = lib.mkPackageOption pkgs "git" {
-        name = "git";
+        nullable = true;
-        default = pkgs.git;
       };
 
       recommendedSettings = mkOption {

plugins/git/gitsigns/default.nix

@@ -242,9 +242,8 @@ helpers.neovim-plugin.mkNeovimPlugin {
     ];
 
   extraOptions = {
-    gitPackage = helpers.mkPackageOption {
+    gitPackage = lib.mkPackageOption pkgs "git" {
-      name = "git";
+      nullable = true;
-      default = pkgs.git;
     };
   };
 

plugins/git/lazygit.nix

@@ -70,14 +70,12 @@ helpers.vim-plugin.mkVimPlugin {
   };
 
   extraOptions = {
-    gitPackage = helpers.mkPackageOption {
+    gitPackage = lib.mkPackageOption pkgs "git" {
-      name = "git";
+      nullable = true;
-      default = pkgs.git;
     };
 
-    lazygitPackage = helpers.mkPackageOption {
+    lazygitPackage = lib.mkPackageOption pkgs "lazygit" {
-      name = "lazygit";
+      nullable = true;
-      default = pkgs.lazygit;
     };
   };
 

plugins/git/neogit/default.nix

@@ -101,9 +101,8 @@ helpers.neovim-plugin.mkNeovimPlugin {
   };
 
   extraOptions = {
-    gitPackage = helpers.mkPackageOption {
+    gitPackage = lib.mkPackageOption pkgs "git" {
-      name = "git";
+      nullable = true;
-      default = pkgs.git;
     };
   };
 

plugins/languages/godot.nix

@@ -14,9 +14,9 @@ helpers.vim-plugin.mkVimPlugin {
   maintainers = [ maintainers.GaetanLepage ];
 
   extraOptions = {
-    godotPackage = helpers.mkPackageOption {
+    godotPackage = lib.mkPackageOption pkgs "godot" {
-      name = "godot";
+      nullable = true;
-      default = pkgs.godot_4;
+      default = "godot_4";
     };
   };
 

plugins/languages/lean.nix

@@ -15,9 +15,9 @@ in
 
     package = helpers.mkPluginPackageOption "lean-nvim" pkgs.vimPlugins.lean-nvim;
 
-    leanPackage = helpers.mkPackageOption {
+    leanPackage = lib.mkPackageOption pkgs "lean" {
-      name = "lean";
+      nullable = true;
-      default = pkgs.lean4;
+      default = "lean4";
     };
 
     lsp = helpers.defaultNullOpts.mkNullable (

plugins/languages/ledger.nix

@@ -45,9 +45,8 @@ mkVimPlugin {
     ];
 
   extraOptions = {
-    ledgerPackage = helpers.mkPackageOption {
+    ledgerPackage = lib.mkPackageOption pkgs "ledger" {
-      name = "ledger";
+      nullable = true;
-      default = pkgs.ledger;
     };
   };
 

plugins/languages/markdown/glow.nix

@@ -72,13 +72,8 @@ helpers.neovim-plugin.mkNeovimPlugin {
   };
 
   extraOptions = {
-    glowPackage = helpers.mkPackageOption {
+    glowPackage = lib.mkPackageOption pkgs "glow" {
-      description = ''
+      nullable = true;
-        Which package to use for `glow` in your `$PATH`.
-        Set to `null` to disable its automatic installation.
-      '';
-      default = pkgs.glow;
-      defaultText = lib.literalExpression "pkgs.glow";
     };
   };
 

plugins/languages/rust/rust-tools.nix

@@ -13,9 +13,8 @@ in
   options.plugins.rust-tools = helpers.neovim-plugin.extraOptionsOptions // {
     enable = mkEnableOption "rust tools plugins";
     package = helpers.mkPluginPackageOption "rust-tools" pkgs.vimPlugins.rust-tools-nvim;
-    serverPackage = helpers.mkPackageOption {
+    serverPackage = lib.mkPackageOption pkgs "rust-analyzer" {
-      name = "rust-analyzer";
+      nullable = true;
-      default = pkgs.rust-analyzer;
     };
 
     executor = helpers.defaultNullOpts.mkEnumFirstDefault [

plugins/languages/rust/rustaceanvim/default.nix

@@ -16,9 +16,8 @@ helpers.neovim-plugin.mkNeovimPlugin {
   optionsRenamedToSettings = import ./renamed-options.nix;
 
   extraOptions = {
-    rustAnalyzerPackage = helpers.mkPackageOption {
+    rustAnalyzerPackage = lib.mkPackageOption pkgs "rust-analyzer" {
-      name = "rust-analyzer";
+      nullable = true;
-      default = pkgs.rust-analyzer;
     };
   };
 

plugins/languages/texpresso.nix

@@ -15,9 +15,8 @@ helpers.vim-plugin.mkVimPlugin {
   maintainers = [ maintainers.nickhu ];
 
   extraOptions = {
-    texpressoPackage = helpers.mkPackageOption {
+    texpressoPackage = lib.mkPackageOption pkgs "texpresso" {
-      name = "texpresso";
+      nullable = true;
-      default = pkgs.texpresso;
     };
   };
 

plugins/languages/vimtex.nix

@@ -54,9 +54,13 @@ helpers.vim-plugin.mkVimPlugin {
   };
 
   extraOptions = {
-    texlivePackage = helpers.mkPackageOption {
+    texlivePackage = lib.mkPackageOption pkgs "texlive" {
-      name = "texlive";
+      nullable = true;
-      default = pkgs.texlive.combined.scheme-medium;
+      default = [
+        "texlive"
+        "combined"
+        "scheme-medium"
+      ];
     };
   };
 

plugins/pluginmanagers/lazy.nix

@@ -41,9 +41,8 @@ in
     plugins.lazy = {
       enable = mkEnableOption "lazy.nvim";
 
-      gitPackage = helpers.mkPackageOption {
+      gitPackage = lib.mkPackageOption pkgs "git" {
-        name = "git";
+        nullable = true;
-        default = pkgs.git;
       };
 
       plugins =

plugins/pluginmanagers/packer.nix

@@ -14,9 +14,8 @@ in
     plugins.packer = {
       enable = mkEnableOption "packer.nvim";
 
-      gitPackage = helpers.mkPackageOption {
+      gitPackage = lib.mkPackageOption pkgs "git" {
-        name = "git";
+        nullable = true;
-        default = pkgs.git;
       };
 
       plugins =

plugins/statuslines/lualine.nix

@@ -108,9 +108,8 @@ in
 
       package = helpers.mkPluginPackageOption "lualine" pkgs.vimPlugins.lualine-nvim;
 
-      gitPackage = helpers.mkPackageOption {
+      gitPackage = lib.mkPackageOption pkgs "git" {
-        name = "git";
+        nullable = true;
-        default = pkgs.git;
       };
 
       iconsEnabled = mkOption {

plugins/utils/fzf-lua.nix

@@ -40,10 +40,9 @@ helpers.neovim-plugin.mkNeovimPlugin {
   inherit settingsOptions settingsExample;
 
   extraOptions = {
-    fzfPackage = helpers.mkPackageOption {
+    fzfPackage = lib.mkPackageOption pkgs "fzf" {
-      name = "fzf";
+      nullable = true;
-      default = pkgs.fzf;
+      example = "pkgs.skim";
-      example = pkgs.skim;
     };
 
     # TODO: deprecated 2024-08-29 remove after 24.11

plugins/utils/todo-comments.nix

@@ -10,7 +10,6 @@ let
     defaultNullOpts
     keymaps
     mkNullOrOption'
-    mkPackageOption
     transitionType
     ;
   types = lib.nixvim.nixvimTypes;
@@ -405,9 +404,8 @@ lib.nixvim.neovim-plugin.mkNeovimPlugin {
           todoTelescope = "TodoTelescope";
         };
 
-    ripgrepPackage = mkPackageOption {
+    ripgrepPackage = lib.mkPackageOption pkgs "ripgrep" {
-      name = "ripgrep";
+      nullable = true;
-      default = pkgs.ripgrep;
     };
   };
 

plugins/utils/zk.nix

@@ -108,9 +108,8 @@ helpers.neovim-plugin.mkNeovimPlugin {
   };
 
   extraOptions = {
-    zkPackage = helpers.mkPackageOption {
+    zkPackage = lib.mkPackageOption pkgs "zk" {
-      name = "zk";
+      nullable = true;
-      default = pkgs.zk;
     };
   };
   extraConfig = cfg: {