From 9af4c3970c13c4508f5f724e2a6a315ba5ba88e3 Mon Sep 17 00:00:00 2001 From: Matt Sturgeon Date: Sat, 24 Aug 2024 19:55:13 +0100 Subject: [PATCH] tests: fix tests by enabling `wrapRc` Since cbd1003d9d3dcc371f0602a66ff32af9f8c14490 I'm able to add _some_ invalid config definitions to modules the tests are using and get no build error. For example `extraConfigLua = null;` should produce an invalid type error, but doesn't. One less visible change in that commit is the move away from using the "standalone" wrapper (`makeNixvimWithModule`), which implicitly sets `wrapRc = true`. Adding back `wrapRc` to the tests seems to fix the issue, however this makes me wonder if there's an underlying issue with wrapping/not-wrapping? Perhaps we've simply uncovered a long-standing eval issue that is masked over by using `wrapRc`? --- lib/tests.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/tests.nix b/lib/tests.nix index 01f4607d..7b5c250a 100644 --- a/lib/tests.nix +++ b/lib/tests.nix @@ -60,6 +60,7 @@ let "mkTestDerivationFromNixvimModule: the `dontRun` argument is deprecated. You should use the `test.runNvim` module option instead." { config.test.runNvim = !dontRun; } )) + { wrapRc = true; } ]; extraSpecialArgs = { defaultPkgs = pkgs;