modules: refactor extraFiles

Moved `extraFiles` from `modules/output.nix` into its own file `modules/files.nix`.

Users should now assign text to a `text` attribute, however they could
also assign a file path to a `source` attribute instead.

The old method of directly assigning a string still works, and is
coerced to the new type along with a deprecation warning.

modules/default.nix

@@ -12,6 +12,7 @@
     ./diagnostics.nix
     ./doc.nix
     ./editorconfig.nix
+    ./files.nix
     ./filetype.nix
     ./highlights.nix
     ./keymaps.nix

modules/files.nix

@@ -0,0 +1,82 @@
+{
+  lib,
+  helpers,
+  pkgs,
+  ...
+}:
+let
+  fileType = lib.types.submodule (
+    {
+      name,
+      config,
+      options,
+      ...
+    }:
+    {
+      options = {
+        enable = lib.mkOption {
+          type = lib.types.bool;
+          default = true;
+          description = ''
+            Whether this file should be generated.
+            This option allows specific files to be disabled.
+          '';
+        };
+
+        target = lib.mkOption {
+          type = lib.types.str;
+          defaultText = lib.literalMD "the attribute name";
+          description = ''
+            Name of symlink, relative to nvim config.
+          '';
+        };
+
+        text = lib.mkOption {
+          type = with lib.types; nullOr lines;
+          default = null;
+          description = "Text of the file.";
+        };
+
+        source = lib.mkOption {
+          type = lib.types.path;
+          description = "Path of the source file.";
+        };
+      };
+
+      config =
+        let
+          derivationName = "nvim-" + lib.replaceStrings [ "/" ] [ "-" ] name;
+        in
+        {
+          target = lib.mkDefault name;
+          source = lib.mkIf (config.text != null) (
+            # mkDerivedConfig uses the option's priority, and calls our function with the option's value.
+            # This means our `source` definition has the same priority as `text`.
+            lib.mkDerivedConfig options.text (pkgs.writeText derivationName)
+          );
+        };
+    }
+  );
+
+  # TODO: Added 2024-07-07, remove after 24.11
+  # Before we had a fileType, we used types.str.
+  coercedFileType = helpers.transitionType lib.types.str (text: { inherit text; }) fileType;
+in
+{
+  options = {
+    extraFiles = lib.mkOption {
+      type = lib.types.attrsOf coercedFileType;
+      description = "Extra files to add to the runtime path";
+      default = { };
+      example = lib.literalExpression ''
+        {
+          "ftplugin/nix.lua".text = '''
+            vim.opt.tabstop = 2
+            vim.opt.shiftwidth = 2
+            vim.opt.expandtab = true
+          ''';
+        }
+      '';
+    };
+  };
+}

modules/output.nix

@@ -95,12 +95,6 @@ in
       description = "Extra lua packages to include with neovim";
       default = _: [ ];
     };
-
-    extraFiles = mkOption {
-      type = types.attrsOf types.str;
-      description = "Extra files to add to the runtime path";
-      default = { };
-    };
   };
 
   config =

modules/top-level/files/default.nix

@@ -1,6 +1,7 @@
 {
   pkgs,
   config,
+  options,
   lib,
   helpers,
   ...
@@ -49,8 +50,8 @@ in
 
   config =
     let
-      inherit (config) files;
-      concatFilesOption = attr: lib.flatten (lib.mapAttrsToList (_: builtins.getAttr attr) files);
+      extraFiles = lib.filter (file: file.enable) (lib.attrValues config.extraFiles);
+      concatFilesOption = attr: lib.flatten (lib.mapAttrsToList (_: builtins.getAttr attr) config.files);
     in
     {
       # Each file can declare plugins/packages/warnings/assertions
@@ -59,12 +60,38 @@ in
       warnings = concatFilesOption "warnings";
       assertions = concatFilesOption "assertions";
 
+      # Add files to extraFiles
+      extraFiles = lib.mkDerivedConfig options.files (
+        lib.mapAttrs' (
+          _: file: {
+            name = file.path;
+            value.source = file.plugin;
+          }
+        )
+      );
+
       # A directory with all the files in it
-      filesPlugin = pkgs.buildEnv {
-        name = "nixvim-config";
-        paths =
-          (lib.mapAttrsToList (_: file: file.plugin) files)
-          ++ (lib.mapAttrsToList pkgs.writeTextDir config.extraFiles);
-      };
+      # Implementation based on NixOS's /etc module
+      filesPlugin = pkgs.runCommandLocal "nvim-config" { } ''
+        set -euo pipefail
+
+        makeEntry() {
+          src="$1"
+          target="$2"
+          mkdir -p "$out/$(dirname "$target")"
+          cp "$src" "$out/$target"
+        }
+
+        mkdir -p "$out"
+        ${lib.concatMapStringsSep "\n" (
+          { target, source, ... }:
+          lib.escapeShellArgs [
+            "makeEntry"
+            # Force local source paths to be added to the store
+            "${source}"
+            target
+          ]
+        ) extraFiles}
+      '';
     };
 }

modules/top-level/files/submodule.nix

@@ -14,9 +14,14 @@
       internal = true;
     };
   };
-  config = {
-    path = name;
-    type = lib.mkDefault (if lib.hasSuffix ".vim" name then "vim" else "lua");
-    plugin = pkgs.writeTextDir config.path config.content;
-  };
+  config =
+    let
+      derivationName = "nvim-" + lib.replaceStrings [ "/" ] [ "-" ] name;
+    in
+    {
+      path = lib.mkDefault name;
+      type = lib.mkDefault (if lib.hasSuffix ".vim" name then "vim" else "lua");
+      # No need to use mkDerivedConfig; this option is readOnly.
+      plugin = pkgs.writeText derivationName config.content;
+    };
 }

plugins/languages/treesitter/treesitter.nix

@@ -178,7 +178,7 @@ in
         '');
 
       extraFiles = mkIf cfg.nixvimInjections {
-        "queries/nix/injections.scm" = ''
+        "queries/nix/injections.scm".text = ''
           ;; extends
 
           (binding

tests/test-sources/modules/extra-files.nix

@@ -1,7 +1,13 @@
 {
   query = {
     extraFiles = {
-      "queries/lua/injections.scm" = ''
+      "testing/test-case.nix".source = ./extra-files.nix;
+      "testing/123.txt".text = ''
+        One
+        Two
+        Three
+      '';
+      "queries/lua/injections.scm".text = ''
         ;; extends
       '';
     };

wrappers/_shared.nix

@@ -1,23 +1,37 @@
 helpers:
 { lib, config, ... }:
 let
-  inherit (lib) mkOption mkOptionType;
+  inherit (lib)
+    isAttrs
+    listToAttrs
+    map
+    mkOption
+    mkOptionType
+    ;
   cfg = config.programs.nixvim;
+  extraFiles = lib.filter (file: file.enable) (lib.attrValues cfg.extraFiles);
 in
 {
   helpers = mkOption {
     type = mkOptionType {
       name = "helpers";
       description = "Helpers that can be used when writing nixvim configs";
-      check = builtins.isAttrs;
+      check = isAttrs;
     };
     description = "Use this option to access the helpers";
     default = helpers;
   };
 
-  configFiles =
-    (lib.mapAttrs' (_: file: lib.nameValuePair "nvim/${file.path}" { text = file.content; }) cfg.files)
-    // (lib.mapAttrs' (
-      path: content: lib.nameValuePair "nvim/${path}" { text = content; }
-    ) cfg.extraFiles);
+  # extraFiles, but nested under "nvim/" for use in etc/xdg config
+  configFiles = listToAttrs (
+    map (
+      { target, source, ... }:
+      {
+        name = "nvim/" + target;
+        value = {
+          inherit source;
+        };
+      }
+    ) extraFiles
+  );
 }