mirror/fosrl.pangolin
1
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2025-07-31 08:04:54 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Dont do socket on non-newt sites

Browse source
This commit is contained in:
Owen 2025-06-04 16:02:45 -04:00
parent 58a2a9dcc9
commit df4da75c57
No known key found for this signature in database
GPG key ID: 8271FDFFD9E0CCBD
6 changed files with 45 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

2
server/routers/site/createSite.ts
View file

@ -141,6 +141,7 @@ export async function createSite(
niceId,
subnet,
type,
dockerSocketEnabled: type == "newt",
...(pubKey && type == "wireguard" && { pubKey })
})
.returning();
@ -154,6 +155,7 @@ export async function createSite(
name,
niceId,
type,
dockerSocketEnabled: type == "newt",
subnet: "0.0.0.0/0"
})
.returning();

2
src/app/[orgId]/settings/resources/[resourceId]/ResourceInfoBox.tsx
View file

@ -20,7 +20,7 @@ export default function ResourceInfoBox({}: ResourceInfoBoxType) {
const { resource, authInfo, site } = useResourceContext();
const api = createApiClient(useEnvContext());
const { isEnabled, isAvailable } = useDockerSocket(resource.siteId);
const { isEnabled, isAvailable } = useDockerSocket(site!);
let fullUrl = `${resource.ssl ? "https" : "http"}://${resource.fullDomain}`;

2
src/app/[orgId]/settings/resources/[resourceId]/proxy/page.tsx
View file

@ -776,7 +776,7 @@ export default function ReverseProxyTargets(props: {
<Input id="ip" {...field} />
</FormControl>
<FormMessage />
{site && (
{site && site.type == 'newt' && (
<ContainersSelector
site={site}
onContainerSelect={(

14
src/app/[orgId]/settings/sites/[niceId]/general/page.tsx
View file

@ -129,6 +129,7 @@ export default function GeneralPage() {
</FormItem>
)}
/>
{site && site.type === "newt" && (
<FormField
control={form.control}
name="dockerSocketEnabled"
@ -138,7 +139,9 @@ export default function GeneralPage() {
<SwitchInput
id="docker-socket-enabled"
label="Enable Docker Socket"
defaultChecked={field.value}
defaultChecked={
field.value
}
onCheckedChange={
field.onChange
}
@ -146,14 +149,15 @@ export default function GeneralPage() {
</FormControl>
<FormMessage />
<FormDescription>
Enable Docker Socket discovery
for populating container
information, useful in resource
targets.
Enable Docker Socket
discovery for populating
container information,
useful in resource targets.
</FormDescription>
</FormItem>
)}
/>
)}
</form>
</Form>
</SettingsSectionForm>

3
src/components/ContainersSelector.tsx
View file

@ -68,8 +68,9 @@ export const ContainersSelector: FC<ContainerSelectorProps> = ({
}) => {
const [open, setOpen] = useState(false);
const isDesktop = useMediaQuery("(min-width: 768px)");
const { isAvailable, containers, fetchContainers } = useDockerSocket(
site.siteId
site
);
useEffect(() => {

48
src/hooks/useDockerSocket.ts
View file

@ -10,15 +10,13 @@ import {
} from "@server/routers/site";
import { AxiosResponse } from "axios";
import { toast } from "./useToast";
import { Site } from "@server/db";
const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
export function useDockerSocket(siteId: number) {
if (!siteId) {
throw new Error("Site ID is required to use Docker Socket");
}
export function useDockerSocket(site: Site) {
console.log(`useDockerSocket initialized for site ID: ${site.siteId}`);
const [site, setSite] = useState<GetSiteResponse>();
const [dockerSocket, setDockerSocket] = useState<GetDockerStatusResponse>();
const [containers, setContainers] = useState<Container[]>([]);
@ -27,40 +25,18 @@ export function useDockerSocket(siteId: number) {
const { dockerSocketEnabled: isEnabled = true } = site || {};
const { isAvailable = false, socketPath } = dockerSocket || {};
const fetchSite = useCallback(async () => {
try {
const res = await api.get<AxiosResponse<GetSiteResponse>>(
`/site/${siteId}`
);
if (res.status === 200) {
setSite(res.data.data);
}
} catch (err) {
console.error(err);
toast({
variant: "destructive",
title: "Failed to fetch resource",
description: formatAxiosError(
err,
"An error occurred while fetching resource"
)
});
}
}, [api, siteId]);
const checkDockerSocket = useCallback(async () => {
if (!isEnabled) {
console.warn("Docker socket is not enabled for this site.");
return;
}
try {
const res = await api.post(`/site/${siteId}/docker/check`);
const res = await api.post(`/site/${site.siteId}/docker/check`);
console.log("Docker socket check response:", res);
} catch (error) {
console.error("Failed to check Docker socket:", error);
}
}, [api, siteId, isEnabled]);
}, [api, site.siteId, isEnabled]);
const getDockerSocketStatus = useCallback(async () => {
if (!isEnabled) {
@ -70,7 +46,7 @@ export function useDockerSocket(siteId: number) {
try {
const res = await api.get<AxiosResponse<GetDockerStatusResponse>>(
`/site/${siteId}/docker/status`
`/site/${site.siteId}/docker/status`
);
if (res.status === 200) {
@ -92,7 +68,7 @@ export function useDockerSocket(siteId: number) {
description: "An error occurred while fetching Docker status."
});
}
}, [api, siteId, isEnabled]);
}, [api, site.siteId, isEnabled]);
const getContainers = useCallback(
async (maxRetries: number = 3) => {
@ -111,7 +87,7 @@ export function useDockerSocket(siteId: number) {
try {
const res = await api.get<
AxiosResponse<ListContainersResponse>
>(`/site/${siteId}/docker/containers`);
>(`/site/${site.siteId}/docker/containers`);
setContainers(res.data.data);
return;
} catch (error: any) {
@ -160,7 +136,7 @@ export function useDockerSocket(siteId: number) {
try {
const res = await api.post<AxiosResponse<TriggerFetchResponse>>(
`/site/${siteId}/docker/trigger`
`/site/${site.siteId}/docker/trigger`
);
// TODO: identify a way to poll the server for latest container list periodically?
await fetchContainerList();
@ -169,13 +145,9 @@ export function useDockerSocket(siteId: number) {
console.error("Failed to trigger Docker containers:", error);
}
},
[api, siteId, isEnabled, isAvailable]
[api, site.siteId, isEnabled, isAvailable]
);
useEffect(() => {
fetchSite();
}, [fetchSite]);
// 2. Docker socket status monitoring
useEffect(() => {
if (!isEnabled || isAvailable) {