increase hitbox for links in buttons

This commit is contained in:
Milo Schwartz 2025-01-23 22:34:12 -05:00
parent d1fead5050
commit 02b5f4d390
No known key found for this signature in database
4 changed files with 35 additions and 37 deletions

View file

@ -17,7 +17,7 @@ import { useOrgContext } from "@app/hooks/useOrgContext";
import { useToast } from "@app/hooks/useToast"; import { useToast } from "@app/hooks/useToast";
import Link from "next/link"; import Link from "next/link";
import { useRouter } from "next/navigation"; import { useRouter } from "next/navigation";
import { formatAxiosError } from "@app/lib/api";; import { formatAxiosError } from "@app/lib/api";
import { createApiClient } from "@app/lib/api"; import { createApiClient } from "@app/lib/api";
import { useEnvContext } from "@app/hooks/useEnvContext"; import { useEnvContext } from "@app/hooks/useEnvContext";
import { useUserContext } from "@app/hooks/useUserContext"; import { useUserContext } from "@app/hooks/useUserContext";
@ -75,14 +75,14 @@ export default function UsersTable({ users: u }: UsersTableProps) {
</Button> </Button>
</DropdownMenuTrigger> </DropdownMenuTrigger>
<DropdownMenuContent align="end"> <DropdownMenuContent align="end">
<DropdownMenuItem> <Link
<Link href={`/${org?.org.orgId}/settings/access/users/${userRow.id}`}
href={`/${org?.org.orgId}/settings/access/users/${userRow.id}`} className="block w-full"
className="block w-full" >
> <DropdownMenuItem>
Manage User Manage User
</Link> </DropdownMenuItem>
</DropdownMenuItem> </Link>
{userRow.email !== user?.email && ( {userRow.email !== user?.email && (
<DropdownMenuItem <DropdownMenuItem
onClick={() => { onClick={() => {

View file

@ -25,7 +25,7 @@ import CreateResourceForm from "./CreateResourceForm";
import { useState } from "react"; import { useState } from "react";
import ConfirmDeleteDialog from "@app/components/ConfirmDeleteDialog"; import ConfirmDeleteDialog from "@app/components/ConfirmDeleteDialog";
import { set } from "zod"; import { set } from "zod";
import { formatAxiosError } from "@app/lib/api";; import { formatAxiosError } from "@app/lib/api";
import { useToast } from "@app/hooks/useToast"; import { useToast } from "@app/hooks/useToast";
import { createApiClient } from "@app/lib/api"; import { createApiClient } from "@app/lib/api";
import { useEnvContext } from "@app/hooks/useEnvContext"; import { useEnvContext } from "@app/hooks/useEnvContext";
@ -91,14 +91,14 @@ export default function SitesTable({ resources, orgId }: ResourcesTableProps) {
</Button> </Button>
</DropdownMenuTrigger> </DropdownMenuTrigger>
<DropdownMenuContent align="end"> <DropdownMenuContent align="end">
<DropdownMenuItem> <Link
<Link className="block w-full"
className="block w-full" href={`/${resourceRow.orgId}/settings/resources/${resourceRow.id}`}
href={`/${resourceRow.orgId}/settings/resources/${resourceRow.id}`} >
> <DropdownMenuItem>
View settings View settings
</Link> </DropdownMenuItem>
</DropdownMenuItem> </Link>
<DropdownMenuItem <DropdownMenuItem
onClick={() => { onClick={() => {
setSelectedResource(resourceRow); setSelectedResource(resourceRow);
@ -146,14 +146,14 @@ export default function SitesTable({ resources, orgId }: ResourcesTableProps) {
cell: ({ row }) => { cell: ({ row }) => {
const resourceRow = row.original; const resourceRow = row.original;
return ( return (
<Button variant="outline"> <Link
<Link href={`/${resourceRow.orgId}/settings/sites/${resourceRow.siteId}`}
href={`/${resourceRow.orgId}/settings/sites/${resourceRow.siteId}`} >
> <Button variant="outline">
{resourceRow.site} {resourceRow.site}
</Link> <ArrowUpRight className="ml-2 h-4 w-4" />
<ArrowUpRight className="ml-2 h-4 w-4" /> </Button>
</Button> </Link>
); );
} }
}, },

View file

@ -145,14 +145,12 @@ export default function ShareLinksTable({
cell: ({ row }) => { cell: ({ row }) => {
const r = row.original; const r = row.original;
return ( return (
<Button variant="outline"> <Link href={`/${orgId}/settings/resources/${r.resourceId}`}>
<Link <Button variant="outline">
href={`/${orgId}/settings/resources/${r.resourceId}`}
>
{r.resourceName} {r.resourceName}
</Link> <ArrowUpRight className="ml-2 h-4 w-4" />
<ArrowUpRight className="ml-2 h-4 w-4" /> </Button>
</Button> </Link>
); );
} }
}, },

View file

@ -92,14 +92,14 @@ export default function SitesTable({ sites, orgId }: SitesTableProps) {
</Button> </Button>
</DropdownMenuTrigger> </DropdownMenuTrigger>
<DropdownMenuContent align="end"> <DropdownMenuContent align="end">
<DropdownMenuItem> <Link
<Link className="block w-full"
className="block w-full" href={`/${siteRow.orgId}/settings/sites/${siteRow.nice}`}
href={`/${siteRow.orgId}/settings/sites/${siteRow.nice}`} >
> <DropdownMenuItem>
View settings View settings
</Link> </DropdownMenuItem>
</DropdownMenuItem> </Link>
<DropdownMenuItem <DropdownMenuItem
onClick={() => { onClick={() => {
setSelectedSite(siteRow); setSelectedSite(siteRow);