mirror/advplyr.audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2025-08-01 16:54:59 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Merge pull request #4223 from Vito0912/feat/fixCrashEmptyCollection
Some checks are pending
CodeQL / Analyze (push) Waiting to run
Details
Run Component Tests / Run Component Tests (push) Waiting to run
Details
Build and Push Docker Image / build (push) Waiting to run
Details
Verify all i18n files are alphabetized / update_translations (push) Waiting to run
Details
Integration Test / build and test (push) Waiting to run
Details
Run Unit Tests / Run Unit Tests (push) Waiting to run
Details

Browse source 
Fix server crash when a user requests the RSS feed of an empty collection
This commit is contained in:
advplyr 2025-04-26 13:43:38 -05:00 • committed by GitHub
commit ec05bd36e4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
server/models/FeedEpisode.js
View file

@ -215,9 +215,13 @@ class FeedEpisode extends Model {
* @returns {Promise<FeedEpisode[]>}
*/
static async createFromBooks(books, feed, slug, transaction) {
const earliestLibraryItemCreatedAt = books.reduce((earliest, book) => {
return book.libraryItem.createdAt < earliest.libraryItem.createdAt ? book : earliest
}).libraryItem.createdAt
// This is never null unless the books array is empty, as this method is not invoked when no books. Reduce needs an initial item
const earliestLibraryItemCreatedAt =
books.length > 0
? books.reduce((earliest, book) => {
return book.libraryItem.createdAt < earliest.libraryItem.createdAt ? book : earliest
}).libraryItem.createdAt
: null
const feedEpisodeObjs = []
let numExisting = 0