Notifications UI update and delete endpoint

server/controllers/NotificationController.js

@@ -18,17 +18,8 @@ class NotificationController {
     res.sendStatus(200)
   }
 
-  async createEvent(req, res) {
-    const success = this.db.notificationSettings.addNewEvent(req.body)
-
-    if (success) {
-      await this.db.updateEntity('settings', this.db.notificationSettings)
-    }
-    res.sendStatus(200)
-  }
-
-  async updateEvent(req, res) {
-    const success = this.db.notificationSettings.updateEvent(req.body)
+  async createNotification(req, res) {
+    const success = this.db.notificationSettings.createNotification(req.body)
 
     if (success) {
       await this.db.updateEntity('settings', this.db.notificationSettings)
@@ -40,10 +31,40 @@ class NotificationController {
     res.json(this.notificationManager.getData())
   }
 
+  async deleteNotification(req, res) {
+    if (this.db.notificationSettings.removeNotification(req.notification.id)) {
+      await this.db.updateEntity('settings', this.db.notificationSettings)
+    }
+    res.sendStatus(200)
+  }
+
+  async updateNotification(req, res) {
+    const success = this.db.notificationSettings.updateNotification(req.body)
+
+    if (success) {
+      await this.db.updateEntity('settings', this.db.notificationSettings)
+    }
+    res.sendStatus(200)
+  }
+
+  sendNotificationTest(req, res) {
+    this.notificationManager.onTest()
+    res.sendStatus(200)
+  }
+
   middleware(req, res, next) {
     if (!req.user.isAdminOrUp) {
       return res.sendStatus(404)
     }
+
+    if (req.params.id) {
+      const notification = this.db.notificationSettings.getNotification(req.params.id)
+      if (!notification) {
+        return res.sendStatus(404)
+      }
+      req.notification = notification
+    }
+
     next()
   }
 }

server/managers/NotificationManager.js

@@ -48,8 +48,8 @@ class NotificationManager {
 
   sendNotification(notification, eventData) {
     const payload = notification.getApprisePayload(eventData)
-    return axios.post(`${this.db.notificationSettings.appriseApiUrl}/notify`, payload, { timeout: 6000 }).then((data) => {
-      Logger.debug(`[NotificationManager] sendNotification: ${notification.eventName}/${notification.id} response=${data}`)
+    return axios.post(`${this.db.notificationSettings.appriseApiUrl}/notify`, payload, { timeout: 6000 }).then((response) => {
+      Logger.debug(`[NotificationManager] sendNotification: ${notification.eventName}/${notification.id} response=`, response.data)
       return true
     }).catch((error) => {
       Logger.error(`[NotificationManager] sendNotification: ${notification.eventName}/${notification.id} error=`, error)

server/objects/settings/NotificationSettings.js

@@ -15,7 +15,7 @@ class NotificationSettings {
   construct(settings) {
     this.appriseType = settings.appriseType
     this.appriseApiUrl = settings.appriseApiUrl || null
-    this.notifications = (settings.notifications || []).map(n => ({ ...n }))
+    this.notifications = (settings.notifications || []).map(n => new Notification(n))
   }
 
   toJSON() {
@@ -35,6 +35,18 @@ class NotificationSettings {
     return this.notifications.filter(n => n.eventName === eventName)
   }
 
+  getNotification(id) {
+    return this.notifications.find(n => n.id === id)
+  }
+
+  removeNotification(id) {
+    if (this.notifications.some(n => n.id === id)) {
+      this.notifications = this.notifications.filter(n => n.id !== id)
+      return true
+    }
+    return false
+  }
+
   update(payload) {
     if (!payload) return false
     if (payload.appriseApiUrl !== this.appriseApiUrl) {
@@ -44,7 +56,7 @@ class NotificationSettings {
     return false
   }
 
-  addNewEvent(payload) {
+  createNotification(payload) {
     if (!payload) return false
     // TODO: validate
 
@@ -54,7 +66,7 @@ class NotificationSettings {
     return true
   }
 
-  updateEvent(payload) {
+  updateNotification(payload) {
     if (!payload) return false
     const notification = this.notifications.find(n => n.id === payload.id)
     if (!notification) return false

server/routers/ApiRouter.js

@@ -206,9 +206,11 @@ class ApiRouter {
     //
     this.router.get('/notifications', NotificationController.middleware.bind(this), NotificationController.get.bind(this))
     this.router.patch('/notifications', NotificationController.middleware.bind(this), NotificationController.update.bind(this))
-    this.router.post('/notifications/event', NotificationController.middleware.bind(this), NotificationController.createEvent.bind(this))
-    this.router.patch('/notifications/event', NotificationController.middleware.bind(this), NotificationController.updateEvent.bind(this))
     this.router.get('/notificationdata', NotificationController.middleware.bind(this), NotificationController.getData.bind(this))
+    this.router.post('/notifications', NotificationController.middleware.bind(this), NotificationController.createNotification.bind(this))
+    this.router.delete('/notifications/:id', NotificationController.middleware.bind(this), NotificationController.deleteNotification.bind(this))
+    this.router.patch('/notifications/:id', NotificationController.middleware.bind(this), NotificationController.updateNotification.bind(this))
+    this.router.get('/notifications/:id/test', NotificationController.middleware.bind(this), NotificationController.sendNotificationTest.bind(this))
 
     //
     // Misc Routes