From e364dd1a20e33fcfa2349c3473bcb93b95363bb4 Mon Sep 17 00:00:00 2001
From: Dag <me@dvikan.no>
Date: Thu, 8 May 2025 22:37:56 +0200
Subject: [PATCH] fix(atom): omit item timestamp if absent (#4541)

prev behavior inserted current time, which seems wrong
---
 formats/AtomFormat.php | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/formats/AtomFormat.php b/formats/AtomFormat.php
index 7908eb90..8df51189 100644
--- a/formats/AtomFormat.php
+++ b/formats/AtomFormat.php
@@ -72,10 +72,9 @@ class AtomFormat extends FormatAbstract
         $feed->appendChild($id);
         $id->appendChild($document->createTextNode($feedUrl));
 
-        $feedTimestamp = gmdate(DATE_ATOM, $this->lastModified);
         $updated = $document->createElement('updated');
         $feed->appendChild($updated);
-        $updated->appendChild($document->createTextNode($feedTimestamp));
+        $updated->appendChild($document->createTextNode(gmdate(DATE_ATOM, $this->lastModified)));
 
         // since we can't guarantee that all items have an author,
         // a global feed author is mandatory
@@ -108,10 +107,6 @@ class AtomFormat extends FormatAbstract
                 $entryID = 'urn:sha1:' . hash('sha1', $entryTitle . $entryContent);
             }
 
-            if (empty($entryTimestamp)) {
-                $entryTimestamp = $this->lastModified;
-            }
-
             if (empty($entryTitle)) {
                 $entryTitle = str_replace("\n", ' ', strip_tags($entryContent));
                 if (strlen($entryTitle) > 140) {
@@ -132,14 +127,17 @@ class AtomFormat extends FormatAbstract
             $title->setAttribute('type', 'html');
             $title->appendChild($document->createTextNode($entryTitle));
 
-            $entryTimestamp = gmdate(\DATE_ATOM, $entryTimestamp);
-            $published = $document->createElement('published');
-            $entry->appendChild($published);
-            $published->appendChild($document->createTextNode($entryTimestamp));
+            if ($entryTimestamp) {
+                $timestamp = gmdate(\DATE_ATOM, $entryTimestamp);
 
-            $updated = $document->createElement('updated');
-            $entry->appendChild($updated);
-            $updated->appendChild($document->createTextNode($entryTimestamp));
+                $published = $document->createElement('published');
+                $entry->appendChild($published);
+                $published->appendChild($document->createTextNode($timestamp));
+
+                $updated = $document->createElement('updated');
+                $entry->appendChild($updated);
+                $updated->appendChild($document->createTextNode($timestamp));
+            }
 
             $id = $document->createElement('id');
             $entry->appendChild($id);