mirror/RSS-Bridge.rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-08-04 01:55:21 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

refactor(BridgeFactory): make methods only accept valid class names (#2897)

Browse source 
This moves the responsibility for getting a valid class name
to the users of BridgeFactory, avoiding the repeated sanitation.
Improper use can also be checked statically.
This commit is contained in:
Jan Tojnar 2022-07-08 12:54:23 +02:00 • committed by GitHub
parent 20bf2aa4fe
commit dbf8c5b7ae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 102 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/Actions/ActionImplementationTest.php
View file

@ -40,7 +40,7 @@ class ActionImplementationTest extends TestCase
$this->setAction($path);
$methods = get_class_methods($this->obj);
$methods = array_diff(get_class_methods($this->obj), ['__construct']);
sort($methods);
$this->assertEquals($allowedMethods, $methods);

2
tests/Actions/ListActionTest.php
View file

@ -49,7 +49,7 @@ class ListActionTest extends TestCase
$bridgeFactory = new BridgeFactory();
$this->assertEquals(
count($bridgeFactory->getBridgeNames()),
count($bridgeFactory->getBridgeClassNames()),
count($items['bridges']),
'Number of bridges doesn\'t match'
);