mirror/RSS-Bridge.rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-07-02 18:14:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

refacor: improve cache interface (#3492)

Browse source 
* fix: proper typehint on setScope

* refactor: type hint setKey()

* typehint
This commit is contained in:
Dag 2023-07-06 15:10:30 +02:00 • committed by GitHub
parent f8801d8cb3
commit caac7f572c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 56 additions and 220 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/BridgeAbstract.php
View file

@ -410,11 +410,10 @@ abstract class BridgeAbstract implements BridgeInterface
/**
* Loads a cached value for the specified key
*
* @param string $key Key name
* @param int $duration Cache duration (optional)
* @return mixed Cached value or null if the key doesn't exist or has expired
*/
protected function loadCacheValue($key, $duration = null)
protected function loadCacheValue(string $key, $duration = null)
{
$cacheFactory = new CacheFactory();
@ -422,7 +421,7 @@ abstract class BridgeAbstract implements BridgeInterface
// Create class name without the namespace part
$scope = $this->getShortName();
$cache->setScope($scope);
$cache->setKey($key);
$cache->setKey([$key]);
$timestamp = $cache->getTime();
if (
@ -438,17 +437,16 @@ abstract class BridgeAbstract implements BridgeInterface
/**
* Stores a value to cache with the specified key
*
* @param string $key Key name
* @param mixed $value Value to cache
*/
protected function saveCacheValue($key, $value)
protected function saveCacheValue(string $key, $value)
{
$cacheFactory = new CacheFactory();
$cache = $cacheFactory->create();
$scope = $this->getShortName();
$cache->setScope($scope);
$cache->setKey($key);
$cache->setKey([$key]);
$cache->saveData($value);
}