mirror/Part-DB.Part-DB-server
1
0
Fork 1
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2025-06-20 17:15:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Escape space in attachment URLs with %20

Browse source 
Fixes issue #401
This commit is contained in:
Jan Böhmer 2023-10-15 00:50:43 +02:00
parent 180505cba4
commit f53c98312e
2 changed files with 30 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/Entity/Attachments/Attachment.php
View file

@ -472,6 +472,10 @@ abstract class Attachment extends AbstractNamedDBElement
#[SerializedName('url')]
public function setURL(?string $url): self
{
$url = trim($url);
//Escape spaces in URL
$url = str_replace(' ', '%20', $url);
//Only set if the URL is not empty
if ($url !== null && $url !== '') {
if (str_contains($url, '%BASE%') || str_contains($url, '%MEDIA%')) {

26
tests/Entity/Attachments/AttachmentTest.php
View file

@ -265,6 +265,32 @@ class AttachmentTest extends TestCase
$this->assertSame($expected, $attachment->getFilename());
}
public function testSetURL(): void
{
$attachment = new PartAttachment();
//Set URL
$attachment->setURL('https://google.de');
$this->assertSame('https://google.de', $attachment->getURL());
//Ensure that an empty url does not overwrite the existing one
$attachment->setPath('%MEDIA%/foo/bar.txt');
$attachment->setURL(' ');
$this->assertSame('%MEDIA%/foo/bar.txt', $attachment->getPath());
//Ensure that spaces get replaced by %20
$attachment->setURL('https://google.de/test file.txt');
$this->assertSame('https://google.de/test%20file.txt', $attachment->getURL());
}
public function testSetURLForbiddenURL(): void
{
$attachment = new PartAttachment();
$this->expectException(InvalidArgumentException::class);
$attachment->setURL('%MEDIA%/foo/bar.txt');
}
public function testIsURL(): void
{
$url = '%MEDIA%/test.txt';