Fixed inspection issues.

src/Controller/AdminPages/FootprintController.php

@@ -72,7 +72,7 @@ class FootprintController extends BaseAdminController
      *
      * @return \Symfony\Component\HttpFoundation\RedirectResponse
      */
-    public function delete(Request $request, Footprint $entity, StructuralElementRecursionHelper $recursionHelper)
+    public function delete(Request $request, Footprint $entity, StructuralElementRecursionHelper $recursionHelper): \Symfony\Component\HttpFoundation\RedirectResponse
     {
         return $this->_delete($request, $entity, $recursionHelper);
     }
@@ -83,7 +83,7 @@ class FootprintController extends BaseAdminController
      *
      * @return Response
      */
-    public function edit(Footprint $entity, Request $request, EntityManagerInterface $em, ?string $timestamp = null)
+    public function edit(Footprint $entity, Request $request, EntityManagerInterface $em, ?string $timestamp = null): Response
     {
         return $this->_edit($entity, $request, $em, $timestamp);
     }

src/Controller/LogController.php

@@ -53,7 +53,6 @@ use App\Services\LogSystem\EventUndoHelper;
 use App\Services\LogSystem\TimeTravel;
 use Doctrine\ORM\EntityManagerInterface;
 use Omines\DataTablesBundle\DataTableFactory;
-use phpDocumentor\Reflection\Element;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
@@ -100,7 +99,7 @@ class LogController extends AbstractController
     /**
      * @Route("/undo", name="log_undo", methods={"POST"})
      */
-    public function undoRevertLog(Request $request, EventUndoHelper $eventUndoHelper)
+    public function undoRevertLog(Request $request, EventUndoHelper $eventUndoHelper): \Symfony\Component\HttpFoundation\RedirectResponse
     {
         $mode = EventUndoHelper::MODE_UNDO;
         $id = $request->request->get('undo');

src/Controller/TypeaheadController.php

@@ -62,9 +62,11 @@ class TypeaheadController extends AbstractController
     /**
      * @Route("/builtInResources/search/{query}", name="typeahead_builtInRessources", requirements={"query"= ".+"})
      *
+     * @param  string  $query
+     * @param  BuiltinAttachmentsFinder  $finder
      * @return JsonResponse
      */
-    public function builtInResources(Request $request, string $query, BuiltinAttachmentsFinder $finder)
+    public function builtInResources(string $query, BuiltinAttachmentsFinder $finder)
     {
         $array = $finder->find($query);
 

src/Entity/LogSystem/ElementEditedLogEntry.php

@@ -84,11 +84,7 @@ class ElementEditedLogEntry extends AbstractLogEntry implements TimeTravelInterf
             return array_keys($this->getOldData());
         }
 
-        if (isset($this->extra['f'])) {
-            return $this->extra['f'];
-        }
-
-        return [];
+        return $this->extra['f'] ?? [];
     }
 
     /**

src/Entity/Parameters/AbstractParameter.php

@@ -120,16 +120,6 @@ abstract class AbstractParameter extends AbstractNamedDBElement
         }
     }
 
-    /**
-     * Returns the name of the specification (e.g. "Collector-Base Voltage").
-     *
-     * @return string
-     */
-    public function getName(): string
-    {
-        return $this->name;
-    }
-
     /**
      * Returns the element this parameter belongs to.
      *

src/Entity/UserSystem/User.php

@@ -53,7 +53,6 @@ namespace App\Entity\UserSystem;
 use App\Entity\Attachments\AttachmentContainingDBElement;
 use App\Entity\Attachments\UserAttachment;
 use App\Entity\Base\AbstractNamedDBElement;
-use App\Entity\Base\MasterAttachmentTrait;
 use App\Entity\PriceInformations\Currency;
 use App\Security\Interfaces\HasPermissionsInterface;
 use App\Validator\Constraints\Selectable;
@@ -114,7 +113,7 @@ class User extends AttachmentContainingDBElement implements UserInterface, HasPe
      * @var string|null The hash of a token the user must provide when he wants to reset his password.
      * @ORM\Column(type="string", nullable=true)
      */
-    protected $pw_reset_token = null;
+    protected $pw_reset_token;
 
     /**
      * @ORM\Column(type="text", name="config_instock_comment_a")
@@ -252,7 +251,7 @@ class User extends AttachmentContainingDBElement implements UserInterface, HasPe
      * @ORM\JoinColumn(name="currency_id", referencedColumnName="id")
      * @Selectable()
      */
-    protected $currency = null;
+    protected $currency;
 
     /** @var PermissionsEmbed
      * @ORM\Embedded(class="PermissionsEmbed", columnPrefix="perms_")
@@ -264,7 +263,7 @@ class User extends AttachmentContainingDBElement implements UserInterface, HasPe
      * @var DateTime The time until the password reset token is valid.
      * @ORM\Column(type="datetime", nullable=true)
      */
-    protected $pw_reset_expires = null;
+    protected $pw_reset_expires;
 
     public function __construct()
     {