Fixed code style.

This commit is contained in:
Jan Böhmer 2020-08-21 22:44:38 +02:00
parent e01b06fb85
commit e73a90a234
24 changed files with 30 additions and 58 deletions

View file

@ -145,8 +145,6 @@ class CleanAttachmentsCommand extends Command
* This function removes all empty folders inside $path. Taken from https://stackoverflow.com/a/1833681.
*
* @param string $path The path in which the empty folders should be deleted
*
* @return bool
*/
protected function removeEmptySubFolders($path): bool
{

View file

@ -79,8 +79,6 @@ class ManufacturerController extends BaseAdminController
/**
* @Route("/{id}/edit/{timestamp}", requirements={"id"="\d+"}, name="manufacturer_edit")
* @Route("/{id}", requirements={"id"="\d+"})
*
* @return Response
*/
public function edit(Manufacturer $entity, Request $request, EntityManagerInterface $em, ?string $timestamp = null): Response
{

View file

@ -69,8 +69,6 @@ class MeasurementUnitController extends BaseAdminController
/**
* @Route("/{id}", name="measurement_unit_delete", methods={"DELETE"})
*
* @return \Symfony\Component\HttpFoundation\RedirectResponse
*/
public function delete(Request $request, MeasurementUnit $entity, StructuralElementRecursionHelper $recursionHelper): \Symfony\Component\HttpFoundation\RedirectResponse
{
@ -80,8 +78,6 @@ class MeasurementUnitController extends BaseAdminController
/**
* @Route("/{id}/edit/{timestamp}", requirements={"id"="\d+"}, name="measurement_unit_edit")
* @Route("/{id}", requirements={"id"="\d+"})
*
* @return Response
*/
public function edit(MeasurementUnit $entity, Request $request, EntityManagerInterface $em, ?string $timestamp = null): Response
{

View file

@ -68,8 +68,6 @@ class StorelocationController extends BaseAdminController
/**
* @Route("/{id}", name="store_location_delete", methods={"DELETE"})
*
* @return \Symfony\Component\HttpFoundation\RedirectResponse
*/
public function delete(Request $request, Storelocation $entity, StructuralElementRecursionHelper $recursionHelper): RedirectResponse
{
@ -79,8 +77,6 @@ class StorelocationController extends BaseAdminController
/**
* @Route("/{id}/edit/{timestamp}", requirements={"id"="\d+"}, name="store_location_edit")
* @Route("/{id}", requirements={"id"="\d+"})
*
* @return Response
*/
public function edit(Storelocation $entity, Request $request, EntityManagerInterface $em, ?string $timestamp = null): Response
{

View file

@ -69,8 +69,6 @@ class SupplierController extends BaseAdminController
/**
* @Route("/{id}", name="supplier_delete", methods={"DELETE"})
*
* @return \Symfony\Component\HttpFoundation\RedirectResponse
*/
public function delete(Request $request, Supplier $entity, StructuralElementRecursionHelper $recursionHelper): RedirectResponse
{
@ -80,8 +78,6 @@ class SupplierController extends BaseAdminController
/**
* @Route("/{id}/edit/{timestamp}", requirements={"id"="\d+"}, name="supplier_edit")
* @Route("/{id}", requirements={"id"="\d+"})
*
* @return Response
*/
public function edit(Supplier $entity, Request $request, EntityManagerInterface $em, ?string $timestamp = null): Response
{

View file

@ -72,8 +72,6 @@ class TypeaheadController extends AbstractController
/**
* @Route("/builtInResources/search", name="typeahead_builtInRessources")
*
* @return JsonResponse
*/
public function builtInResources(Request $request, BuiltinAttachmentsFinder $finder): JsonResponse
{
@ -103,8 +101,6 @@ class TypeaheadController extends AbstractController
/**
* @Route("/tags/search/{query}", name="typeahead_tags", requirements={"query"= ".+"})
*
* @return JsonResponse
*/
public function tags(string $query, TagFinder $finder): JsonResponse
{

View file

@ -97,8 +97,6 @@ class UserController extends AdminPages\BaseAdminController
* @Route("/{id}/edit/{timestamp}", requirements={"id"="\d+"}, name="user_edit")
* @Route("/{id}/", requirements={"id"="\d+"})
*
* @return Response
*
* @throws \Exception
*/
public function edit(User $entity, Request $request, EntityManagerInterface $em, ?string $timestamp = null): Response
@ -168,8 +166,6 @@ class UserController extends AdminPages\BaseAdminController
/**
* @Route("/{id}", name="user_delete", methods={"DELETE"}, requirements={"id"="\d+"})
*
* @return \Symfony\Component\HttpFoundation\RedirectResponse
*/
public function delete(Request $request, User $entity, StructuralElementRecursionHelper $recursionHelper): RedirectResponse
{

View file

@ -93,6 +93,7 @@ class SecurityEventLogEntry extends AbstractLogEntry
public function getEventType(): string
{
$key = $this->extra['e'];
return static::SECURITY_TYPE_MAPPING[$key] ?? 'unkown';
}

View file

@ -42,8 +42,6 @@ class SecurityEvent extends Event
/**
* Returns the affected user.
*
* @return User
*/
public function getTargetUser(): User
{

View file

@ -119,7 +119,7 @@ final class PermissionsMapper implements DataMapperInterface
* @param mixed $viewData The compound form's view data that get mapped
* its children model data
*/
public function mapFormsToData($forms, &$viewData) :void
public function mapFormsToData($forms, &$viewData): void
{
if ($this->inherit) {
throw new RuntimeException('The permission type is readonly when it is showing read only data!');

View file

@ -59,6 +59,7 @@ final class CustomEnvVarProcessor implements EnvVarProcessorInterface
return false;
}
}
return false;
}

View file

@ -159,7 +159,7 @@ class EntityExporter
$disposition = $response->headers->makeDisposition(
ResponseHeaderBag::DISPOSITION_ATTACHMENT,
$filename,
$string = preg_replace('![^'.preg_quote('-','!').'a-z0-_9\s]+!', '', strtolower($filename))
$string = preg_replace('![^'.preg_quote('-', '!').'a-z0-_9\s]+!', '', strtolower($filename))
);
// Set the content disposition
$response->headers->set('Content-Disposition', $disposition);

View file

@ -151,7 +151,7 @@ class EntityImporter
$tmp = $this->validator->validate($entity);
//When no validation error occured, persist entity to database (cascade must be set in entity)
if ($tmp === null) {
if (null === $tmp) {
$this->em->persist($entity);
} else { //Log validation errors to global log.
$errors[$entity->getFullPath()] = $tmp;

View file

@ -75,8 +75,6 @@ final class LabelGenerator
/**
* Check if the given LabelOptions can be used with $element.
*
* @return bool
*/
public function supports(LabelOptions $options, object $element): bool
{

View file

@ -64,8 +64,6 @@ class MoneyFormatter
* @param Currency|null $currency The currency that should be used for formatting. If null the global one is used
* @param int $decimals the number of decimals that should be shown
* @param bool $show_all_digits if set to true, all digits are shown, even if they are null
*
* @return string
*/
public function format($value, ?Currency $currency = null, $decimals = 5, bool $show_all_digits = false): string
{

View file

@ -124,7 +124,7 @@ class TreeViewGenerator
}
//Translate text if text starts with $$
if (strpos($item->getText(), '$$') === 0) {
if (0 === strpos($item->getText(), '$$')) {
$item->setText($this->translator->trans(substr($item->getText(), 2)));
}
}