mirror/Part-DB.Part-DB-server
1
0
Fork 1
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2025-06-27 04:08:57 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed some inspection issues.

Browse source
This commit is contained in:
Jan Böhmer 2020-08-21 22:43:37 +02:00
parent 6caf605fe2
commit e01b06fb85
80 changed files with 173 additions and 218 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Services/LabelSystem/LabelGenerator.php
View file

@ -78,7 +78,7 @@ final class LabelGenerator
*
* @return bool
*/
public function supports(LabelOptions $options, object $element)
public function supports(LabelOptions $options, object $element): bool
{
$supported_type = $options->getSupportedElement();
if (!isset(static::CLASS_SUPPORT_MAPPING[$supported_type])) {

4
src/Services/LabelSystem/LabelHTMLGenerator.php
View file

@ -68,7 +68,7 @@ final class LabelHTMLGenerator
$page = 1;
foreach ($elements as $element) {
if ('twig' === $options->getLinesMode() && isset($sandboxed_twig) && isset($current_user)) {
if (isset($sandboxed_twig, $current_user) && 'twig' === $options->getLinesMode()) {
try {
$lines = $sandboxed_twig->render(
'lines',
@ -103,7 +103,7 @@ final class LabelHTMLGenerator
]);
}
private function getPDFTitle(LabelOptions $options, object $element)
private function getPDFTitle(LabelOptions $options, object $element): string
{
if ($element instanceof NamedElementInterface) {
return $this->elementTypeNameGenerator->getTypeNameCombination($element, false);

2
src/Services/LabelSystem/PlaceholderProviders/PartLotProvider.php
View file

@ -44,7 +44,7 @@ final class PartLotProvider implements PlaceholderProviderInterface
{
if ($label_target instanceof PartLot) {
if ('[[LOT_ID]]' === $placeholder) {
return $label_target->getID() ?? 'unknown';
return (string) ($label_target->getID() ?? 'unknown');
}
if ('[[LOT_NAME]]' === $placeholder) {