From de0832bece7c292b8e3d2bf53b466dc3288fdba7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20B=C3=B6hmer?= Date: Mon, 6 Jan 2025 00:08:42 +0100 Subject: [PATCH] Removed baarcode scanner inbox, as we now have enough performance to apply the decoder to the full image --- .../controllers/pages/barcode_scan_controller.js | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/assets/controllers/pages/barcode_scan_controller.js b/assets/controllers/pages/barcode_scan_controller.js index 368fef43..c353868c 100644 --- a/assets/controllers/pages/barcode_scan_controller.js +++ b/assets/controllers/pages/barcode_scan_controller.js @@ -33,17 +33,6 @@ export default class extends Controller { connect() { console.log('Init Scanner'); - //This function ensures, that the qrbox is 70% of the total viewport - let qrboxFunction = function(viewfinderWidth, viewfinderHeight) { - let minEdgePercentage = 0.7; // 70% - let minEdgeSize = Math.min(viewfinderWidth, viewfinderHeight); - let qrboxSize = Math.floor(minEdgeSize * minEdgePercentage); - return { - width: qrboxSize, - height: qrboxSize - }; - } - //Try to get the number of cameras. If the number is 0, then the promise will fail, and we show the warning dialog Html5Qrcode.getCameras().catch((devices) => { document.getElementById('scanner-warning').classList.remove('d-none'); @@ -51,11 +40,6 @@ export default class extends Controller { this._scanner = new Html5QrcodeScanner(this.element.id, { fps: 10, - qrbox: qrboxFunction, - experimentalFeatures: { - //This option improves reading quality on android chrome - useBarCodeDetectorIfSupported: true - } }, false); this._scanner.render(this.onScanSuccess.bind(this));