Test the admin pages, if read/list/delete is working.

tests/Controller/AdminPages/AbstractAdminControllerTest.php

@@ -0,0 +1,131 @@
+<?php
+/**
+ *
+ * part-db version 0.1
+ * Copyright (C) 2005 Christoph Lechner
+ * http://www.cl-projects.de/
+ *
+ * part-db version 0.2+
+ * Copyright (C) 2009 K. Jacobs and others (see authors.php)
+ * http://code.google.com/p/part-db/
+ *
+ * Part-DB Version 0.4+
+ * Copyright (C) 2016 - 2019 Jan Böhmer
+ * https://github.com/jbtronics
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ *
+ */
+
+namespace App\Tests\Controller\AdminPages;
+
+
+use App\Entity\Attachments\AttachmentType;
+use Doctrine\ORM\EntityManager;
+use Doctrine\ORM\EntityManagerInterface;
+use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Symfony\Component\Security\Core\Security;
+
+abstract class AbstractAdminControllerTest extends WebTestCase
+{
+    protected static $base_path = 'not_valid';
+    protected static $entity_class = 'not valid';
+
+
+    public function setUp()
+    {
+        parent::setUp();
+        self::bootKernel();
+    }
+
+    public function readDataProvider()
+    {
+        return [
+            ['noread', false],
+            ['anonymous', true],
+            ['user', true],
+            ['admin', true]
+        ];
+    }
+
+    /**
+     * @dataProvider readDataProvider
+     * Tests if you can access the /new part which is used to list all entities. Checks if permissions are working
+     */
+    public function testListEntries(string $user, bool $read)
+    {
+        //Test read access
+        $client = static::createClient([], [
+            'PHP_AUTH_USER' => $user,
+            'PHP_AUTH_PW'   => 'test',
+        ]);
+
+        //Test read/list access by access /new overview page
+        $crawler = $client->request('GET', static::$base_path . '/new');
+        $this->assertFalse($client->getResponse()->isRedirect());
+        $this->assertEquals($read, $client->getResponse()->isSuccessful(), "Controller was not successful!");
+        $this->assertEquals($read, !$client->getResponse()->isForbidden(), "Permission Checking not working!");
+    }
+
+    /**
+     * @dataProvider readDataProvider
+     * Tests if it possible to access an specific entity. Checks if permissions are working.
+     */
+    public function testReadEntity(string $user, bool $read)
+    {
+        //Test read access
+        $client = static::createClient([], [
+            'PHP_AUTH_USER' => $user,
+            'PHP_AUTH_PW'   => 'test',
+        ]);
+
+        //Test read/list access by access /new overview page
+        $crawler = $client->request('GET', static::$base_path . '/1');
+        $this->assertFalse($client->getResponse()->isRedirect());
+        $this->assertEquals($read, $client->getResponse()->isSuccessful(), "Controller was not successful!");
+        $this->assertEquals($read, !$client->getResponse()->isForbidden(), "Permission Checking not working!");
+    }
+
+    public function deleteDataProvider()
+    {
+        return [
+            ['noread', false],
+            ['anonymous', false],
+            ['user', true],
+            ['admin', true]
+        ];
+    }
+
+    /**
+     * Tests if deleting an entity is working.
+     * @dataProvider deleteDataProvider
+     */
+    public function testDeleteEntity(string $user, bool $delete)
+    {
+        //Test read access
+        $client = static::createClient([], [
+            'PHP_AUTH_USER' => $user,
+            'PHP_AUTH_PW'   => 'test',
+        ]);
+
+        //Test read/list access by access /new overview page
+        $crawler = $client->request('DELETE', static::$base_path . '/7');
+
+        //Page is redirected to '/new', when delete was successful
+        $this->assertEquals($delete, $client->getResponse()->isRedirect(static::$base_path . '/new'));
+        $this->assertEquals($delete, !$client->getResponse()->isForbidden(), "Permission Checking not working!");
+    }
+
+}

tests/Controller/AdminPages/AttachmentTypeControllerTest.php

@@ -0,0 +1,41 @@
+<?php
+/**
+ *
+ * part-db version 0.1
+ * Copyright (C) 2005 Christoph Lechner
+ * http://www.cl-projects.de/
+ *
+ * part-db version 0.2+
+ * Copyright (C) 2009 K. Jacobs and others (see authors.php)
+ * http://code.google.com/p/part-db/
+ *
+ * Part-DB Version 0.4+
+ * Copyright (C) 2016 - 2019 Jan Böhmer
+ * https://github.com/jbtronics
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ *
+ */
+
+namespace App\Tests\Controller\AdminPages;
+
+
+use App\Entity\Attachments\AttachmentType;
+
+class AttachmentTypeControllerTest extends AbstractAdminControllerTest
+{
+    protected static $base_path = '/en' . '/attachment_type';
+    protected static $entity_class = AttachmentType::class;
+}

tests/Controller/AdminPages/CategoryControllerTest.php

@@ -0,0 +1,40 @@
+<?php
+/**
+ *
+ * part-db version 0.1
+ * Copyright (C) 2005 Christoph Lechner
+ * http://www.cl-projects.de/
+ *
+ * part-db version 0.2+
+ * Copyright (C) 2009 K. Jacobs and others (see authors.php)
+ * http://code.google.com/p/part-db/
+ *
+ * Part-DB Version 0.4+
+ * Copyright (C) 2016 - 2019 Jan Böhmer
+ * https://github.com/jbtronics
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ *
+ */
+
+namespace App\Tests\Controller\AdminPages;
+
+use App\Entity\Parts\Category;
+
+class CategoryControllerTest extends AbstractAdminControllerTest
+{
+    protected static $base_path = '/en' . '/category';
+    protected static $entity_class = Category::class;
+}

tests/Controller/AdminPages/DeviceControllerTest.php

@@ -0,0 +1,42 @@
+<?php
+/**
+ *
+ * part-db version 0.1
+ * Copyright (C) 2005 Christoph Lechner
+ * http://www.cl-projects.de/
+ *
+ * part-db version 0.2+
+ * Copyright (C) 2009 K. Jacobs and others (see authors.php)
+ * http://code.google.com/p/part-db/
+ *
+ * Part-DB Version 0.4+
+ * Copyright (C) 2016 - 2019 Jan Böhmer
+ * https://github.com/jbtronics
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ *
+ */
+
+namespace App\Tests\Controller\AdminPages;
+
+
+use App\Entity\Attachments\AttachmentType;
+use App\Entity\Devices\Device;
+
+class DeviceControllerTest extends AbstractAdminControllerTest
+{
+    protected static $base_path = '/en' . '/device';
+    protected static $entity_class = Device::class;
+}

tests/Controller/AdminPages/FootprintControllerTest.php

@@ -0,0 +1,42 @@
+<?php
+/**
+ *
+ * part-db version 0.1
+ * Copyright (C) 2005 Christoph Lechner
+ * http://www.cl-projects.de/
+ *
+ * part-db version 0.2+
+ * Copyright (C) 2009 K. Jacobs and others (see authors.php)
+ * http://code.google.com/p/part-db/
+ *
+ * Part-DB Version 0.4+
+ * Copyright (C) 2016 - 2019 Jan Böhmer
+ * https://github.com/jbtronics
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ *
+ */
+
+namespace App\Tests\Controller\AdminPages;
+
+
+use App\Entity\Attachments\AttachmentType;
+use App\Entity\Parts\Footprint;
+
+class FootprintControllerTest extends AbstractAdminControllerTest
+{
+    protected static $base_path = '/en' . '/footprint';
+    protected static $entity_class = Footprint::class;
+}

tests/Controller/AdminPages/ManufacturerControllerTest.php

@@ -0,0 +1,43 @@
+<?php
+/**
+ *
+ * part-db version 0.1
+ * Copyright (C) 2005 Christoph Lechner
+ * http://www.cl-projects.de/
+ *
+ * part-db version 0.2+
+ * Copyright (C) 2009 K. Jacobs and others (see authors.php)
+ * http://code.google.com/p/part-db/
+ *
+ * Part-DB Version 0.4+
+ * Copyright (C) 2016 - 2019 Jan Böhmer
+ * https://github.com/jbtronics
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ *
+ */
+
+namespace App\Tests\Controller\AdminPages;
+
+
+use App\Entity\Attachments\AttachmentType;
+use App\Entity\Devices\Device;
+use App\Entity\Parts\Manufacturer;
+
+class ManufacturerControllerTest extends AbstractAdminControllerTest
+{
+    protected static $base_path = '/en' . '/manufacturer';
+    protected static $entity_class = Manufacturer::class;
+}

tests/Controller/AdminPages/MeasurementUnitControllerTest.php

@@ -0,0 +1,44 @@
+<?php
+/**
+ *
+ * part-db version 0.1
+ * Copyright (C) 2005 Christoph Lechner
+ * http://www.cl-projects.de/
+ *
+ * part-db version 0.2+
+ * Copyright (C) 2009 K. Jacobs and others (see authors.php)
+ * http://code.google.com/p/part-db/
+ *
+ * Part-DB Version 0.4+
+ * Copyright (C) 2016 - 2019 Jan Böhmer
+ * https://github.com/jbtronics
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ *
+ */
+
+namespace App\Tests\Controller\AdminPages;
+
+
+use App\Entity\Attachments\AttachmentType;
+use App\Entity\Devices\Device;
+use App\Entity\Parts\Manufacturer;
+use App\Entity\Parts\MeasurementUnit;
+
+class MeasurementUnitControllerTest extends AbstractAdminControllerTest
+{
+    protected static $base_path = '/en' . '/measurement_unit';
+    protected static $entity_class = MeasurementUnit::class;
+}

tests/Controller/AdminPages/StorelocationControllerTest.php

@@ -0,0 +1,45 @@
+<?php
+/**
+ *
+ * part-db version 0.1
+ * Copyright (C) 2005 Christoph Lechner
+ * http://www.cl-projects.de/
+ *
+ * part-db version 0.2+
+ * Copyright (C) 2009 K. Jacobs and others (see authors.php)
+ * http://code.google.com/p/part-db/
+ *
+ * Part-DB Version 0.4+
+ * Copyright (C) 2016 - 2019 Jan Böhmer
+ * https://github.com/jbtronics
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ *
+ */
+
+namespace App\Tests\Controller\AdminPages;
+
+
+use App\Entity\Attachments\AttachmentType;
+use App\Entity\Devices\Device;
+use App\Entity\Parts\Manufacturer;
+use App\Entity\Parts\Storelocation;
+use Symfony\Component\HttpKernel\HttpCache\Store;
+
+class StorelocationControllerTest extends AbstractAdminControllerTest
+{
+    protected static $base_path = '/en' . '/store_location';
+    protected static $entity_class = Storelocation::class;
+}

tests/Controller/AdminPages/SupplierControllerTest.php

@@ -0,0 +1,44 @@
+<?php
+/**
+ *
+ * part-db version 0.1
+ * Copyright (C) 2005 Christoph Lechner
+ * http://www.cl-projects.de/
+ *
+ * part-db version 0.2+
+ * Copyright (C) 2009 K. Jacobs and others (see authors.php)
+ * http://code.google.com/p/part-db/
+ *
+ * Part-DB Version 0.4+
+ * Copyright (C) 2016 - 2019 Jan Böhmer
+ * https://github.com/jbtronics
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ *
+ */
+
+namespace App\Tests\Controller\AdminPages;
+
+
+use App\Entity\Attachments\AttachmentType;
+use App\Entity\Devices\Device;
+use App\Entity\Parts\Manufacturer;
+use App\Entity\Parts\Supplier;
+
+class SupplierControllerTest extends AbstractAdminControllerTest
+{
+    protected static $base_path = '/en' . '/supplier';
+    protected static $entity_class = Supplier::class;
+}

tests/Entity/PermissionsEmbedTest.php

@@ -34,6 +34,7 @@ namespace App\Tests\Entity;
 use App\Entity\UserSystem\PermissionsEmbed;
 use Doctrine\ORM\Mapping\Embedded;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Security\Http\RememberMe\PersistentTokenBasedRememberMeServices;
 
 class PermissionsEmbedTest extends TestCase
 {
@@ -181,6 +182,37 @@ class PermissionsEmbedTest extends TestCase
         //Check if it returns itself, for chaining.
         $this->assertEquals($embed, $embed->setPermissionValue(PermissionsEmbed::PARTS, 0, $value));
         $this->assertEquals($value, $embed->getPermissionValue(PermissionsEmbed::PARTS, 0));
+    }
+
+    public function testSetRawPermissionValue()
+    {
+        $embed = new PermissionsEmbed();
+        $embed->setRawPermissionValue(PermissionsEmbed::PARTS, 10);
+        $this->assertEquals(10, $embed->getRawPermissionValue(PermissionsEmbed::PARTS));
+    }
+
+    public function testSetRawPermissionValues()
+    {
+        $embed = new PermissionsEmbed();
+        $embed->setRawPermissionValues([
+            PermissionsEmbed::PARTS => 0,
+            PermissionsEmbed::USERS => 100,
+            PermissionsEmbed::CATEGORIES => 1304
+        ]);
+
+        $this->assertEquals(0, $embed->getRawPermissionValue(PermissionsEmbed::PARTS));
+        $this->assertEquals(100, $embed->getRawPermissionValue(PermissionsEmbed::USERS));
+        $this->assertEquals(1304, $embed->getRawPermissionValue(PermissionsEmbed::CATEGORIES));
+
+        //Test second method to pass perm names and values
+        $embed->setRawPermissionValues(
+            [PermissionsEmbed::PARTS, PermissionsEmbed::USERS, PermissionsEmbed::CATEGORIES],
+            [0, 100, 1304]
+        );
+
+        $this->assertEquals(0, $embed->getRawPermissionValue(PermissionsEmbed::PARTS));
+        $this->assertEquals(100, $embed->getRawPermissionValue(PermissionsEmbed::USERS));
+        $this->assertEquals(1304, $embed->getRawPermissionValue(PermissionsEmbed::CATEGORIES));
 
     }
 

tests/Services/PermissionResolverTest.php

@@ -47,6 +47,7 @@ class PermissionResolverTest extends WebTestCase
     protected $service;
 
     protected $user;
+    protected $user_withoutGroup;
     protected $group;
 
     public function setUp()
@@ -68,6 +69,10 @@ class PermissionResolverTest extends WebTestCase
         $this->user = $this->createMock(User::class);
         $this->user->method('getPermissions')->willReturn($user_embed);
 
+        $this->user_withoutGroup = $this->createMock(User::class);
+        $this->user_withoutGroup->method('getPermissions')->willReturn($user_embed);
+        $this->user_withoutGroup->method('getGroup')->willReturn(null);
+
         //Set up a faked group
         $group1_embed = new PermissionsEmbed();
         $group1_embed->setPermissionValue('parts', 6, true)
@@ -92,7 +97,6 @@ class PermissionResolverTest extends WebTestCase
         $parent_group->method('getPermissions')->willReturn($parent_group_embed);
 
         $this->group->method('getParent')->willReturn($parent_group);
-
     }
 
 
@@ -167,15 +171,22 @@ class PermissionResolverTest extends WebTestCase
         $this->assertNull($this->service->dontInherit($this->user, 'parts', 'create'));
         $this->assertNull($this->service->dontInherit($this->user, 'parts', 'show_history'));
         $this->assertNull($this->service->dontInherit($this->user, 'parts', 'delete'));
+
+        //Test for user without group
+        $this->assertTrue($this->service->dontInherit($this->user_withoutGroup, 'parts', 'read'));
+        $this->assertFalse($this->service->dontInherit($this->user_withoutGroup, 'parts', 'edit'));
+        $this->assertNull($this->service->dontInherit($this->user_withoutGroup, 'parts', 'create'));
+        $this->assertNull($this->service->dontInherit($this->user_withoutGroup, 'parts', 'show_history'));
+        $this->assertNull($this->service->dontInherit($this->user_withoutGroup, 'parts', 'delete'));
     }
 
     public function testInherit()
     {
         //Not inherited values should be same as dont inherit:
-        $this->assertTrue($this->service->Inherit($this->user, 'parts', 'read'));
-        $this->assertFalse($this->service->Inherit($this->user, 'parts', 'edit'));
+        $this->assertTrue($this->service->inherit($this->user, 'parts', 'read'));
+        $this->assertFalse($this->service->inherit($this->user, 'parts', 'edit'));
         //When thing can not be resolved null should be returned
-        $this->assertNull($this->service->Inherit($this->user, 'parts', 'create'));
+        $this->assertNull($this->service->inherit($this->user, 'parts', 'create'));
 
         //Check for inherit from group
         $this->assertTrue($this->service->inherit($this->user, 'parts', 'show_history'));
@@ -186,6 +197,13 @@ class PermissionResolverTest extends WebTestCase
         $this->assertTrue($this->service->inherit($this->user, 'parts', 'all_parts'));
         $this->assertFalse($this->service->inherit($this->user, 'parts', 'no_price_parts'));
         $this->assertNull($this->service->inherit($this->user, 'parts', 'obsolete_parts'));
+
+        //Test for user without group
+        $this->assertTrue($this->service->inherit($this->user_withoutGroup, 'parts', 'read'));
+        $this->assertFalse($this->service->inherit($this->user_withoutGroup, 'parts', 'edit'));
+        $this->assertNull($this->service->inherit($this->user_withoutGroup, 'parts', 'create'));
+        $this->assertNull($this->service->inherit($this->user_withoutGroup, 'parts', 'show_history'));
+        $this->assertNull($this->service->inherit($this->user_withoutGroup, 'parts', 'delete'));
     }
 
 }