diff --git a/tests/ApplicationAvailabilityFunctionalTest.php b/tests/ApplicationAvailabilityFunctionalTest.php index 0d94a9e0..4825cf27 100644 --- a/tests/ApplicationAvailabilityFunctionalTest.php +++ b/tests/ApplicationAvailabilityFunctionalTest.php @@ -42,7 +42,6 @@ declare(strict_types=1); namespace App\Tests; -use App\Entity\Parts\Manufacturer; use Symfony\Bundle\FrameworkBundle\Test\WebTestCase; /** diff --git a/tests/DatatablesAvailabilityTest.php b/tests/DatatablesAvailabilityTest.php index 4093c616..2ef73de1 100644 --- a/tests/DatatablesAvailabilityTest.php +++ b/tests/DatatablesAvailabilityTest.php @@ -1,4 +1,7 @@ expectException(\InvalidArgumentException::class); @@ -88,7 +90,7 @@ class AbstractLogEntryTest extends TestCase /** * @dataProvider levelDataProvider */ - public function testLevelStringToInt(int $expected_int, string $string, bool $expect_exception = false) + public function testLevelStringToInt(int $expected_int, string $string, bool $expect_exception = false): void { if ($expect_exception) { $this->expectException(\InvalidArgumentException::class); @@ -99,7 +101,7 @@ class AbstractLogEntryTest extends TestCase /** * @dataProvider targetTypeDataProvider */ - public function testTargetTypeIdToClass(int $int, string $expected_class, bool $expect_exception = false) + public function testTargetTypeIdToClass(int $int, string $expected_class, bool $expect_exception = false): void { if ($expect_exception) { $this->expectException(\InvalidArgumentException::class); @@ -110,7 +112,7 @@ class AbstractLogEntryTest extends TestCase /** * @dataProvider targetTypeDataProvider */ - public function testTypeClassToID(int $expected_id, string $class, bool $expect_exception = false) + public function testTypeClassToID(int $expected_id, string $class, bool $expect_exception = false): void { if ($expect_exception) { $this->expectException(\InvalidArgumentException::class); @@ -118,18 +120,19 @@ class AbstractLogEntryTest extends TestCase $this->assertSame($expected_id, AbstractLogEntry::targetTypeClassToID($class)); } - public function testTypeClassToIDSubclasses() + public function testTypeClassToIDSubclasses(): void { //Test if class mapping works for subclasses $this->assertSame(2, AbstractLogEntry::targetTypeClassToID(PartAttachment::class)); } - public function testSetGetTarget() + public function testSetGetTarget(): void { $part = $this->createMock(Part::class); $part->method('getID')->willReturn(10); - $log = new class extends AbstractLogEntry {}; + $log = new class() extends AbstractLogEntry { + }; $log->setTargetElement($part); $this->assertSame(Part::class, $log->getTargetClass()); diff --git a/tests/Entity/Parameters/PartParameterTest.php b/tests/Entity/Parameters/PartParameterTest.php index 1d04b1b0..ee90a761 100644 --- a/tests/Entity/Parameters/PartParameterTest.php +++ b/tests/Entity/Parameters/PartParameterTest.php @@ -1,4 +1,7 @@ service = self::$container->get(EventCommentHelper::class); } - public function testInitialState() + public function testInitialState(): void { $this->assertNull($this->service->getMessage()); $this->assertFalse($this->service->isMessageSet()); } - public function testClearMessage() + public function testClearMessage(): void { $this->service->setMessage('Test'); $this->assertTrue($this->service->isMessageSet()); @@ -55,13 +56,13 @@ class EventCommentHelperTest extends WebTestCase $this->assertFalse($this->service->isMessageSet()); } - public function testGetSetMessage() + public function testGetSetMessage(): void { $this->service->setMessage('Test'); $this->assertSame('Test', $this->service->getMessage()); } - public function testIsMessageSet() + public function testIsMessageSet(): void { $this->service->setMessage('Test'); $this->assertTrue($this->service->isMessageSet()); diff --git a/tests/Services/LogSystem/EventLoggerTest.php b/tests/Services/LogSystem/EventLoggerTest.php index a6fa0884..6d87b505 100644 --- a/tests/Services/LogSystem/EventLoggerTest.php +++ b/tests/Services/LogSystem/EventLoggerTest.php @@ -1,4 +1,7 @@ service = self::$container->get(EventLogger::class); } - public function testShouldBeAdded() + public function testShouldBeAdded(): void { $event1 = new UserLoginLogEntry('127.0.0.1'); $event2 = new UserLogoutLogEntry('127.0.0.1'); $event2->setLevel(AbstractLogEntry::LEVEL_CRITICAL); - //Test without restrictions $this->assertTrue($this->service->shouldBeAdded($event1, 7, [], []));