Fixed code style.

This commit is contained in:
Jan Böhmer 2020-08-21 21:36:22 +02:00
parent 2853e471c4
commit d0b1024d80
212 changed files with 495 additions and 1005 deletions

View file

@ -71,7 +71,7 @@ class AttachmentTypeAdminForm extends BaseEntityAdminForm
'placeholder' => 'attachment_type.edit.filetype_filter.placeholder',
],
'empty_data' => '',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
//Normalize data before writing it to database

View file

@ -90,7 +90,7 @@ class BaseEntityAdminForm extends AbstractType
'attr' => [
'placeholder' => 'part.name.placeholder',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
if ($entity instanceof AbstractStructuralDBElement) {
@ -101,7 +101,7 @@ class BaseEntityAdminForm extends AbstractType
'class' => get_class($entity),
'required' => false,
'label' => 'parent.label',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'move', $entity),
]
)
->add(
@ -114,7 +114,7 @@ class BaseEntityAdminForm extends AbstractType
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]
);
}
@ -130,7 +130,7 @@ class BaseEntityAdminForm extends AbstractType
'rows' => 4,
],
'help' => 'bbcode.hint',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]
);
}
@ -144,7 +144,7 @@ class BaseEntityAdminForm extends AbstractType
'allow_delete' => true,
'label' => false,
'reindex_enable' => true,
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'entry_options' => [
'data_class' => $options['attachment_class'],
],
@ -153,7 +153,7 @@ class BaseEntityAdminForm extends AbstractType
$builder->add('master_picture_attachment', MasterPictureAttachmentType::class, [
'required' => false,
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'label' => 'part.edit.master_attachment',
'entity' => $entity,
]);
@ -173,7 +173,7 @@ class BaseEntityAdminForm extends AbstractType
'entry_type' => ParameterType::class,
'allow_add' => $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'allow_delete' => $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'reindex_enable' => true,
'label' => false,
'by_reference' => false,
@ -191,11 +191,11 @@ class BaseEntityAdminForm extends AbstractType
'attr' => [
'class' => $is_new ? 'btn-success' : '',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
])
->add('reset', ResetType::class, [
'label' => 'entity.edit.reset',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
}

View file

@ -60,7 +60,7 @@ class CategoryAdminForm extends BaseEntityAdminForm
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('disable_manufacturers', CheckboxType::class, [
@ -70,7 +70,7 @@ class CategoryAdminForm extends BaseEntityAdminForm
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('disable_autodatasheets', CheckboxType::class, [
@ -80,7 +80,7 @@ class CategoryAdminForm extends BaseEntityAdminForm
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('disable_properties', CheckboxType::class, [
@ -90,7 +90,7 @@ class CategoryAdminForm extends BaseEntityAdminForm
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('partname_hint', TextType::class, [
@ -100,7 +100,7 @@ class CategoryAdminForm extends BaseEntityAdminForm
'attr' => [
'placeholder' => 'category.edit.partname_hint.placeholder',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('partname_regex', TextType::class, [
@ -110,7 +110,7 @@ class CategoryAdminForm extends BaseEntityAdminForm
'attr' => [
'placeholder' => 'category.edit.partname_regex.placeholder',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('default_description', TextType::class, [
@ -120,7 +120,7 @@ class CategoryAdminForm extends BaseEntityAdminForm
'attr' => [
'placeholder' => 'category.edit.default_description.placeholder',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('default_comment', TextType::class, [
@ -130,7 +130,7 @@ class CategoryAdminForm extends BaseEntityAdminForm
'attr' => [
'placeholder' => 'category.edit.default_comment.placeholder',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
}
}

View file

@ -57,7 +57,7 @@ class CompanyForm extends BaseEntityAdminForm
$builder->add('address', TextareaType::class, [
'label' => 'company.edit.address',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'attr' => [
'placeholder' => 'company.edit.address.placeholder',
],
@ -67,7 +67,7 @@ class CompanyForm extends BaseEntityAdminForm
$builder->add('phone_number', TelType::class, [
'label' => 'company.edit.phone_number',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'attr' => [
'placeholder' => 'company.edit.phone_number.placeholder',
],
@ -77,7 +77,7 @@ class CompanyForm extends BaseEntityAdminForm
$builder->add('fax_number', TelType::class, [
'label' => 'company.edit.fax_number',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'attr' => [
'placeholder' => 'company.fax_number.placeholder',
],
@ -87,7 +87,7 @@ class CompanyForm extends BaseEntityAdminForm
$builder->add('email_address', EmailType::class, [
'label' => 'company.edit.email',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'attr' => [
'placeholder' => 'company.edit.email.placeholder',
],
@ -97,7 +97,7 @@ class CompanyForm extends BaseEntityAdminForm
$builder->add('website', UrlType::class, [
'label' => 'company.edit.website',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'attr' => [
'placeholder' => 'company.edit.website.placeholder',
],
@ -108,7 +108,7 @@ class CompanyForm extends BaseEntityAdminForm
$builder->add('auto_product_url', UrlType::class, [
'label' => 'company.edit.auto_product_url',
'help' => 'company.edit.auto_product_url.help',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'attr' => [
'placeholder' => 'company.edit.auto_product_url.placeholder',
],

View file

@ -45,7 +45,6 @@ namespace App\Form\AdminPages;
use App\Entity\Base\AbstractNamedDBElement;
use App\Form\Type\BigDecimalMoneyType;
use Symfony\Component\Form\Extension\Core\Type\CurrencyType;
use Symfony\Component\Form\Extension\Core\Type\MoneyType;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Security\Core\Security;
@ -73,7 +72,7 @@ class CurrencyAdminForm extends BaseEntityAdminForm
'title' => 'selectpicker.nothing_selected',
'data-live-search' => true,
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('exchange_rate', BigDecimalMoneyType::class, [
@ -81,16 +80,16 @@ class CurrencyAdminForm extends BaseEntityAdminForm
'label' => 'currency.edit.exchange_rate',
'currency' => $this->default_currency,
'scale' => 6,
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
if(!$is_new) {
if (!$is_new) {
$builder->add(
'update_exchange_rate',
SubmitType::class,
[
'label' => 'currency.edit.update_rate',
'disabled' => ! $this->security->isGranted('edit', $entity)
'disabled' => !$this->security->isGranted('edit', $entity),
]
);
}

View file

@ -52,7 +52,7 @@ class FootprintAdminForm extends BaseEntityAdminForm
{
$builder->add('footprint_3d', MasterPictureAttachmentType::class, [
'required' => false,
'disabled' => ! $this->security->isGranted(null === $entity->getID() ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted(null === $entity->getID() ? 'create' : 'edit', $entity),
'label' => 'footprint.edit.3d_model',
'filter' => '3d_model',
'entity' => $entity,

View file

@ -60,13 +60,13 @@ class GroupAdminForm extends BaseEntityAdminForm
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('permissions', PermissionsType::class, [
'mapped' => false,
'data' => $builder->getData(),
'disabled' => ! $this->security->isGranted('edit_permissions', $entity),
'disabled' => !$this->security->isGranted('edit_permissions', $entity),
]);
}
}

View file

@ -69,7 +69,7 @@ class ImportType extends AbstractType
//Disable import if user is not allowed to create elements.
$entity = new $data['entity_class']();
$perm_name = 'create';
$disabled = ! $this->security->isGranted($perm_name, $entity);
$disabled = !$this->security->isGranted($perm_name, $entity);
$builder

View file

@ -66,7 +66,7 @@ class MassCreationForm extends AbstractType
//Disable import if user is not allowed to create elements.
$entity = new $data['entity_class']();
$perm_name = 'create';
$disabled = ! $this->security->isGranted($perm_name, $entity);
$disabled = !$this->security->isGranted($perm_name, $entity);
$builder
->add('lines', TextareaType::class, [

View file

@ -60,7 +60,7 @@ class MeasurementUnitAdminForm extends BaseEntityAdminForm
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('use_si_prefix', CheckboxType::class, [
@ -70,7 +70,7 @@ class MeasurementUnitAdminForm extends BaseEntityAdminForm
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('unit', TextType::class, [
@ -79,7 +79,7 @@ class MeasurementUnitAdminForm extends BaseEntityAdminForm
'attr' => [
'placeholder' => 'measurement_unit.edit.unit_symbol.placeholder',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
}
}

View file

@ -61,7 +61,7 @@ class StorelocationAdminForm extends BaseEntityAdminForm
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'move', $entity),
]);
$builder->add('limit_to_existing_parts', CheckboxType::class, [
@ -71,7 +71,7 @@ class StorelocationAdminForm extends BaseEntityAdminForm
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'move', $entity),
]);
$builder->add('only_single_part', CheckboxType::class, [
@ -81,7 +81,7 @@ class StorelocationAdminForm extends BaseEntityAdminForm
'label_attr' => [
'class' => 'checkbox-custom',
],
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'move', $entity),
]);
$builder->add('storage_type', StructuralEntityType::class, [
@ -90,7 +90,7 @@ class StorelocationAdminForm extends BaseEntityAdminForm
'help' => 'storelocation.storage_type.help',
'class' => MeasurementUnit::class,
'disable_not_selectable' => true,
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'move', $entity),
]);
}
}

View file

@ -46,7 +46,6 @@ use App\Entity\Base\AbstractNamedDBElement;
use App\Entity\PriceInformations\Currency;
use App\Form\Type\BigDecimalMoneyType;
use App\Form\Type\StructuralEntityType;
use Symfony\Component\Form\Extension\Core\Type\MoneyType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Security\Core\Security;
@ -71,7 +70,7 @@ class SupplierForm extends CompanyForm
'required' => false,
'label' => 'supplier.edit.default_currency',
'disable_not_selectable' => true,
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'move', $entity),
]);
$builder->add('shipping_costs', BigDecimalMoneyType::class, [
@ -79,7 +78,7 @@ class SupplierForm extends CompanyForm
'currency' => $this->default_currency,
'scale' => 3,
'label' => 'supplier.shipping_costs.label',
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'move', $entity),
]);
}
}

View file

@ -115,7 +115,7 @@ class AttachmentFormType extends AbstractType
'required' => false,
'label' => 'attachment.edit.secure_file',
'mapped' => false,
'disabled' => ! $this->security->isGranted('@parts_attachments.show_private'),
'disabled' => !$this->security->isGranted('@parts_attachments.show_private'),
'attr' => [
'class' => 'form-control-sm',
],
@ -143,7 +143,7 @@ class AttachmentFormType extends AbstractType
'required' => false,
'label' => 'attachment.edit.download_url',
'mapped' => false,
'disabled' => ! $this->allow_attachments_download,
'disabled' => !$this->allow_attachments_download,
'attr' => [
'class' => 'form-control-sm',
],
@ -179,7 +179,7 @@ class AttachmentFormType extends AbstractType
if ($attachment instanceof Attachment && $file instanceof UploadedFile && $attachment->getAttachmentType()) {
if (!$this->submitHandler->isValidFileExtension($attachment->getAttachmentType(), $file)) {
$event->getForm()->get('file')->addError(
new FormError($this->translator->trans("validator.file_ext_not_allowed"))
new FormError($this->translator->trans('validator.file_ext_not_allowed'))
);
}
}

View file

@ -133,7 +133,7 @@ class LabelOptionsType extends AbstractType
'label_attr' => [
'class' => 'radio-custom radio-inline',
],
'disabled' => ! $this->security->isGranted('@labels.use_twig'),
'disabled' => !$this->security->isGranted('@labels.use_twig'),
]);
}

View file

@ -54,7 +54,7 @@ class LabelDialogType extends AbstractType
$builder->add('options', LabelOptionsType::class, [
'label' => false,
'disabled' => ! $this->security->isGranted('@labels.edit_options') || $options['disable_options'],
'disabled' => !$this->security->isGranted('@labels.edit_options') || $options['disable_options'],
]);
$builder->add('update', SubmitType::class, [
'label' => 'label_generator.update',

View file

@ -50,7 +50,6 @@ use App\Form\Type\StructuralEntityType;
use App\Form\WorkaroundCollectionType;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
use Symfony\Component\Form\Extension\Core\Type\CollectionType;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\Extension\Core\Type\UrlType;
use Symfony\Component\Form\FormBuilderInterface;
@ -119,7 +118,7 @@ class OrderdetailType extends AbstractType
'prototype_data' => $dummy_pricedetail,
'by_reference' => false,
'entry_options' => [
'disabled' => ! $this->security->isGranted('@parts_prices.edit'),
'disabled' => !$this->security->isGranted('@parts_prices.edit'),
'measurement_unit' => $options['measurement_unit'],
],
]);

View file

@ -105,7 +105,7 @@ class PartBaseType extends AbstractType
'attr' => [
'placeholder' => 'part.edit.name.placeholder',
],
'disabled' => ! $this->security->isGranted('name.edit', $part),
'disabled' => !$this->security->isGranted('name.edit', $part),
])
->add('description', CKEditorType::class, [
'required' => false,
@ -116,7 +116,7 @@ class PartBaseType extends AbstractType
'placeholder' => 'part.edit.description.placeholder',
'rows' => 2,
],
'disabled' => ! $this->security->isGranted('description.edit', $part),
'disabled' => !$this->security->isGranted('description.edit', $part),
])
->add('minAmount', SIUnitType::class, [
'attr' => [
@ -125,23 +125,22 @@ class PartBaseType extends AbstractType
],
'label' => 'part.edit.mininstock',
'measurement_unit' => $part->getPartUnit(),
'disabled' => ! $this->security->isGranted('minamount.edit', $part),
'disabled' => !$this->security->isGranted('minamount.edit', $part),
])
->add('category', StructuralEntityType::class, [
'class' => Category::class,
'label' => 'part.edit.category',
'disable_not_selectable' => true,
'disabled' => ! $this->security->isGranted('category.edit', $part),
'disabled' => !$this->security->isGranted('category.edit', $part),
'constraints' => [
]
],
])
->add('footprint', StructuralEntityType::class, [
'class' => Footprint::class,
'required' => false,
'label' => 'part.edit.footprint',
'disable_not_selectable' => true,
'disabled' => ! $this->security->isGranted('footprint.edit', $part),
'disabled' => !$this->security->isGranted('footprint.edit', $part),
])
->add('tags', TextType::class, [
'required' => false,
@ -151,7 +150,7 @@ class PartBaseType extends AbstractType
'class' => 'tagsinput',
'data-autocomplete' => $this->urlGenerator->generate('typeahead_tags', ['query' => 'QUERY']),
],
'disabled' => ! $this->security->isGranted('tags.edit', $part),
'disabled' => !$this->security->isGranted('tags.edit', $part),
]);
//Manufacturer section
@ -160,25 +159,25 @@ class PartBaseType extends AbstractType
'required' => false,
'label' => 'part.edit.manufacturer.label',
'disable_not_selectable' => true,
'disabled' => ! $this->security->isGranted('manufacturer.edit', $part),
'disabled' => !$this->security->isGranted('manufacturer.edit', $part),
])
->add('manufacturer_product_url', UrlType::class, [
'required' => false,
'empty_data' => '',
'label' => 'part.edit.manufacturer_url.label',
'disabled' => ! $this->security->isGranted('mpn.edit', $part),
'disabled' => !$this->security->isGranted('mpn.edit', $part),
])
->add('manufacturer_product_number', TextType::class, [
'required' => false,
'empty_data' => '',
'label' => 'part.edit.mpn',
'disabled' => ! $this->security->isGranted('mpn.edit', $part),
'disabled' => !$this->security->isGranted('mpn.edit', $part),
])
->add('manufacturing_status', ChoiceType::class, [
'label' => 'part.edit.manufacturing_status',
'choices' => $status_choices,
'required' => false,
'disabled' => ! $this->security->isGranted('status.edit', $part),
'disabled' => !$this->security->isGranted('status.edit', $part),
]);
//Advanced section
@ -188,7 +187,7 @@ class PartBaseType extends AbstractType
],
'required' => false,
'label' => 'part.edit.needs_review',
'disabled' => ! $this->security->isGranted('edit', $part),
'disabled' => !$this->security->isGranted('edit', $part),
])
->add('favorite', CheckboxType::class, [
'label_attr' => [
@ -196,20 +195,20 @@ class PartBaseType extends AbstractType
],
'required' => false,
'label' => 'part.edit.is_favorite',
'disabled' => ! $this->security->isGranted('change_favorite', $part),
'disabled' => !$this->security->isGranted('change_favorite', $part),
])
->add('mass', SIUnitType::class, [
'unit' => 'g',
'label' => 'part.edit.mass',
'required' => false,
'disabled' => ! $this->security->isGranted('mass.edit', $part),
'disabled' => !$this->security->isGranted('mass.edit', $part),
])
->add('partUnit', StructuralEntityType::class, [
'class' => MeasurementUnit::class,
'required' => false,
'disable_not_selectable' => true,
'label' => 'part.edit.partUnit',
'disabled' => ! $this->security->isGranted('unit.edit', $part),
'disabled' => !$this->security->isGranted('unit.edit', $part),
]);
//Comment section
@ -219,7 +218,7 @@ class PartBaseType extends AbstractType
'attr' => [
'rows' => 4,
],
'disabled' => ! $this->security->isGranted('comment.edit', $part),
'disabled' => !$this->security->isGranted('comment.edit', $part),
'empty_data' => '',
]);
@ -232,7 +231,7 @@ class PartBaseType extends AbstractType
'label' => false,
'entry_options' => [
'measurement_unit' => $part->getPartUnit(),
'disabled' => ! $this->security->isGranted('lots.edit', $part),
'disabled' => !$this->security->isGranted('lots.edit', $part),
],
'by_reference' => false,
]);
@ -246,14 +245,14 @@ class PartBaseType extends AbstractType
'label' => false,
'entry_options' => [
'data_class' => PartAttachment::class,
'disabled' => ! $this->security->isGranted('attachments.edit', $part),
'disabled' => !$this->security->isGranted('attachments.edit', $part),
],
'by_reference' => false,
]);
$builder->add('master_picture_attachment', MasterPictureAttachmentType::class, [
'required' => false,
'disabled' => ! $this->security->isGranted('attachments.edit', $part),
'disabled' => !$this->security->isGranted('attachments.edit', $part),
'label' => 'part.edit.master_attachment',
'entity' => $part,
]);
@ -269,7 +268,7 @@ class PartBaseType extends AbstractType
'prototype_data' => new Orderdetail(),
'entry_options' => [
'measurement_unit' => $part->getPartUnit(),
'disabled' => ! $this->security->isGranted('orderdetails.edit', $part),
'disabled' => !$this->security->isGranted('orderdetails.edit', $part),
],
]);
@ -282,7 +281,7 @@ class PartBaseType extends AbstractType
'by_reference' => false,
'prototype_data' => new PartParameter(),
'entry_options' => [
'disabled' => ! $this->security->isGranted('parameters.edit', $part),
'disabled' => !$this->security->isGranted('parameters.edit', $part),
'data_class' => PartParameter::class,
],
]);
@ -298,7 +297,7 @@ class PartBaseType extends AbstractType
//Buttons
->add('save', SubmitType::class, ['label' => 'part.edit.save'])
->add('save_and_clone', SubmitType::class, [
'label' => 'part.edit.save_and_clone'
'label' => 'part.edit.save_and_clone',
])
->add('reset', ResetType::class, ['label' => 'part.edit.reset']);
}

View file

@ -44,7 +44,6 @@ namespace App\Form\Part;
use App\Entity\Parts\MeasurementUnit;
use App\Entity\PriceInformations\Pricedetail;
use App\Form\Type\BigDecimalMoneyType;
use App\Form\Type\BigDecimalNumberType;
use App\Form\Type\CurrencyEntityType;
use App\Form\Type\SIUnitType;

View file

@ -98,7 +98,7 @@ class PermissionGroupType extends AbstractType
$resolver->setDefault('inherit', false);
$resolver->setDefault('label', function (Options $options) {
if (! empty($this->perm_structure['groups'][$options['group_name']]['label'])) {
if (!empty($this->perm_structure['groups'][$options['group_name']]['label'])) {
return $this->perm_structure['groups'][$options['group_name']]['label'];
}

View file

@ -71,7 +71,7 @@ class PermissionType extends AbstractType
});
$resolver->setDefault('label', function (Options $options) {
if (! empty($this->perm_structure['perms'][$options['perm_name']]['label'])) {
if (!empty($this->perm_structure['perms'][$options['perm_name']]['label'])) {
return $this->perm_structure['perms'][$options['perm_name']]['label'];
}
@ -79,7 +79,7 @@ class PermissionType extends AbstractType
});
$resolver->setDefault('multi_checkbox', function (Options $options) {
return ! $options['disabled'];
return !$options['disabled'];
});
$resolver->setDefaults([

View file

@ -67,7 +67,7 @@ class PermissionsType extends AbstractType
$resolver->setDefaults([
'show_legend' => true,
'constraints' => function (Options $options) {
if (! $options['disabled']) {
if (!$options['disabled']) {
return [new NoLockout()];
}

View file

@ -70,7 +70,7 @@ class TFAGoogleSettingsType extends AbstractType
$user = $event->getData();
//Only show setup fields, when google authenticator is not enabled
if (! $user->isGoogleAuthenticatorEnabled()) {
if (!$user->isGoogleAuthenticatorEnabled()) {
$form->add(
'google_confirmation',
TextType::class,

View file

@ -20,12 +20,9 @@
namespace App\Form\Type;
use Brick\Math\BigDecimal;
use Brick\Math\BigNumber;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\DataTransformerInterface;
use Symfony\Component\Form\Exception\TransformationFailedException;
use Symfony\Component\Form\Extension\Core\Type\MoneyType;
use Symfony\Component\Form\FormBuilderInterface;
@ -43,7 +40,7 @@ class BigDecimalMoneyType extends AbstractType implements DataTransformerInterfa
public function transform($value)
{
if ($value === null) {
if (null === $value) {
return null;
}
@ -56,10 +53,10 @@ class BigDecimalMoneyType extends AbstractType implements DataTransformerInterfa
public function reverseTransform($value)
{
if ($value === null) {
if (null === $value) {
return null;
}
return BigDecimal::of($value);
}
}
}

View file

@ -20,7 +20,6 @@
namespace App\Form\Type;
use Brick\Math\BigDecimal;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\DataTransformerInterface;
@ -41,7 +40,7 @@ class BigDecimalNumberType extends AbstractType implements DataTransformerInterf
public function transform($value)
{
if ($value === null) {
if (null === $value) {
return null;
}
@ -54,10 +53,10 @@ class BigDecimalNumberType extends AbstractType implements DataTransformerInterf
public function reverseTransform($value)
{
if ($value === null) {
if (null === $value) {
return null;
}
return BigDecimal::of($value);
}
}
}

View file

@ -88,7 +88,7 @@ class CurrencyEntityType extends StructuralEntityType
{
//Similar to StructuralEntityType, but we use the currency symbol instead if available
if (! $choice instanceof Currency) {
if (!$choice instanceof Currency) {
throw new \InvalidArgumentException('$choice must be an currency object!');
}
@ -117,7 +117,7 @@ class CurrencyEntityType extends StructuralEntityType
/** @var Currency $choice */
$tmp = [];
if (! empty($choice->getIsoCode())) {
if (!empty($choice->getIsoCode())) {
//Show the name of the currency
$tmp += ['data-subtext' => $choice->getName()];
}

View file

@ -70,9 +70,9 @@ class MasterPictureAttachmentType extends AbstractType
/** @var Attachment $choice */
$tmp = ['data-subtext' => $choice->getFilename() ?? 'URL'];
if ('picture' === $options['filter'] && ! $choice->isPicture()) {
if ('picture' === $options['filter'] && !$choice->isPicture()) {
$tmp += ['disabled' => 'disabled'];
} elseif ('3d_model' === $options['filter'] && ! $choice->is3DModel()) {
} elseif ('3d_model' === $options['filter'] && !$choice->is3DModel()) {
$tmp += ['disabled' => 'disabled'];
}
@ -83,7 +83,7 @@ class MasterPictureAttachmentType extends AbstractType
'choice_loader' => function (Options $options) {
return new CallbackChoiceLoader(function () use ($options) {
$entity = $options['entity'];
if (! $entity instanceof AttachmentContainingDBElement) {
if (!$entity instanceof AttachmentContainingDBElement) {
throw new \RuntimeException('$entity must have Attachments! (be of type AttachmentContainingDBElement)');
}

View file

@ -134,8 +134,6 @@ class StructuralEntityType extends AbstractType
/**
* Gets the entries from database and return an array of them.
*
* @return array
*/
public function getEntries(Options $options): array
{

View file

@ -95,7 +95,7 @@ class UserAdminForm extends AbstractType
'attr' => [
'placeholder' => 'user.username.placeholder',
],
'disabled' => ! $this->security->isGranted('edit_username', $entity),
'disabled' => !$this->security->isGranted('edit_username', $entity),
])
->add('group', StructuralEntityType::class, [
@ -103,7 +103,7 @@ class UserAdminForm extends AbstractType
'required' => false,
'label' => 'group.label',
'disable_not_selectable' => true,
'disabled' => ! $this->security->isGranted('change_group', $entity),
'disabled' => !$this->security->isGranted('change_group', $entity),
])
->add('first_name', TextType::class, [
@ -113,7 +113,7 @@ class UserAdminForm extends AbstractType
'placeholder' => 'user.firstName.placeholder',
],
'required' => false,
'disabled' => ! $this->security->isGranted('edit_infos', $entity),
'disabled' => !$this->security->isGranted('edit_infos', $entity),
])
->add('last_name', TextType::class, [
@ -123,7 +123,7 @@ class UserAdminForm extends AbstractType
'placeholder' => 'user.lastName.placeholder',
],
'required' => false,
'disabled' => ! $this->security->isGranted('edit_infos', $entity),
'disabled' => !$this->security->isGranted('edit_infos', $entity),
])
->add('email', TextType::class, [
@ -133,7 +133,7 @@ class UserAdminForm extends AbstractType
'placeholder' => 'user.email.placeholder',
],
'required' => false,
'disabled' => ! $this->security->isGranted('edit_infos', $entity),
'disabled' => !$this->security->isGranted('edit_infos', $entity),
])
->add('department', TextType::class, [
@ -143,7 +143,7 @@ class UserAdminForm extends AbstractType
'placeholder' => 'user.department.placeholder',
],
'required' => false,
'disabled' => ! $this->security->isGranted('edit_infos', $entity),
'disabled' => !$this->security->isGranted('edit_infos', $entity),
])
//Config section
@ -157,7 +157,7 @@ class UserAdminForm extends AbstractType
'placeholder' => 'user_settings.language.placeholder',
'label' => 'user.language_select',
'preferred_choices' => ['en', 'de'],
'disabled' => ! $this->security->isGranted('change_user_settings', $entity),
'disabled' => !$this->security->isGranted('change_user_settings', $entity),
])
->add('timezone', TimezoneType::class, [
'required' => false,
@ -169,7 +169,7 @@ class UserAdminForm extends AbstractType
'placeholder' => 'user_settings.timezone.placeholder',
'label' => 'user.timezone.label',
'preferred_choices' => ['Europe/Berlin'],
'disabled' => ! $this->security->isGranted('change_user_settings', $entity),
'disabled' => !$this->security->isGranted('change_user_settings', $entity),
])
->add('theme', ChoiceType::class, [
'required' => false,
@ -184,12 +184,12 @@ class UserAdminForm extends AbstractType
'choice_translation_domain' => false,
'placeholder' => 'user_settings.theme.placeholder',
'label' => 'user.theme.label',
'disabled' => ! $this->security->isGranted('change_user_settings', $entity),
'disabled' => !$this->security->isGranted('change_user_settings', $entity),
])
->add('currency', CurrencyEntityType::class, [
'required' => false,
'label' => 'user.currency.label',
'disabled' => ! $this->security->isGranted('change_user_settings', $entity),
'disabled' => !$this->security->isGranted('change_user_settings', $entity),
])
->add('new_password', RepeatedType::class, [
@ -203,7 +203,7 @@ class UserAdminForm extends AbstractType
'invalid_message' => 'password_must_match',
'required' => false,
'mapped' => false,
'disabled' => ! $this->security->isGranted('set_password', $entity),
'disabled' => !$this->security->isGranted('set_password', $entity),
'constraints' => [new Length([
'min' => 6,
'max' => 128,
@ -216,7 +216,7 @@ class UserAdminForm extends AbstractType
'class' => 'checkbox-custom',
],
'label' => 'user.edit.needs_pw_change',
'disabled' => ! $this->security->isGranted('set_password', $entity),
'disabled' => !$this->security->isGranted('set_password', $entity),
])
->add('disabled', CheckboxType::class, [
@ -225,7 +225,7 @@ class UserAdminForm extends AbstractType
'class' => 'checkbox-custom',
],
'label' => 'user.edit.user_disabled',
'disabled' => ! $this->security->isGranted('set_password', $entity)
'disabled' => !$this->security->isGranted('set_password', $entity)
|| $entity === $this->security->getUser(),
])
@ -233,7 +233,7 @@ class UserAdminForm extends AbstractType
->add('permissions', PermissionsType::class, [
'mapped' => false,
'data' => $builder->getData(),
'disabled' => ! $this->security->isGranted('edit_permissions', $entity),
'disabled' => !$this->security->isGranted('edit_permissions', $entity),
])
;
/*->add('comment', CKEditorType::class, ['required' => false,
@ -253,7 +253,7 @@ class UserAdminForm extends AbstractType
'data_class' => $options['attachment_class'],
],
'by_reference' => false,
'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
'disabled' => !$this->security->isGranted($is_new ? 'create' : 'edit', $entity),
]);
$builder->add('log_comment', TextType::class, [

View file

@ -72,27 +72,27 @@ class UserSettingsType extends AbstractType
$builder
->add('name', TextType::class, [
'label' => 'user.username.label',
'disabled' => ! $this->security->isGranted('edit_username', $options['data']) || $this->demo_mode,
'disabled' => !$this->security->isGranted('edit_username', $options['data']) || $this->demo_mode,
])
->add('first_name', TextType::class, [
'required' => false,
'label' => 'user.firstName.label',
'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
])
->add('last_name', TextType::class, [
'required' => false,
'label' => 'user.lastName.label',
'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
])
->add('department', TextType::class, [
'required' => false,
'label' => 'user.department.label',
'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
])
->add('email', EmailType::class, [
'required' => false,
'label' => 'user.email.label',
'disabled' => ! $this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
'disabled' => !$this->security->isGranted('edit_infos', $options['data']) || $this->demo_mode,
])
->add('language', LanguageType::class, [
'disabled' => $this->demo_mode,

View file

@ -1,26 +1,18 @@
<?php
namespace App\Form;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\CollectionType;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Form\FormView;
/**
* This a workaround for the issue #37024.
* @package App\Form
*/
class WorkaroundCollectionType extends CollectionType
{
/**
* Use the original implementation for finishView() instead of the one, the one that cause the bug.
* @param FormView $view
* @param FormInterface $form
* @param array $options
*/
public function finishView(FormView $view, FormInterface $form, array $options)
{
@ -28,4 +20,4 @@ class WorkaroundCollectionType extends CollectionType
$view->vars['multipart'] = true;
}
}
}
}