Do not use distinct on table queries.

This should speed up table loading a lot.
This commit is contained in:
Jan Böhmer 2022-09-25 14:43:15 +02:00
parent 9179ea4559
commit c5d7f0a5b1
3 changed files with 4 additions and 4 deletions

View file

@ -226,7 +226,7 @@ final class AttachmentDataTable implements DataTableTypeInterface
private function getQuery(QueryBuilder $builder): void private function getQuery(QueryBuilder $builder): void
{ {
$builder->distinct()->select('attachment') $builder->select('attachment')
->addSelect('attachment_type') ->addSelect('attachment_type')
//->addSelect('element') //->addSelect('element')
->from(Attachment::class, 'attachment') ->from(Attachment::class, 'attachment')

View file

@ -297,7 +297,7 @@ class LogDataTable implements DataTableTypeInterface
protected function getQuery(QueryBuilder $builder, array $options): void protected function getQuery(QueryBuilder $builder, array $options): void
{ {
$builder->distinct()->select('log') $builder->select('log')
->addSelect('user') ->addSelect('user')
->from(AbstractLogEntry::class, 'log') ->from(AbstractLogEntry::class, 'log')
->leftJoin('log.user', 'user'); ->leftJoin('log.user', 'user');

View file

@ -292,8 +292,8 @@ final class PartsDataTable implements DataTableTypeInterface
private function getQuery(QueryBuilder $builder): void private function getQuery(QueryBuilder $builder): void
{ {
//Distinct is very slow here, do not add this here (also I think this is not needed here, as the id column is always distinct)
$builder->distinct()->select('part') $builder->select('part')
->addSelect('category') ->addSelect('category')
->addSelect('footprint') ->addSelect('footprint')
->addSelect('manufacturer') ->addSelect('manufacturer')