From c2db827c9d0734f20248a01737ac23514bd5f518 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20B=C3=B6hmer?= Date: Tue, 5 May 2020 19:55:31 +0200 Subject: [PATCH] Show warning, if no valid entity was found to generate a label (don't throw an exception) --- src/Controller/LabelController.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Controller/LabelController.php b/src/Controller/LabelController.php index 946ab9ab..ae62408a 100644 --- a/src/Controller/LabelController.php +++ b/src/Controller/LabelController.php @@ -108,8 +108,12 @@ class LabelController extends AbstractController if (($form->isSubmitted() && $form->isValid()) || ($generate && !$form->isSubmitted() && $profile !== null)) { $target_id = (string) $form->get('target_id')->getData(); $targets = $this->findObjects($form_options->getSupportedElement(), $target_id); - $pdf_data = $this->labelGenerator->generateLabel($form_options, $targets); - $filename = $this->getLabelName($targets[0], $profile); + if (!empty($targets)) { + $pdf_data = $this->labelGenerator->generateLabel($form_options, $targets); + $filename = $this->getLabelName($targets[0], $profile); + } else { + $this->addFlash('warning', 'label_generator.no_entities_found'); + } } return $this->render('LabelSystem/dialog.html.twig', [