Respect the currency of the prices when calculating average part price.

src/Services/PricedetailHelper.php

@@ -31,11 +31,10 @@
 
 namespace App\Services;
 
+use App\Entity\Parts\Part;
 use App\Entity\PriceInformations\Currency;
 use App\Entity\PriceInformations\Pricedetail;
 use Locale;
-use Money\Number;
-use Symfony\Component\Intl\Currencies;
 
 class PricedetailHelper
 {
@@ -48,6 +47,119 @@ class PricedetailHelper
         $this->locale = Locale::getDefault();
     }
 
+    /**
+     * Determines the highest amount, for which you get additional discount.
+     * This function determines the highest min_discount_quantity for the given part.
+     * @param Part $part
+     * @return float|null
+     */
+    public function getMaxDiscountAmount(Part $part) : ?float
+    {
+        $orderdetails = $part->getOrderdetails(true);
+
+        $max = 0;
+
+        foreach ($orderdetails as $orderdetail) {
+            $pricedetails = $orderdetail->getPricedetails();
+            //The orderdetail must have pricedetails, otherwise this will not work!
+            if (empty($pricedetails)) {
+                continue;
+            }
+
+            /* Pricedetails in orderdetails are ordered by min discount quantity,
+                so our first object is our min order amount for the current orderdetail */
+            $max_amount = $pricedetails->last()->getMinDiscountQuantity();
+
+            if ($max_amount > $max) {
+                $max = $max_amount;
+            }
+        }
+
+        if ($max > 0) {
+            return $max;
+        }
+
+        return null;
+    }
+
+    /**
+     * Determines the minimum amount of the part that can be ordered
+     * @param Part $part The part for which the minimum order amount should be determined.
+     * @return float
+     */
+    public function getMinOrderAmount(Part $part) : ?float
+    {
+        $orderdetails = $part->getOrderdetails(true);
+
+        $min = INF;
+
+        foreach ($orderdetails as $orderdetail) {
+            $pricedetails = $orderdetail->getPricedetails();
+            //The orderdetail must have pricedetails, otherwise this will not work!
+            if (count($pricedetails) === 0) {
+                continue;
+            }
+
+            /* Pricedetails in orderdetails are ordered by min discount quantity,
+                so our first object is our min order amount for the current orderdetail */
+            $min_amount = $pricedetails[0]->getMinDiscountQuantity();
+
+            if ($min_amount < $min) {
+                $min = $min_amount;
+            }
+        }
+
+        if ($min < INF) {
+            return $min;
+        }
+
+        return null;
+    }
+
+    /**
+     * Calculates the average price of a part, when ordering the amount $amount.
+     * @param Part $part The part for which the average price should be calculated.
+     * @param float $amount The order amount for which the average price should be calculated.
+     * If set to null, the mininmum order amount for the part is used.
+     * @param Currency|null $currency The currency in which the average price should be calculated
+     * @return string|null The Average price as bcmath string. Returns null, if it was not possible to calculate the
+     * price for the given
+     */
+    public function calculateAvgPrice(Part $part, ?float $amount = null, ?Currency $currency = null) : ?string
+    {
+        if ($amount === null) {
+            $amount = $this->getMinOrderAmount($part);
+        }
+
+        if ($amount === null) {
+            return null;
+        }
+
+        $orderdetails = $part->getOrderdetails(true);
+
+        $avg = "0";
+        $count = 0;
+
+        //Find the price for the amount, for the given
+        foreach ($orderdetails as $orderdetail) {
+            $pricedetail = $orderdetail->getPrice($amount);
+
+            //When we dont have informations about this amount, ignore it
+            if ($pricedetail === null) {
+                continue;
+            }
+
+            $avg = bcadd($avg, $this->convertMoneyToCurrency($pricedetail->getPricePerUnit(), $pricedetail->getCurrency(), $currency), Pricedetail::PRICE_PRECISION);
+            $count++;
+        }
+
+        if ($count === 0) {
+            return null;
+        }
+
+        return bcdiv($avg, (string) $count, Pricedetail::PRICE_PRECISION);
+    }
+
     /**
      * Converts the given value in origin currency to the choosen target currency
      * @param $value float|string The value that should be converted
@@ -60,11 +172,16 @@ class PricedetailHelper
      */
     public function convertMoneyToCurrency($value, ?Currency $originCurrency = null, ?Currency $targetCurrency = null) : ?string
     {
+        //Skip conversion, if both currencies are same
+        if ($originCurrency === $targetCurrency) {
+            return $value;
+        }
+
         $value = (string) $value;
 
         //Convert value to base currency
         $val_base = $value;
-        if($originCurrency !== null) {
+        if ($originCurrency !== null) {
             //Without an exchange rate we can not calculate the exchange rate
             if ((float) $originCurrency->getExchangeRate() === 0) {
                 return null;