mirror/Part-DB.Part-DB-server
1
0
Fork 1
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2025-06-21 09:35:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Removed timetravel permission

Browse source 
Now it is sufficient enough to have the show_history permission
This commit is contained in:
Jan Böhmer 2022-11-13 21:01:15 +01:00
parent 70120bdaa9
commit ae4cb23b18
4 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
config/permissions.yaml
View file

@ -112,9 +112,6 @@ perms: # Here comes a list with all Permission names (they have a perm_[name] co
label: "perm.tools.statistics" label: "perm.tools.statistics"
lastActivity: lastActivity:
label: "perm.tools.lastActivity" label: "perm.tools.lastActivity"
timetravel:
label: "perm.tools.timeTravel"
alsoSet: 'parts.show_history'
label_scanner: label_scanner:
label: "perm.tools.label_scanner" label: "perm.tools.label_scanner"
reel_calculator: reel_calculator:

1
src/Controller/AdminPages/BaseAdminController.php
View file

@ -143,7 +143,6 @@ abstract class BaseAdminController extends AbstractController
protected function revertElementIfNeeded(AbstractDBElement $entity, ?string $timestamp): ?DateTime protected function revertElementIfNeeded(AbstractDBElement $entity, ?string $timestamp): ?DateTime
{ {
if (null !== $timestamp) { if (null !== $timestamp) {
$this->denyAccessUnlessGranted('@tools.timetravel');
$this->denyAccessUnlessGranted('show_history', $entity); $this->denyAccessUnlessGranted('show_history', $entity);
//If the timestamp only contains numbers interpret it as unix timestamp //If the timestamp only contains numbers interpret it as unix timestamp
if (ctype_digit($timestamp)) { if (ctype_digit($timestamp)) {

1
src/Controller/PartController.php
View file

@ -102,7 +102,6 @@ class PartController extends AbstractController
$timeTravel_timestamp = null; $timeTravel_timestamp = null;
if (null !== $timestamp) { if (null !== $timestamp) {
$this->denyAccessUnlessGranted('@tools.timetravel');
$this->denyAccessUnlessGranted('show_history', $part); $this->denyAccessUnlessGranted('show_history', $part);
//If the timestamp only contains numbers interpret it as unix timestamp //If the timestamp only contains numbers interpret it as unix timestamp
if (ctype_digit($timestamp)) { if (ctype_digit($timestamp)) {

4
src/DataTables/LogDataTable.php
View file

@ -260,9 +260,7 @@ class LogDataTable implements DataTableTypeInterface
return null; return null;
}, },
'disabled' => function ($value, AbstractLogEntry $context) { 'disabled' => function ($value, AbstractLogEntry $context) {
return return !$this->security->isGranted('show_history', $context->getTargetClass());
!$this->security->isGranted('@tools.timetravel')
|| !$this->security->isGranted('show_history', $context->getTargetClass());
}, },
]); ]);