From a9bd4c5606675558d182480fc714c3b49ddb8f3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20B=C3=B6hmer?= Date: Thu, 20 Feb 2025 19:43:46 +0100 Subject: [PATCH] Use better parameter value parsing for pollin and reichelt parameters --- src/Services/InfoProviderSystem/Providers/PollinProvider.php | 4 ++-- .../InfoProviderSystem/Providers/ReicheltProvider.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Services/InfoProviderSystem/Providers/PollinProvider.php b/src/Services/InfoProviderSystem/Providers/PollinProvider.php index f6a0c12e..4d7eb3fb 100644 --- a/src/Services/InfoProviderSystem/Providers/PollinProvider.php +++ b/src/Services/InfoProviderSystem/Providers/PollinProvider.php @@ -184,9 +184,9 @@ class PollinProvider implements InfoProviderInterface //Iterate over each tr.properties-row inside table.product-detail-properties-table $dom->filter('table.product-detail-properties-table tr.properties-row')->each(function (Crawler $node) use (&$parameters) { - $parameters[] = ParameterDTO::parseValueField( + $parameters[] = ParameterDTO::parseValueIncludingUnit( name: rtrim($node->filter('th.properties-label')->text(), ':'), - value: $node->filter('td.properties-value')->text() + value: trim($node->filter('td.properties-value')->text()) ); }); diff --git a/src/Services/InfoProviderSystem/Providers/ReicheltProvider.php b/src/Services/InfoProviderSystem/Providers/ReicheltProvider.php index dceaeac4..1e9859fb 100644 --- a/src/Services/InfoProviderSystem/Providers/ReicheltProvider.php +++ b/src/Services/InfoProviderSystem/Providers/ReicheltProvider.php @@ -256,7 +256,7 @@ class ReicheltProvider implements InfoProviderInterface //Iterate over each second li in ul.articleAttribute, which contains the specifications $groupElement->filter('ul.articleAttribute li:nth-child(2n)')->each(function (Crawler $specElement) use (&$parameters, $groupName) { - $parameters[] = ParameterDTO::parseValueField( + $parameters[] = ParameterDTO::parseValueIncludingUnit( name: $specElement->previousAll()->text(), value: $specElement->text(), group: $groupName