Applied rector rules up to symfony 6.2

src/Command/User/ConvertToSAMLUserCommand.php

@@ -30,9 +30,10 @@ use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 
+#[\Symfony\Component\Console\Attribute\AsCommand('partdb:user:convert-to-saml-user|partdb:users:convert-to-saml-user', 'Converts a local user to a SAML user (and vice versa)')]
 class ConvertToSAMLUserCommand extends Command
 {
-    protected static $defaultName = 'partdb:user:convert-to-saml-user|partdb:users:convert-to-saml-user';
+    protected static $defaultDescription = 'Converts a local user to a SAML user (and vice versa)';
 
     protected EntityManagerInterface $entityManager;
     protected bool $saml_enabled;
@@ -46,9 +47,7 @@ class ConvertToSAMLUserCommand extends Command
 
     protected function configure(): void
     {
-        $this
-            ->setDescription('Converts a local user to a SAML user (and vice versa)')
-            ->setHelp('This converts a local user, which can login via the login form, to a SAML user, which can only login via SAML. This is useful if you want to migrate from a local user system to a SAML user system.')
+        $this->setHelp('This converts a local user, which can login via the login form, to a SAML user, which can only login via SAML. This is useful if you want to migrate from a local user system to a SAML user system.')
             ->addArgument('user', InputArgument::REQUIRED, 'The username (or email) of the user')
             ->addOption('to-local', null, InputOption::VALUE_NONE, 'Converts a SAML user to a local user')
         ;
@@ -70,7 +69,7 @@ class ConvertToSAMLUserCommand extends Command
         if (!$user) {
             $io->error('User not found!');
 
-            return 1;
+            return \Symfony\Component\Console\Command\Command::FAILURE;
         }
 
         $io->info('User found: '.$user->getFullName(true) . ': '.$user->getEmail().' [ID: ' . $user->getID() . ']');

src/Command/User/SetPasswordCommand.php

@@ -34,9 +34,10 @@ use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface;
 
+#[\Symfony\Component\Console\Attribute\AsCommand('partdb:users:set-password|app:set-password|users:set-password|partdb:user:set-password', 'Sets the password of a user')]
 class SetPasswordCommand extends Command
 {
-    protected static $defaultName = 'partdb:users:set-password|app:set-password|users:set-password|partdb:user:set-password';
+    protected static $defaultDescription = 'Sets the password of a user';
 
     protected EntityManagerInterface $entityManager;
     protected UserPasswordHasherInterface $encoder;
@@ -53,9 +54,7 @@ class SetPasswordCommand extends Command
 
     protected function configure(): void
     {
-        $this
-            ->setDescription('Sets the password of a user')
-            ->setHelp('This password allows you to set the password of a user, without knowing the old password.')
+        $this->setHelp('This password allows you to set the password of a user, without knowing the old password.')
             ->addArgument('user', InputArgument::REQUIRED, 'The username or email of the user')
         ;
     }
@@ -70,14 +69,14 @@ class SetPasswordCommand extends Command
         if (!$user) {
             $io->error(sprintf('No user with the given username %s found in the database!', $user_name));
 
-            return 1;
+            return \Symfony\Component\Console\Command\Command::FAILURE;
         }
 
         $io->note('User found!');
 
         if ($user->isSamlUser()) {
             $io->error('This user is a SAML user, so you can not change the password!');
-            return 1;
+            return \Symfony\Component\Console\Command\Command::FAILURE;
         }
 
         $proceed = $io->confirm(
@@ -85,7 +84,7 @@ class SetPasswordCommand extends Command
                 $user->getFullName(true), $user->getID()));
 
         if (!$proceed) {
-            return 1;
+            return \Symfony\Component\Console\Command\Command::FAILURE;
         }
 
         $success = false;
@@ -116,6 +115,6 @@ class SetPasswordCommand extends Command
         $security_event = new SecurityEvent($user);
         $this->eventDispatcher->dispatch($security_event, SecurityEvents::PASSWORD_CHANGED);
 
-        return 0;
+        return \Symfony\Component\Console\Command\Command::SUCCESS;
     }
 }

src/Command/User/UpgradePermissionsSchemaCommand.php

@@ -31,11 +31,9 @@ use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 
+#[\Symfony\Component\Console\Attribute\AsCommand('partdb:users:upgrade-permissions-schema', '(Manually) upgrades the permissions schema of all users to the latest version.')]
 final class UpgradePermissionsSchemaCommand extends Command
 {
-    protected static $defaultName = 'partdb:users:upgrade-permissions-schema';
-    protected static $defaultDescription = '(Manually) upgrades the permissions schema of all users to the latest version.';
-
     private PermissionSchemaUpdater $permissionSchemaUpdater;
     private EntityManagerInterface $em;
     private EventCommentHelper $eventCommentHelper;
@@ -84,7 +82,7 @@ final class UpgradePermissionsSchemaCommand extends Command
         if (empty($groups_to_upgrade) && empty($users_to_upgrade)) {
             $io->success('All users and group permissions schemas are up-to-date. No update needed.');
 
-            return 0;
+            return \Symfony\Component\Console\Command\Command::SUCCESS;
         }
 
         //List all users and groups that need an update
@@ -100,7 +98,7 @@ final class UpgradePermissionsSchemaCommand extends Command
 
         if(!$io->confirm('Continue with the update?', false)) {
             $io->warning('Update aborted.');
-            return 0;
+            return \Symfony\Component\Console\Command\Command::SUCCESS;
         }
 
         //Update all users and groups

src/Command/User/UserEnableCommand.php

@@ -29,9 +29,10 @@ use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 
+#[\Symfony\Component\Console\Attribute\AsCommand('partdb:users:enable|partdb:user:enable', 'Enables/Disable the login of one or more users')]
 class UserEnableCommand extends Command
 {
-    protected static $defaultName = 'partdb:users:enable|partdb:user:enable';
+    protected static $defaultDescription = 'Enables/Disable the login of one or more users';
 
     protected EntityManagerInterface $entityManager;
 
@@ -44,9 +45,7 @@ class UserEnableCommand extends Command
 
     protected function configure(): void
     {
-        $this
-            ->setDescription('Enables/Disable the login of one or more users')
-            ->setHelp('This allows you to allow or prevent the login of certain user. Use the --disable option to disable the login for the given users')
+        $this->setHelp('This allows you to allow or prevent the login of certain user. Use the --disable option to disable the login for the given users')
             ->addArgument('users', InputArgument::IS_ARRAY, 'The usernames of the users to use')
             ->addOption('all', 'a', InputOption::VALUE_NONE, 'Enable/Disable all users')
             ->addOption('disable', 'd', InputOption::VALUE_NONE, 'Disable the login of the given users')

src/Command/User/UserListCommand.php

@@ -28,9 +28,10 @@ use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 
+#[\Symfony\Component\Console\Attribute\AsCommand('partdb:users:list|users:list', 'Lists all users')]
 class UserListCommand extends Command
 {
-    protected static $defaultName = 'partdb:users:list|users:list';
+    protected static $defaultDescription = 'Lists all users';
 
     protected EntityManagerInterface $entityManager;
 
@@ -43,9 +44,7 @@ class UserListCommand extends Command
 
     protected function configure(): void
     {
-        $this
-            ->setDescription('Lists all users')
-            ->setHelp('This command lists all users in the database.')
+        $this->setHelp('This command lists all users in the database.')
             ->addOption('local', 'l', null, 'Only list local users')
             ->addOption('saml', 's', null, 'Only list SAML users')
         ;

src/Command/User/UsersPermissionsCommand.php

@@ -34,11 +34,9 @@ use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
+#[\Symfony\Component\Console\Attribute\AsCommand('partdb:users:permissions|partdb:user:permissions', 'View and edit the permissions of a given user')]
 class UsersPermissionsCommand extends Command
 {
-    protected static $defaultName = 'partdb:users:permissions|partdb:user:permissions';
-    protected static $defaultDescription = 'View and edit the permissions of a given user';
-
     protected EntityManagerInterface $entityManager;
     protected UserRepository $userRepository;
     protected PermissionManager $permissionResolver;