Fixed phpstan analysis issues and bad code that showed up with phpstan 2.0

src/Entity/Attachments/Attachment.php

@@ -531,7 +531,7 @@ abstract class Attachment extends AbstractNamedDBElement
         $url = str_replace(' ', '%20', $url);
 
         //Only set if the URL is not empty
-        if ($url !== null && $url !== '') {
+        if ($url !== '') {
             if (str_contains($url, '%BASE%') || str_contains($url, '%MEDIA%')) {
                 throw new InvalidArgumentException('You can not reference internal files via the url field! But nice try!');
             }

src/Entity/Attachments/AttachmentContainingDBElement.php

@@ -33,7 +33,7 @@ use Doctrine\ORM\Mapping as ORM;
 use Symfony\Component\Serializer\Annotation\Groups;
 
 /**
- * @template-covariant AT of Attachment
+ * @template AT of Attachment
  */
 #[ORM\MappedSuperclass(repositoryClass: AttachmentContainingDBElementRepository::class)]
 abstract class AttachmentContainingDBElement extends AbstractNamedDBElement implements HasMasterAttachmentInterface, HasAttachmentsInterface

src/Entity/Base/AbstractCompany.php

@@ -33,8 +33,8 @@ use Symfony\Component\Validator\Constraints as Assert;
 /**
  * This abstract class is used for companies like suppliers or manufacturers.
  *
- * @template-covariant AT of Attachment
- * @template-covariant PT of AbstractParameter
+ * @template AT of Attachment
+ * @template PT of AbstractParameter
  * @extends AbstractPartsContainingDBElement<AT, PT>
  */
 #[ORM\MappedSuperclass]

src/Entity/Base/AbstractPartsContainingDBElement.php

@@ -31,8 +31,8 @@ use Doctrine\ORM\Mapping as ORM;
 use Symfony\Component\Serializer\Annotation\Groups;
 
 /**
- * @template-covariant AT of Attachment
- * @template-covariant PT of AbstractParameter
+ * @template AT of Attachment
+ * @template PT of AbstractParameter
  * @extends AbstractStructuralDBElement<AT, PT>
  */
 #[ORM\MappedSuperclass(repositoryClass: AbstractPartsContainingRepository::class)]

src/Entity/Base/AbstractStructuralDBElement.php

@@ -53,8 +53,8 @@ use Symfony\Component\Serializer\Annotation\Groups;
  *
  * @see \App\Tests\Entity\Base\AbstractStructuralDBElementTest
  *
- * @template-covariant AT of Attachment
- * @template-covariant PT of AbstractParameter
+ * @template AT of Attachment
+ * @template PT of AbstractParameter
  * @template-use ParametersTrait<PT>
  * @extends AttachmentContainingDBElement<AT>
  * @uses ParametersTrait<PT>

src/Entity/LabelSystem/LabelSupportedElement.php

@@ -22,6 +22,8 @@ declare(strict_types=1);
  */
 namespace App\Entity\LabelSystem;
 
+use App\Entity\Base\AbstractDBElement;
+use App\Entity\Base\AbstractNamedDBElement;
 use App\Entity\Parts\Part;
 use App\Entity\Parts\PartLot;
 use App\Entity\Parts\StorageLocation;
@@ -34,7 +36,7 @@ enum LabelSupportedElement: string
 
     /**
      * Returns the entity class for the given element type
-     * @return string
+     * @return class-string<AbstractDBElement>
      */
     public function getEntityClass(): string
     {

src/Entity/Parts/PartLot.php

@@ -185,7 +185,6 @@ class PartLot extends AbstractDBElement implements TimeStampableInterface, Named
      *
      * @return bool|null True, if the part lot is expired. Returns null, if no expiration date was set.
      *
-     * @throws Exception If an error with the DateTime occurs
      */
     public function isExpired(): ?bool
     {

src/Entity/Parts/Supplier.php

@@ -103,7 +103,7 @@ class Supplier extends AbstractCompany
     protected ?AbstractStructuralDBElement $parent = null;
 
     /**
-     * @var Collection<int, Orderdetail>|Orderdetail[]
+     * @var Collection<int, Orderdetail>
      */
     #[ORM\OneToMany(mappedBy: 'supplier', targetEntity: Orderdetail::class)]
     protected Collection $orderdetails;

src/Entity/ProjectSystem/Project.php

@@ -333,7 +333,6 @@ class Project extends AbstractStructuralDBElement
     {
         //If this project has subprojects, and these have builds part, they must be included in the BOM
         foreach ($this->getChildren() as $child) {
-            /** @var $child Project */
             if (!$child->getBuildPart() instanceof Part) {
                 continue;
             }

src/Entity/UserSystem/User.php

@@ -893,8 +893,6 @@ class User extends AttachmentContainingDBElement implements UserInterface, HasPe
      * @param string[] $codes An array containing the backup codes
      *
      * @return $this
-     *
-     * @throws Exception If an error with the datetime occurs
      */
     public function setBackupCodes(array $codes): self
     {