mirror of
https://github.com/Part-DB/Part-DB-server.git
synced 2025-07-09 18:04:33 +02:00
Fixed some inspection issues
This commit is contained in:
parent
c6f1758a18
commit
8ae4e9fe05
39 changed files with 46 additions and 56 deletions
|
@ -185,7 +185,7 @@ abstract class Attachment extends AbstractNamedDBElement
|
|||
//After the %PLACEHOLDER% comes a slash, so we can check if we have a placeholder via explode
|
||||
$tmp = explode('/', $this->path);
|
||||
|
||||
return !in_array($tmp[0], array_merge(static::INTERNAL_PLACEHOLDER, static::BUILTIN_PLACEHOLDER));
|
||||
return !in_array($tmp[0], array_merge(static::INTERNAL_PLACEHOLDER, static::BUILTIN_PLACEHOLDER), true);
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -331,7 +331,7 @@ abstract class Attachment extends AbstractNamedDBElement
|
|||
*/
|
||||
public function getShowInTable(): bool
|
||||
{
|
||||
return (bool) $this->show_in_table;
|
||||
return $this->show_in_table;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
@ -259,7 +259,7 @@ class PartLot extends AbstractDBElement implements TimeStampableInterface, Named
|
|||
return round($this->amount);
|
||||
}
|
||||
|
||||
return (float) $this->amount;
|
||||
return $this->amount;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
@ -107,7 +107,7 @@ class Storelocation extends AbstractPartsContainingDBElement
|
|||
*/
|
||||
public function isFull(): bool
|
||||
{
|
||||
return (bool) $this->is_full;
|
||||
return $this->is_full;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
@ -176,7 +176,7 @@ class Orderdetail extends AbstractDBElement implements TimeStampableInterface, N
|
|||
*/
|
||||
public function getObsolete(): bool
|
||||
{
|
||||
return (bool) $this->obsolete;
|
||||
return $this->obsolete;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
@ -187,7 +187,7 @@ class Pricedetail extends AbstractDBElement implements TimeStampableInterface
|
|||
if ($this->orderdetail && $this->orderdetail->getPart() && !$this->orderdetail->getPart()->useFloatAmount()) {
|
||||
$tmp = round($this->price_related_quantity);
|
||||
|
||||
return $tmp < 1 ? 1 : $tmp;
|
||||
return max($tmp, 1);
|
||||
}
|
||||
|
||||
return $this->price_related_quantity;
|
||||
|
|
|
@ -283,7 +283,7 @@ class User extends AttachmentContainingDBElement implements UserInterface, HasPe
|
|||
*/
|
||||
public function getUsername(): string
|
||||
{
|
||||
return (string) $this->name;
|
||||
return $this->name;
|
||||
}
|
||||
|
||||
public function getUserIdentifier(): string
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue