mirror/Part-DB.Part-DB-server
1
0
Fork 1
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2025-06-21 01:25:55 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Really use euro as base currency when querying exchange rates, so we can use the configuration-free ECB provider

Browse source 
This should fixes issue #154.
This commit is contained in:
Jan Böhmer 2022-12-11 15:33:50 +01:00
parent 2b2fc6f1e6
commit 7235cb72b4
4 changed files with 29 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
config/packages/swap.yaml
View file

@ -1,4 +1,8 @@
florianv_swap: florianv_swap:
cache:
ttl: 3600 # 1 hour
providers: providers:
european_central_bank: ~ # European Central Bank (only works for EUR base currency) european_central_bank: ~ # European Central Bank (only works for EUR base currency)
fixer: # Fixer.io (needs an API key) fixer: # Fixer.io (needs an API key)

12
src/Services/ExchangeRateUpdater.php
View file

@ -22,6 +22,7 @@ namespace App\Services;
use App\Entity\PriceInformations\Currency; use App\Entity\PriceInformations\Currency;
use Brick\Math\BigDecimal; use Brick\Math\BigDecimal;
use Brick\Math\RoundingMode;
use Swap\Swap; use Swap\Swap;
class ExchangeRateUpdater class ExchangeRateUpdater
@ -40,8 +41,15 @@ class ExchangeRateUpdater
*/ */
public function update(Currency $currency): Currency public function update(Currency $currency): Currency
{ {
$rate = $this->swap->latest($currency->getIsoCode().'/'.$this->base_currency); //Currency pairs are always in the format "BASE/QUOTE"
$currency->setExchangeRate(BigDecimal::of($rate->getValue())); $rate = $this->swap->latest($this->base_currency.'/'.$currency->getIsoCode());
//The rate says how many quote units are worth one base unit
//So we need to invert it to get the exchange rate
$rate_bd = BigDecimal::of($rate->getValue());
$rate_inverted = BigDecimal::one()->dividedBy($rate_bd, Currency::PRICE_SCALE, RoundingMode::HALF_UP);
$currency->setExchangeRate($rate_inverted);
return $currency; return $currency;
} }

14
templates/AdminPages/CurrencyAdmin.html.twig
View file

@ -18,15 +18,19 @@
{% endif %} {% endif %}
{{ form_row(form.exchange_rate) }} {{ form_row(form.exchange_rate) }}
{% if entity.inverseExchangeRate %}
<p class="form-text text-muted offset-3 col-9">
{{ '1'|format_currency(default_currency) }} = {{ entity.inverseExchangeRate.tofloat | format_currency(entity.isoCode, {fraction_digit: 5}) }}<br>
{{ '1'|format_currency(entity.isoCode) }} = {{ entity.exchangeRate.tofloat | format_currency(default_currency, {fraction_digit: 5}) }}
</p>
{% endif %}
{% if form.update_exchange_rate is defined %} {% if form.update_exchange_rate is defined %}
{{ form_row(form.update_exchange_rate, {attr: {class: 'btn-info'}}) }} {{ form_row(form.update_exchange_rate, {attr: {class: 'btn-info'}}) }}
{% endif %} {% endif %}
{% if entity.inverseExchangeRate %}
<span class="form-text text-muted offset-3 col-9">
{{ '1'|format_currency(default_currency) }} = {{ entity.inverseExchangeRate.tofloat | format_currency(entity.isoCode, {fraction_digit: 5}) }}
</span>
{% endif %}
{% endblock %} {% endblock %}
{% block edit_title %} {% block edit_title %}

6
translations/messages.en.xlf
View file

@ -9941,5 +9941,11 @@ Element 3</target>
<target>Unable to retrieve the exchange rate. Check your exchange rate provider configuration.</target> <target>Unable to retrieve the exchange rate. Check your exchange rate provider configuration.</target>
</segment> </segment>
</unit> </unit>
<unit id="E_M7mZ5" name="currency.edit.exchange_rate_updated.success">
<segment>
<source>currency.edit.exchange_rate_updated.success</source>
<target>Retrieved the exchange rate successfully.</target>
</segment>
</unit>
</file> </file>
</xliff> </xliff>