Added declare strict types to all files

rector.php

@@ -2,15 +2,17 @@
 
 declare(strict_types=1);
 
-use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
+use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
 use Rector\Config\RectorConfig;
 use Rector\Doctrine\Set\DoctrineSetList;
+use Rector\PHPUnit\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector;
 use Rector\PHPUnit\Set\PHPUnitLevelSetList;
 use Rector\PHPUnit\Set\PHPUnitSetList;
 use Rector\Set\ValueObject\LevelSetList;
 use Rector\Set\ValueObject\SetList;
 use Rector\Symfony\Set\SymfonyLevelSetList;
 use Rector\Symfony\Set\SymfonySetList;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->symfonyContainerXml(__DIR__ . '/var/cache/dev/App_KernelDevDebugContainer.xml');
@@ -31,6 +33,10 @@ return static function (RectorConfig $rectorConfig): void {
     // register a single rule
     //$rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);
 
+    $rectorConfig->rules([
+        DeclareStrictTypesRector::class,
+    ]);
+
     // define sets of rules
     $rectorConfig->sets([
         //PHP rules
@@ -49,4 +55,9 @@ return static function (RectorConfig $rectorConfig): void {
         PHPUnitLevelSetList::UP_TO_PHPUNIT_90,
         PHPUnitSetList::PHPUNIT_CODE_QUALITY,
     ]);
+
+    $rectorConfig->skip([
+        AddDoesNotPerformAssertionToNonAssertingTestRector::class,
+        CountArrayToEmptyArrayComparisonRector::class,
+    ]);
 };

src/Command/BackupCommand.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Command;
 
 use Symfony\Component\Console\Attribute\AsCommand;

src/Command/CheckRequirementsCommand.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Command;
 
 use Symfony\Component\Console\Attribute\AsCommand;

src/Command/Migrations/ImportPartKeeprCommand.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Command\Migrations;
 
 use Symfony\Component\Console\Attribute\AsCommand;

src/Command/User/ConvertToSAMLUserCommand.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Command\User;
 
 use Symfony\Component\Console\Attribute\AsCommand;

src/Command/User/UpgradePermissionsSchemaCommand.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Command\User;
 
 use Symfony\Component\Console\Attribute\AsCommand;

src/Command/User/UserEnableCommand.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Command\User;
 
 use Symfony\Component\Console\Attribute\AsCommand;

src/Command/User/UserListCommand.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Command\User;
 
 use Symfony\Component\Console\Attribute\AsCommand;

src/Command/User/UsersPermissionsCommand.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Command\User;
 
 use Symfony\Component\Console\Attribute\AsCommand;

src/Command/VersionCommand.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Command;
 
 use Symfony\Component\Console\Attribute\AsCommand;

src/Controller/PartImportExportController.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Controller;
 
 use App\Entity\Parts\Part;

src/Controller/ProjectController.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Controller;
 
 use App\DataTables\ProjectBomEntriesDataTable;

src/Controller/RedirectController.php

@@ -50,7 +50,7 @@ class RedirectController extends AbstractController
 
         //Check if a user has set a preferred language setting:
         $user = $this->getUser();
-        if (($user instanceof User) && !empty($user->getLanguage())) {
+        if (($user instanceof User) && ($user->getLanguage() !== null && $user->getLanguage() !== '')) {
             $locale = $user->getLanguage();
         }
 

src/Controller/SelectAPIController.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /**
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Controller;
 
 use App\Entity\Base\AbstractNamedDBElement;

src/Controller/ToolsController.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Controller;
 
 use App\Services\Attachments\AttachmentPathResolver;

src/Controller/UserSettingsController.php

@@ -81,7 +81,7 @@ class UserSettingsController extends AbstractController
             throw new RuntimeException('You can not remove U2F keys from SAML users!');
         }
 
-        if (empty($user->getBackupCodes())) {
+        if ($user->getBackupCodes() === []) {
             $this->addFlash('error', 'tfa_backup.no_codes_enabled');
 
             throw new RuntimeException('You do not have any backup codes enabled, therefore you can not view them!');
@@ -361,7 +361,7 @@ class UserSettingsController extends AbstractController
             'attr' => [
                 'class' => 'btn-danger',
             ],
-            'disabled' => empty($user->getBackupCodes()),
+            'disabled' => $user->getBackupCodes() === [],
         ])->getForm();
 
         $backup_form->handleRequest($request);

src/Controller/WebauthnKeyRegistrationController.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Controller;
 
 use App\Entity\UserSystem\User;

src/DataTables/Adapters/CustomFetchJoinORMAdapter.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Adapters;
 
 use Doctrine\ORM\QueryBuilder;

src/DataTables/Column/PrettyBoolColumn.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Column;
 
 use Omines\DataTablesBundle\Column\AbstractColumn;

src/DataTables/Column/RowClassColumn.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Column;
 
 use Omines\DataTablesBundle\Column\AbstractColumn;

src/DataTables/Column/SIUnitNumberColumn.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Column;
 
 use App\Services\Formatters\SIFormatter;

src/DataTables/Column/SelectColumn.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Column;
 
 use Omines\DataTablesBundle\Column\AbstractColumn;

src/DataTables/ErrorDataTable.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables;
 
 use App\DataTables\Column\RowClassColumn;

src/DataTables/Filters/AttachmentFilter.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters;
 
 use App\DataTables\Filters\Constraints\BooleanConstraint;

src/DataTables/Filters/CompoundFilterTrait.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters;
 
 use Doctrine\Common\Collections\Collection;

src/DataTables/Filters/Constraints/AbstractConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints;
 
 use App\DataTables\Filters\FilterInterface;

src/DataTables/Filters/Constraints/BooleanConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints;
 
 use Doctrine\ORM\QueryBuilder;

src/DataTables/Filters/Constraints/ChoiceConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints;
 
 use Doctrine\ORM\QueryBuilder;
@@ -68,7 +70,7 @@ class ChoiceConstraint extends AbstractConstraint
 
     public function isEnabled(): bool
     {
-        return !empty($this->operator);
+        return $this->operator !== '';
     }
 
     public function apply(QueryBuilder $queryBuilder): void

src/DataTables/Filters/Constraints/DateTimeConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints;
 
 /**

src/DataTables/Filters/Constraints/EntityConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints;
 
 use App\Entity\Base\AbstractDBElement;
@@ -112,7 +114,7 @@ class EntityConstraint extends AbstractConstraint
 
     public function isEnabled(): bool
     {
-        return !empty($this->operator);
+        return $this->operator !== null && $this->operator !== '';
     }
 
     public function apply(QueryBuilder $queryBuilder): void

src/DataTables/Filters/Constraints/FilterTrait.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints;
 
 use Doctrine\ORM\QueryBuilder;

src/DataTables/Filters/Constraints/InstanceOfConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints;
 
 use Doctrine\ORM\QueryBuilder;
@@ -75,7 +77,7 @@ class InstanceOfConstraint extends AbstractConstraint
 
     public function isEnabled(): bool
     {
-        return !empty($this->operator);
+        return $this->operator !== '';
     }
 
     public function apply(QueryBuilder $queryBuilder): void

src/DataTables/Filters/Constraints/IntConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints;
 
 use Doctrine\ORM\QueryBuilder;

src/DataTables/Filters/Constraints/NumberConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints;
 
 use Doctrine\ORM\QueryBuilder;
@@ -82,7 +84,7 @@ class NumberConstraint extends AbstractConstraint
     public function isEnabled(): bool
     {
         return $this->value1 !== null
-            && !empty($this->operator);
+            && ($this->operator !== null && $this->operator !== '');
     }
 
     public function apply(QueryBuilder $queryBuilder): void

src/DataTables/Filters/Constraints/Part/LessThanDesiredConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints\Part;
 
 use App\DataTables\Filters\Constraints\BooleanConstraint;

src/DataTables/Filters/Constraints/Part/ParameterConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints\Part;
 
 use App\DataTables\Filters\Constraints\AbstractConstraint;
@@ -72,19 +74,19 @@ class ParameterConstraint extends AbstractConstraint
             ->from(PartParameter::class, $this->alias)
             ->where($this->alias . '.element = part');
 
-        if (!empty($this->name)) {
+        if ($this->name !== '') {
             $paramName = $this->generateParameterIdentifier('params.name');
             $subqb->andWhere($this->alias . '.name = :' . $paramName);
             $queryBuilder->setParameter($paramName,  $this->name);
         }
 
-        if (!empty($this->symbol)) {
+        if ($this->symbol !== '') {
             $paramName = $this->generateParameterIdentifier('params.symbol');
             $subqb->andWhere($this->alias . '.symbol = :' . $paramName);
             $queryBuilder->setParameter($paramName,  $this->symbol);
         }
 
-        if (!empty($this->unit)) {
+        if ($this->unit !== '') {
             $paramName = $this->generateParameterIdentifier('params.unit');
             $subqb->andWhere($this->alias . '.unit = :' . $paramName);
             $queryBuilder->setParameter($paramName,  $this->unit);

src/DataTables/Filters/Constraints/Part/ParameterValueConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints\Part;
 
 use App\DataTables\Filters\Constraints\NumberConstraint;

src/DataTables/Filters/Constraints/Part/TagsConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints\Part;
 
 use Doctrine\ORM\Query\Expr\Orx;
@@ -74,7 +76,7 @@ class TagsConstraint extends AbstractConstraint
     public function isEnabled(): bool
     {
         return $this->value !== null
-            && !empty($this->operator);
+            && ($this->operator !== null && $this->operator !== '');
     }
 
     /**

src/DataTables/Filters/Constraints/TextConstraint.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters\Constraints;
 
 use Doctrine\ORM\QueryBuilder;
@@ -72,7 +74,7 @@ class TextConstraint extends AbstractConstraint
     public function isEnabled(): bool
     {
         return $this->value !== null
-            && !empty($this->operator);
+            && ($this->operator !== null && $this->operator !== '');
     }
 
     public function apply(QueryBuilder $queryBuilder): void

src/DataTables/Filters/FilterInterface.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters;
 
 use Doctrine\ORM\QueryBuilder;

src/DataTables/Filters/LogFilter.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters;
 
 use App\DataTables\Filters\Constraints\ChoiceConstraint;

src/DataTables/Filters/PartFilter.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters;
 
 use App\DataTables\Filters\Constraints\BooleanConstraint;

src/DataTables/Filters/PartSearchFilter.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Filters;
 
 use Doctrine\ORM\Query\Expr;
@@ -121,7 +123,7 @@ class PartSearchFilter implements FilterInterface
         $fields_to_search = $this->getFieldsToSearch();
 
         //If we have nothing to search for, do nothing
-        if ($fields_to_search === [] || empty($this->keyword)) {
+        if ($fields_to_search === [] || $this->keyword === '') {
             return;
         }
 

src/DataTables/Helpers/PartDataTableHelper.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables\Helpers;
 
 use App\Entity\ProjectSystem\Project;

src/DataTables/ProjectBomEntriesDataTable.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\DataTables;
 
 use App\DataTables\Column\EntityColumn;
@@ -88,7 +90,7 @@ class ProjectBomEntriesDataTable implements DataTableTypeInterface
                     }
                     if($context->getPart() instanceof Part) {
                         $tmp = $this->partDataTableHelper->renderName($context->getPart());
-                        if(!empty($context->getName())) {
+                        if($context->getName() !== null && $context->getName() !== '') {
                             $tmp .= '<br><b>'.htmlspecialchars($context->getName()).'</b>';
                         }
                         return $tmp;

src/Doctrine/Purger/ResetAutoIncrementPurgerFactory.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Doctrine\Purger;
 
 use Doctrine\Bundle\FixturesBundle\Purger\PurgerFactory;

src/Doctrine/SQLiteRegexExtension.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Doctrine;
 
 use App\Exceptions\InvalidRegexException;

src/Doctrine/SetSQLMode/SetSQLModeMiddlewareDriver.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Doctrine\SetSQLMode;
 
 use Doctrine\DBAL\Driver\Connection;

src/Doctrine/SetSQLMode/SetSQLModeMiddlewareWrapper.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Doctrine\SetSQLMode;
 
 use Doctrine\DBAL\Driver;

src/Doctrine/Types/BigDecimalType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /**
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Doctrine\Types;
 
 use Brick\Math\BigDecimal;

src/Doctrine/Types/TinyIntType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Doctrine\Types;
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;

src/Entity/Attachments/Attachment.php

@@ -182,7 +182,7 @@ abstract class Attachment extends AbstractNamedDBElement
     public function isExternal(): bool
     {
         //When path is empty, this attachment can not be external
-        if (empty($this->path)) {
+        if ($this->path === '') {
             return false;
         }
 
@@ -236,7 +236,7 @@ abstract class Attachment extends AbstractNamedDBElement
             return null;
         }
 
-        if (!empty($this->original_filename)) {
+        if ($this->original_filename !== null && $this->original_filename !== '') {
             return strtolower(pathinfo($this->original_filename, PATHINFO_EXTENSION));
         }
 
@@ -302,7 +302,7 @@ abstract class Attachment extends AbstractNamedDBElement
         }
 
         //If we have a stored original filename, then use it
-        if (!empty($this->original_filename)) {
+        if ($this->original_filename !== null && $this->original_filename !== '') {
             return $this->original_filename;
         }
 
@@ -411,7 +411,7 @@ abstract class Attachment extends AbstractNamedDBElement
     public function setURL(?string $url): self
     {
         //Only set if the URL is not empty
-        if (!empty($url)) {
+        if ($url !== null && $url !== '') {
             if (str_contains($url, '%BASE%') || str_contains($url, '%MEDIA%')) {
                 throw new InvalidArgumentException('You can not reference internal files via the url field! But nice try!');
             }

src/Entity/Base/PartsContainingRepositoryInterface.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /**
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Entity\Base;
 
 use App\Entity\Parts\Part;

src/Entity/Contracts/LogWithNewDataInterface.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Entity\Contracts;
 
 interface LogWithNewDataInterface

src/Entity/LogSystem/PartStockChangedLogEntry.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Entity\LogSystem;
 
 use App\Entity\Parts\PartLot;
@@ -64,7 +66,7 @@ class PartStockChangedLogEntry extends AbstractLogEntry
             'n' => $new_stock,
             'p' => $new_total_part_instock,
         ]);
-        if (!empty($comment)) {
+        if ($comment !== '') {
             $this->extra['c'] = mb_strimwidth($comment, 0, self::COMMENT_MAX_LENGTH, '...');
         }
 

src/Entity/Parameters/AbstractParameter.php

@@ -394,7 +394,7 @@ abstract class AbstractParameter extends AbstractNamedDBElement
     protected function formatWithUnit(float $value, string $format = '%g'): string
     {
         $str = sprintf($format, $value);
-        if (!empty($this->unit)) {
+        if ($this->unit !== '') {
             return $str.' '.$this->unit;
         }
 

src/Entity/Parts/Part.php

@@ -147,7 +147,7 @@ class Part extends AttachmentContainingDBElement
         //Ensure that the part name fullfills the regex of the category
         if ($this->category instanceof Category) {
             $regex = $this->category->getPartnameRegex();
-            if (!empty($regex) && !preg_match($regex, $this->name)) {
+            if ($regex !== '' && !preg_match($regex, $this->name)) {
                 $context->buildViolation('part.name.must_match_category_regex')
                     ->atPath('name')
                     ->setParameter('%regex%', $regex)

src/Entity/Parts/PartTraits/ProjectTrait.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Entity\Parts\PartTraits;
 
 use App\Entity\ProjectSystem\Project;

src/Entity/ProjectSystem/ProjectBOMEntry.php

@@ -242,7 +242,7 @@ class ProjectBOMEntry extends AbstractDBElement
         }
 
         //Check that the number of mountnames is the same as the (rounded) quantity
-        if (!empty($this->mountnames) && count($uniq_mountnames) !== (int) round ($this->quantity)) {
+        if ($this->mountnames !== '' && count($uniq_mountnames) !== (int) round ($this->quantity)) {
             $context->buildViolation('project.bom_entry.mountnames_quantity_mismatch')
                 ->atPath('mountnames')
                 ->addViolation();

src/Entity/UserSystem/PermissionData.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Entity\UserSystem;
 
 use Doctrine\DBAL\Types\Types;

src/Entity/UserSystem/User.php

@@ -500,7 +500,7 @@ class User extends AttachmentContainingDBElement implements UserInterface, HasPe
     {
         $tmp = $this->getFirstName();
         //Don't add a space, if the name has only one part (it would look strange)
-        if (!empty($this->getFirstName()) && !empty($this->getLastName())) {
+        if ($this->getFirstName() !== null && $this->getFirstName() !== '' && ($this->getLastName() !== null && $this->getLastName() !== '')) {
             $tmp .= ' ';
         }
         $tmp .= $this->getLastName();

src/Entity/UserSystem/WebauthnKey.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Entity\UserSystem;
 
 use Doctrine\DBAL\Types\Types;

src/EventSubscriber/LogSystem/EventLoggerSubscriber.php

@@ -146,7 +146,7 @@ class EventLoggerSubscriber implements EventSubscriber
         $uow = $em->getUnitOfWork();
         // If we have added any ElementCreatedLogEntries added in postPersist, we flush them here.
         $uow->computeChangeSets();
-        if ($uow->hasPendingInsertions() || !empty($uow->getScheduledEntityUpdates())) {
+        if ($uow->hasPendingInsertions() || $uow->getScheduledEntityUpdates() !== []) {
             $em->flush();
         }
 

src/EventSubscriber/LogSystem/LogDBMigrationSubscriber.php

@@ -55,8 +55,8 @@ class LogDBMigrationSubscriber implements EventSubscriber
         $this->new_version = (string) $aliasResolver->resolveVersionAlias('current');
 
         //After everything is done, write the results to DB log
-        $this->old_version = empty($this->old_version) ? 'legacy/empty' : $this->old_version;
-        $this->new_version = empty($this->new_version) ? 'unknown' : $this->new_version;
+        $this->old_version = $this->old_version === null || $this->old_version === '' ? 'legacy/empty' : $this->old_version;
+        $this->new_version = $this->new_version === '' ? 'unknown' : $this->new_version;
 
         try {
             $log = new DatabaseUpdatedLogEntry($this->old_version, $this->new_version);

src/EventSubscriber/UserSystem/SetUserTimezoneSubscriber.php

@@ -43,12 +43,12 @@ final class SetUserTimezoneSubscriber implements EventSubscriberInterface
 
         //Check if the user has set a timezone
         $user = $this->security->getUser();
-        if ($user instanceof User && !empty($user->getTimezone())) {
+        if ($user instanceof User && ($user->getTimezone() !== null && $user->getTimezone() !== '')) {
             $timezone = $user->getTimezone();
         }
 
         //Fill with default value if needed
-        if (null === $timezone && !empty($this->default_timezone)) {
+        if (null === $timezone && $this->default_timezone !== '') {
             $timezone = $this->default_timezone;
         }
 

src/EventSubscriber/UserSystem/UpgradePermissionsSchemaSubscriber.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\EventSubscriber\UserSystem;
 
 use Symfony\Bundle\SecurityBundle\Security;

src/Exceptions/InvalidRegexException.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Exceptions;
 
 use Doctrine\DBAL\Exception\DriverException;

src/Form/AdminPages/ProjectAdminForm.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\AdminPages;
 
 use App\Entity\Base\AbstractNamedDBElement;

src/Form/AttachmentFormType.php

@@ -144,7 +144,7 @@ class AttachmentFormType extends AbstractType
             }
 
             //If the name is empty, use the original file name as attachment name
-            if (empty($attachment->getName())) {
+            if ($attachment->getName() === '') {
                 $attachment->setName($file->getClientOriginalName());
             }
         }, 100000);

src/Form/Filters/AttachmentFilterType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters;
 
 use App\DataTables\Filters\AttachmentFilter;

src/Form/Filters/Constraints/BooleanConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 use App\DataTables\Filters\Constraints\BooleanConstraint;

src/Form/Filters/Constraints/ChoiceConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 use App\DataTables\Filters\Constraints\ChoiceConstraint;

src/Form/Filters/Constraints/DateTimeConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 use App\DataTables\Filters\Constraints\DateTimeConstraint;

src/Form/Filters/Constraints/InstanceOfConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 use App\DataTables\Filters\Constraints\InstanceOfConstraint;

src/Form/Filters/Constraints/NumberConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 use App\DataTables\Filters\Constraints\NumberConstraint;

src/Form/Filters/Constraints/ParameterConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 use App\DataTables\Filters\Constraints\Part\ParameterConstraint;

src/Form/Filters/Constraints/ParameterValueConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 class ParameterValueConstraintType extends NumberConstraintType

src/Form/Filters/Constraints/StructuralEntityConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 use App\DataTables\Filters\Constraints\EntityConstraint;

src/Form/Filters/Constraints/TagsConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 use App\DataTables\Filters\Constraints\Part\TagsConstraint;

src/Form/Filters/Constraints/TextConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 use App\DataTables\Filters\Constraints\TextConstraint;

src/Form/Filters/Constraints/UserEntityConstraintType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters\Constraints;
 
 use App\DataTables\Filters\Constraints\EntityConstraint;

src/Form/Filters/LogFilterType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters;
 
 use App\DataTables\Filters\LogFilter;

src/Form/Filters/PartFilterType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Filters;
 
 use App\DataTables\Filters\Constraints\Part\ParameterConstraint;

src/Form/ProjectSystem/ProjectBOMEntryCollectionType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Form\ProjectSystem;
 
 use Symfony\Component\Form\AbstractType;

src/Form/ProjectSystem/ProjectBOMEntryType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Form\ProjectSystem;
 
 use App\Entity\ProjectSystem\ProjectBOMEntry;

src/Form/ProjectSystem/ProjectBuildType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\ProjectSystem;
 
 use Symfony\Bundle\SecurityBundle\Security;
@@ -153,7 +155,7 @@ class ProjectBuildType extends AbstractType implements DataMapperInterface
             if (!$lot) { //When the user selected "Create new lot", create a new lot
                 $lot = new PartLot();
                 $description = 'Build ' . date('Y-m-d H:i:s');
-                if (!empty($data->getComment())) {
+                if ($data->getComment() !== '') {
                     $description .= ' (' . $data->getComment() . ')';
                 }
                 $lot->setDescription($description);

src/Form/Type/BigDecimalMoneyType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /**
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Type;
 
 use Brick\Math\BigDecimal;

src/Form/Type/BigDecimalNumberType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /**
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Type;
 
 use Brick\Math\BigDecimal;

src/Form/Type/Helper/StructuralEntityChoiceHelper.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Type\Helper;
 
 use App\Entity\Attachments\Attachment;
@@ -82,7 +84,7 @@ class StructuralEntityChoiceHelper
             ;
         }
 
-        if ($choice instanceof AttachmentType && !empty($choice->getFiletypeFilter())) {
+        if ($choice instanceof AttachmentType && $choice->getFiletypeFilter() !== '') {
             $tmp += ['data-filetype_filter' => $choice->getFiletypeFilter()];
         }
 
@@ -96,7 +98,7 @@ class StructuralEntityChoiceHelper
     public function generateChoiceAttrCurrency(Currency $choice, Options|array $options): array
     {
         $tmp = $this->generateChoiceAttr($choice, $options);
-        $symbol = empty($choice->getIsoCode()) ? null : Currencies::getSymbol($choice->getIsoCode());
+        $symbol = $choice->getIsoCode() === null || $choice->getIsoCode() === '' ? null : Currencies::getSymbol($choice->getIsoCode());
         $tmp['data-short'] = $options['short'] ? $symbol : $choice->getName();
 
         return $tmp + [

src/Form/Type/Helper/StructuralEntityChoiceLoader.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Type\Helper;
 
 use App\Repository\StructuralDBElementRepository;

src/Form/Type/PartLotSelectType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Type;
 
 use App\Entity\Parts\Storelocation;

src/Form/Type/PartSelectType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Form\Type;
 
 use App\Entity\Attachments\Attachment;

src/Form/Type/RichTextEditorType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Type;
 
 use Symfony\Component\Form\AbstractType;

src/Form/Type/ThemeChoiceType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Type;
 
 use Symfony\Component\Form\AbstractType;

src/Form/Type/UserSelectType.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Form\Type;
 
 use App\Entity\UserSystem\User;

src/Helpers/Projects/ProjectBuildRequest.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Helpers\Projects;
 
 use App\Entity\Parts\Part;

src/Helpers/Trees/TreeViewNodeIterator.php

@@ -40,7 +40,7 @@ final class TreeViewNodeIterator extends ArrayIterator implements RecursiveItera
         /** @var TreeViewNode $element */
         $element = $this->current();
 
-        return !empty($element->getNodes());
+        return $element->getNodes() !== null && $element->getNodes() !== [];
     }
 
     public function getChildren(): TreeViewNodeIterator

src/Kernel.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App;
 
 use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;

src/Migration/AbstractMultiPlatformMigration.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /*
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  *  You should have received a copy of the GNU Affero General Public License
  *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Migration;
 
 use Doctrine\DBAL\Connection;
@@ -88,7 +90,7 @@ abstract class AbstractMultiPlatformMigration extends AbstractMigration
      */
     public function getInitalAdminPW(): string
     {
-        if (empty($this->admin_pw)) {
+        if ($this->admin_pw === '') {
             if (!empty($_ENV['INITIAL_ADMIN_PW'])) {
                 $this->admin_pw = $_ENV['INITIAL_ADMIN_PW'];
             } else {
@@ -104,7 +106,7 @@ abstract class AbstractMultiPlatformMigration extends AbstractMigration
     {
         parent::postUp($schema);
 
-        if (!empty($this->admin_pw)) {
+        if ($this->admin_pw !== '') {
             $this->logger->warning('');
             $this->logger->warning('<bg=yellow;fg=black>The initial password for the "admin" user is: '.$this->admin_pw.'</>');
             $this->logger->warning('');

src/Repository/AbstractPartsContainingRepository.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /**
  * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
  *
@@ -17,7 +20,6 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
-
 namespace App\Repository;
 
 use App\Entity\Base\AbstractPartsContainingDBElement;