Fixed some inspection issues.

src/Controller/AdminPages/BaseAdminController.php

@@ -65,6 +65,7 @@ use App\Services\LogSystem\EventCommentHelper;
 use App\Services\LogSystem\HistoryHelper;
 use App\Services\LogSystem\TimeTravel;
 use App\Services\StructuralElementRecursionHelper;
+use DateTime;
 use Doctrine\ORM\EntityManagerInterface;
 use InvalidArgumentException;
 use Omines\DataTablesBundle\DataTableFactory;
@@ -77,7 +78,6 @@ use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface;
-use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;
 use Symfony\Component\Validator\ConstraintViolationList;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
@@ -138,17 +138,17 @@ abstract class BaseAdminController extends AbstractController
         $this->entityManager = $entityManager;
     }
 
-    protected function revertElementIfNeeded(AbstractDBElement $entity, ?string $timestamp): ?\DateTime
+    protected function revertElementIfNeeded(AbstractDBElement $entity, ?string $timestamp): ?DateTime
     {
         if (null !== $timestamp) {
             $this->denyAccessUnlessGranted('@tools.timetravel');
             $this->denyAccessUnlessGranted('show_history', $entity);
             //If the timestamp only contains numbers interpret it as unix timestamp
             if (ctype_digit($timestamp)) {
-                $timeTravel_timestamp = new \DateTime();
+                $timeTravel_timestamp = new DateTime();
                 $timeTravel_timestamp->setTimestamp((int) $timestamp);
             } else { //Try to parse it via DateTime
-                $timeTravel_timestamp = new \DateTime($timestamp);
+                $timeTravel_timestamp = new DateTime($timestamp);
             }
             $this->timeTravel->revertEntityToTimestamp($entity, $timeTravel_timestamp);
 
@@ -433,7 +433,8 @@ abstract class BaseAdminController extends AbstractController
         $this->denyAccessUnlessGranted('delete', $entity);
 
         if ($this->isCsrfTokenValid('delete'.$entity->getId(), $request->request->get('_token'))) {
-            $entityManager = $this->getDoctrine()->getManager();
+
+            $entityManager = $this->entityManager;
 
             if (!$this->deleteCheck($entity)) {
                 return $this->redirectToRoute($this->route_base.'_edit', ['id' => $entity->getID()]);

src/Controller/AdminPages/CurrencyController.php

@@ -68,7 +68,6 @@ use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface;
 use Symfony\Component\Routing\Annotation\Route;
-use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
 /**

src/Controller/AdminPages/FootprintController.php

@@ -51,6 +51,7 @@ use App\Services\EntityExporter;
 use App\Services\EntityImporter;
 use App\Services\StructuralElementRecursionHelper;
 use Doctrine\ORM\EntityManagerInterface;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
@@ -70,7 +71,7 @@ class FootprintController extends BaseAdminController
     /**
      * @Route("/{id}", name="footprint_delete", methods={"DELETE"})
      */
-    public function delete(Request $request, Footprint $entity, StructuralElementRecursionHelper $recursionHelper): \Symfony\Component\HttpFoundation\RedirectResponse
+    public function delete(Request $request, Footprint $entity, StructuralElementRecursionHelper $recursionHelper): RedirectResponse
     {
         return $this->_delete($request, $entity, $recursionHelper);
     }

src/Controller/AdminPages/LabelProfileController.php

@@ -55,8 +55,6 @@ use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
-use Symfony\Component\Security\Http\Authenticator\AbstractPreAuthenticatedAuthenticator;
-
 /**
  * @Route("/label_profile")
  */

src/Controller/AdminPages/ManufacturerController.php

@@ -50,6 +50,7 @@ use App\Services\EntityExporter;
 use App\Services\EntityImporter;
 use App\Services\StructuralElementRecursionHelper;
 use Doctrine\ORM\EntityManagerInterface;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
@@ -69,9 +70,9 @@ class ManufacturerController extends BaseAdminController
     /**
      * @Route("/{id}", name="manufacturer_delete", methods={"DELETE"})
      *
-     * @return \Symfony\Component\HttpFoundation\RedirectResponse
+     * @return RedirectResponse
      */
-    public function delete(Request $request, Manufacturer $entity, StructuralElementRecursionHelper $recursionHelper): \Symfony\Component\HttpFoundation\RedirectResponse
+    public function delete(Request $request, Manufacturer $entity, StructuralElementRecursionHelper $recursionHelper): RedirectResponse
     {
         return $this->_delete($request, $entity, $recursionHelper);
     }

src/Controller/AdminPages/MeasurementUnitController.php

@@ -51,6 +51,7 @@ use App\Services\EntityExporter;
 use App\Services\EntityImporter;
 use App\Services\StructuralElementRecursionHelper;
 use Doctrine\ORM\EntityManagerInterface;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
@@ -70,7 +71,7 @@ class MeasurementUnitController extends BaseAdminController
     /**
      * @Route("/{id}", name="measurement_unit_delete", methods={"DELETE"})
      */
-    public function delete(Request $request, MeasurementUnit $entity, StructuralElementRecursionHelper $recursionHelper): \Symfony\Component\HttpFoundation\RedirectResponse
+    public function delete(Request $request, MeasurementUnit $entity, StructuralElementRecursionHelper $recursionHelper): RedirectResponse
     {
         return $this->_delete($request, $entity, $recursionHelper);
     }

src/Controller/LabelController.php

@@ -33,6 +33,7 @@ use App\Services\ElementTypeNameGenerator;
 use App\Services\LabelSystem\LabelGenerator;
 use App\Services\Misc\RangeParser;
 use Doctrine\ORM\EntityManagerInterface;
+use InvalidArgumentException;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\Form\FormError;
 use Symfony\Component\HttpFoundation\Request;
@@ -146,7 +147,7 @@ class LabelController extends AbstractController
     protected function findObjects(string $type, string $ids): array
     {
         if (!isset(LabelGenerator::CLASS_SUPPORT_MAPPING[$type])) {
-            throw new \InvalidArgumentException('The given type is not known and can not be mapped to a class!');
+            throw new InvalidArgumentException('The given type is not known and can not be mapped to a class!');
         }
 
         $id_array = $this->rangeParser->parse($ids);

src/Controller/LogController.php

@@ -52,9 +52,11 @@ use App\Entity\LogSystem\ElementEditedLogEntry;
 use App\Services\LogSystem\EventUndoHelper;
 use App\Services\LogSystem\TimeTravel;
 use Doctrine\ORM\EntityManagerInterface;
+use InvalidArgumentException;
 use Omines\DataTablesBundle\DataTableFactory;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
@@ -99,7 +101,7 @@ class LogController extends AbstractController
     /**
      * @Route("/undo", name="log_undo", methods={"POST"})
      */
-    public function undoRevertLog(Request $request, EventUndoHelper $eventUndoHelper): \Symfony\Component\HttpFoundation\RedirectResponse
+    public function undoRevertLog(Request $request, EventUndoHelper $eventUndoHelper): RedirectResponse
     {
         $mode = EventUndoHelper::MODE_UNDO;
         $id = $request->request->get('undo');
@@ -112,7 +114,7 @@ class LogController extends AbstractController
 
         $log_element = $this->entityManager->find(AbstractLogEntry::class, $id);
         if (null === $log_element) {
-            throw new \InvalidArgumentException('No log entry with the given ID is existing!');
+            throw new InvalidArgumentException('No log entry with the given ID is existing!');
         }
 
         $this->denyAccessUnlessGranted('revert_element', $log_element->getTargetClass());

src/Controller/PartController.php

@@ -60,7 +60,9 @@ use App\Services\LogSystem\HistoryHelper;
 use App\Services\LogSystem\TimeTravel;
 use App\Services\Parameters\ParameterExtractor;
 use App\Services\PricedetailHelper;
+use DateTime;
 use Doctrine\ORM\EntityManagerInterface;
+use Exception;
 use Omines\DataTablesBundle\DataTableFactory;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\Form\FormInterface;
@@ -91,7 +93,7 @@ class PartController extends AbstractController
      * @Route("/{id}/info/{timestamp}", name="part_info")
      * @Route("/{id}", requirements={"id"="\d+"})
      *
-     * @throws \Exception
+     * @throws Exception
      */
     public function show(Part $part, Request $request, TimeTravel $timeTravel, HistoryHelper $historyHelper,
         DataTableFactory $dataTable, ParameterExtractor $parameterExtractor, ?string $timestamp = null): Response
@@ -104,10 +106,10 @@ class PartController extends AbstractController
             $this->denyAccessUnlessGranted('show_history', $part);
             //If the timestamp only contains numbers interpret it as unix timestamp
             if (ctype_digit($timestamp)) {
-                $timeTravel_timestamp = new \DateTime();
+                $timeTravel_timestamp = new DateTime();
                 $timeTravel_timestamp->setTimestamp((int) $timestamp);
             } else { //Try to parse it via DateTime
-                $timeTravel_timestamp = new \DateTime($timestamp);
+                $timeTravel_timestamp = new DateTime($timestamp);
             }
             $timeTravel->revertEntityToTimestamp($part, $timeTravel_timestamp);
         }
@@ -199,12 +201,11 @@ class PartController extends AbstractController
     /**
      * @Route("/{id}/delete", name="part_delete", methods={"DELETE"})
      */
-    public function delete(Request $request, Part $part): RedirectResponse
+    public function delete(Request $request, Part $part, EntityManagerInterface $entityManager): RedirectResponse
     {
         $this->denyAccessUnlessGranted('delete', $part);
 
         if ($this->isCsrfTokenValid('delete'.$part->getId(), $request->request->get('_token'))) {
-            $entityManager = $this->getDoctrine()->getManager();
 
             $this->commentHelper->setMessage($request->request->get('log_comment', null));
 

src/Controller/ScanController.php

@@ -27,6 +27,7 @@ use App\Form\LabelSystem\ScanDialogType;
 use App\Services\LabelSystem\Barcodes\BarcodeNormalizer;
 use App\Services\LabelSystem\Barcodes\BarcodeRedirector;
 use Doctrine\ORM\EntityNotFoundException;
+use InvalidArgumentException;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
@@ -67,7 +68,7 @@ class ScanController extends AbstractController
                 } catch (EntityNotFoundException $exception) {
                     $this->addFlash('success', 'scan.qr_not_found');
                 }
-            } catch (\InvalidArgumentException $exception) {
+            } catch (InvalidArgumentException $exception) {
                 $this->addFlash('error', 'scan.format_unknown');
             }
         }

src/Controller/SecurityController.php

@@ -55,7 +55,9 @@ use Symfony\Component\Form\Extension\Core\Type\PasswordType;
 use Symfony\Component\Form\Extension\Core\Type\RepeatedType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
 use Symfony\Component\Routing\Annotation\Route;
 use Symfony\Component\Security\Http\Authentication\AuthenticationUtils;
@@ -78,7 +80,7 @@ class SecurityController extends AbstractController
     /**
      * @Route("/login", name="login", methods={"GET", "POST"})
      */
-    public function login(AuthenticationUtils $authenticationUtils): \Symfony\Component\HttpFoundation\Response
+    public function login(AuthenticationUtils $authenticationUtils): Response
     {
         // get the login error if there is one
         $error = $authenticationUtils->getLastAuthenticationError();
@@ -95,7 +97,7 @@ class SecurityController extends AbstractController
     /**
      * @Route("/pw_reset/request", name="pw_reset_request")
      *
-     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
+     * @return RedirectResponse|Response
      */
     public function requestPwReset(PasswordResetManager $passwordReset, Request $request)
     {
@@ -139,7 +141,7 @@ class SecurityController extends AbstractController
     /**
      * @Route("/pw_reset/new_pw/{user}/{token}", name="pw_reset_new_pw")
      *
-     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
+     * @return RedirectResponse|Response
      */
     public function pwResetNewPw(PasswordResetManager $passwordReset, Request $request, EntityManagerInterface $em, EventDispatcherInterface $eventDispatcher, ?string $user = null, ?string $token = null)
     {

src/Controller/UserController.php

@@ -55,6 +55,7 @@ use App\Services\EntityExporter;
 use App\Services\EntityImporter;
 use App\Services\StructuralElementRecursionHelper;
 use Doctrine\ORM\EntityManagerInterface;
+use Exception;
 use InvalidArgumentException;
 use Omines\DataTablesBundle\DataTableFactory;
 use Symfony\Component\Asset\Packages;
@@ -98,7 +99,7 @@ class UserController extends AdminPages\BaseAdminController
      * @Route("/{id}/edit/{timestamp}", requirements={"id"="\d+"}, name="user_edit")
      * @Route("/{id}/", requirements={"id"="\d+"})
      *
-     * @throws \Exception
+     * @throws Exception
      */
     public function edit(User $entity, Request $request, EntityManagerInterface $em, ?string $timestamp = null): Response
     {

src/Controller/UserSettingsController.php

@@ -62,9 +62,9 @@ use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\Form\FormFactoryInterface;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface;
 use Symfony\Component\Routing\Annotation\Route;
-use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;
 use Symfony\Component\Security\Core\Validator\Constraints\UserPassword;
 use Symfony\Component\Validator\Constraints\Length;
 
@@ -199,7 +199,7 @@ class UserSettingsController extends AbstractController
     /**
      * @Route("/settings", name="user_settings")
      *
-     * @return RedirectResponse|\Symfony\Component\HttpFoundation\Response
+     * @return RedirectResponse|Response
      */
     public function userSettings(Request $request, EntityManagerInterface $em, UserPasswordHasherInterface $passwordEncoder, GoogleAuthenticator $googleAuthenticator, BackupCodeManager $backupCodeManager, FormFactoryInterface $formFactory)
     {