From 4b88de931658ee9ab02901cdc399a8d15405d362 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20B=C3=B6hmer?= <mail@jan-boehmer.de>
Date: Sat, 25 Nov 2023 00:42:17 +0100
Subject: [PATCH] Show a notice above the permission editor, that permissions
 can depend on each other

Related to issue #435
---
 src/Form/Permissions/PermissionsType.php   | 4 ++++
 templates/form/permission_layout.html.twig | 4 ++++
 translations/messages.en.xlf               | 6 ++++++
 3 files changed, 14 insertions(+)

diff --git a/src/Form/Permissions/PermissionsType.php b/src/Form/Permissions/PermissionsType.php
index b0c7ba9d..c0fbb4e8 100644
--- a/src/Form/Permissions/PermissionsType.php
+++ b/src/Form/Permissions/PermissionsType.php
@@ -45,6 +45,9 @@ class PermissionsType extends AbstractType
         $resolver->setDefaults([
             'show_legend' => true,
             'show_presets' => false,
+            'show_dependency_notice' => static function (Options $options) {
+                return !$options['disabled'];
+            },
             'constraints' => static function (Options $options) {
                 if (!$options['disabled']) {
                     return [new NoLockout()];
@@ -60,6 +63,7 @@ class PermissionsType extends AbstractType
     {
         $view->vars['show_legend'] = $options['show_legend'];
         $view->vars['show_presets'] = $options['show_presets'];
+        $view->vars['show_dependency_notice'] = $options['show_dependency_notice'];
     }
 
     public function buildForm(FormBuilderInterface $builder, array $options): void
diff --git a/templates/form/permission_layout.html.twig b/templates/form/permission_layout.html.twig
index 1e36b428..166147b4 100644
--- a/templates/form/permission_layout.html.twig
+++ b/templates/form/permission_layout.html.twig
@@ -89,6 +89,10 @@
         {% endif %}
     </div>
 
+    {% if show_dependency_notice %}
+        <small class="text-muted mb-1 d-inline-block">{% trans %}permission.legend.dependency_note{% endtrans %}</small>
+    {% endif %}
+
     <ul class="nav nav-tabs">
         {% for group in form %}
             <li class="nav-item">
diff --git a/translations/messages.en.xlf b/translations/messages.en.xlf
index 118a2098..b00cd143 100644
--- a/translations/messages.en.xlf
+++ b/translations/messages.en.xlf
@@ -12047,5 +12047,11 @@ Please note, that you can not impersonate a disabled user. If you try you will g
         <target>Permissions required by other permissions were missing. This was corrected. Please check if the permissions are as you intended.</target>
       </segment>
     </unit>
+    <unit id="gjo2ZK7" name="permission.legend.dependency_note">
+      <segment>
+        <source>permission.legend.dependency_note</source>
+        <target>Please note that some permission operations depend on each other. If you encounter a warning that missing permissions were corrected and a permission was set to allow again, you have to set the dependent operation to forbid too. The dependents can normally found right of an operation.</target>
+      </segment>
+    </unit>
   </file>
 </xliff>