From 467687fd0f91059985fa067e1fa5a5e2de120067 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20B=C3=B6hmer?= <mail@jan-boehmer.de>
Date: Sun, 11 Sep 2022 23:41:31 +0200
Subject: [PATCH] Make filters work on default MySQL servers to by removing the
 ONLY_FULL_GROUP_BY sql mode

---
 .../SetSQLMode/SetSQLModeMiddlewareDriver.php | 24 +++++++++++++++++++
 .../SetSQLModeMiddlewareWrapper.php           | 18 ++++++++++++++
 2 files changed, 42 insertions(+)
 create mode 100644 src/Doctrine/SetSQLMode/SetSQLModeMiddlewareDriver.php
 create mode 100644 src/Doctrine/SetSQLMode/SetSQLModeMiddlewareWrapper.php

diff --git a/src/Doctrine/SetSQLMode/SetSQLModeMiddlewareDriver.php b/src/Doctrine/SetSQLMode/SetSQLModeMiddlewareDriver.php
new file mode 100644
index 00000000..ac36827c
--- /dev/null
+++ b/src/Doctrine/SetSQLMode/SetSQLModeMiddlewareDriver.php
@@ -0,0 +1,24 @@
+<?php
+
+namespace App\Doctrine\SetSQLMode;
+
+use Doctrine\DBAL\Driver\Middleware\AbstractDriverMiddleware;
+use Doctrine\DBAL\Platforms\AbstractMySQLPlatform;
+
+/**
+ * This command sets the initial command parameter for MySQL connections, so we can set the SQL mode
+ * We use this to disable the ONLY_FULL_GROUP_BY mode, which is enabled by default in MySQL 5.7.5 and higher and causes problems with our filters
+ */
+class SetSQLModeMiddlewareDriver extends AbstractDriverMiddleware
+{
+    public function connect(array $params): \Doctrine\DBAL\Driver\Connection
+    {
+        //Only set this on MySQL connections, as other databases don't support this parameter
+        if($this->getDatabasePlatform() instanceof AbstractMySQLPlatform) {
+            //1002 is \PDO::MYSQL_ATTR_INIT_COMMAND constant value
+            $params['driverOptions'][1002] = 'SET SESSION sql_mode=(SELECT REPLACE(@@sql_mode, \'ONLY_FULL_GROUP_BY\', \'\'))';
+        }
+
+        return parent::connect($params);
+    }
+}
\ No newline at end of file
diff --git a/src/Doctrine/SetSQLMode/SetSQLModeMiddlewareWrapper.php b/src/Doctrine/SetSQLMode/SetSQLModeMiddlewareWrapper.php
new file mode 100644
index 00000000..4dd32875
--- /dev/null
+++ b/src/Doctrine/SetSQLMode/SetSQLModeMiddlewareWrapper.php
@@ -0,0 +1,18 @@
+<?php
+
+namespace App\Doctrine\SetSQLMode;
+
+use Doctrine\DBAL\Driver;
+use Doctrine\DBAL\Driver\Middleware;
+
+/**
+ * This class wraps the Doctrine DBAL driver and wraps it into an Midleware driver so we can change the SQL mode
+ */
+class SetSQLModeMiddlewareWrapper implements Middleware
+{
+
+    public function wrap(Driver $driver): Driver
+    {
+        return new SetSQLModeMiddlewareDriver($driver);
+    }
+}
\ No newline at end of file