Fixed access to typeahead controllers.

This commit is contained in:
Jan Böhmer 2022-11-09 23:33:50 +01:00
parent 5e06557cf0
commit 41450b8bd3
2 changed files with 103 additions and 1 deletions

View file

@ -106,7 +106,7 @@ class AttachmentVoter extends ExtendedVoter
{
if (is_a($subject, Attachment::class, true)) {
//These are the allowed attributes
return in_array($attribute, ['view', 'edit', 'delete', 'create', 'show_private'], true);
return in_array($attribute, ['read', 'view', 'edit', 'delete', 'create', 'show_private'], true);
}
//Allow class name as subject

View file

@ -0,0 +1,102 @@
<?php
namespace App\Security\Voter;
use App\Entity\Attachments\CategoryAttachment;
use App\Entity\Attachments\CurrencyAttachment;
use App\Entity\Parameters\AbstractParameter;
use App\Entity\Parameters\AttachmentTypeParameter;
use App\Entity\Parameters\CategoryParameter;
use App\Entity\Parameters\CurrencyParameter;
use App\Entity\Parameters\DeviceParameter;
use App\Entity\Parameters\FootprintParameter;
use App\Entity\Parameters\GroupParameter;
use App\Entity\Parameters\ManufacturerParameter;
use App\Entity\Parameters\MeasurementUnitParameter;
use App\Entity\Parameters\PartParameter;
use App\Entity\Parameters\StorelocationParameter;
use App\Entity\Parameters\SupplierParameter;
use App\Entity\PriceInformations\Currency;
use App\Entity\UserSystem\User;
use App\Services\PermissionResolver;
use Doctrine\ORM\EntityManagerInterface;
use PHPUnit\TextUI\RuntimeException;
use Symfony\Component\Security\Core\Security;
class ParameterVoter extends ExtendedVoter
{
protected Security $security;
public function __construct(PermissionResolver $resolver, EntityManagerInterface $entityManager, Security $security)
{
$this->security = $security;
parent::__construct($resolver, $entityManager);
}
protected function voteOnUser(string $attribute, $subject, User $user): bool
{
//return $this->resolver->inherit($user, 'attachments', $attribute) ?? false;
if (!$subject instanceof AbstractParameter) {
return false;
}
//If the attachment has no element (which should not happen), we deny access, as we can not determine if the user is allowed to access the associated element
$target_element = $subject->getElement();
if ($target_element !== null) {
//Depending on the operation delegate either to the attachments element or to the attachment permission
switch ($attribute) {
//We can view the attachment if we can view the element
case 'read':
case 'view':
return $this->security->isGranted('read', $target_element);
//We can edit/create/delete the attachment if we can edit the element
case 'edit':
case 'create':
case 'delete':
return $this->security->isGranted('edit', $target_element);
}
}
//If we do not have a concrete element, we delegate to the different categories
if ($subject instanceof AttachmentTypeParameter) {
$param = 'attachment_types';
} elseif ($subject instanceof CategoryParameter) {
$param = 'categories';
} elseif ($subject instanceof CurrencyParameter) {
$param = 'currencies';
} elseif ($subject instanceof DeviceParameter) {
$param = 'devices';
} elseif ($subject instanceof FootprintParameter) {
$param = 'footprints';
} elseif ($subject instanceof GroupParameter) {
$param = 'groups';
} elseif ($subject instanceof ManufacturerParameter) {
$param = 'manufacturers';
} elseif ($subject instanceof MeasurementUnitParameter) {
$param = 'measurement_units';
} elseif ($subject instanceof PartParameter) {
$param = 'parts';
} elseif ($subject instanceof StorelocationParameter) {
$param = 'storelocations';
} elseif ($subject instanceof SupplierParameter) {
$param = 'suppliers';
} else {
throw new RuntimeException('Encountered unknown Parameter type: ' . get_class($subject));
}
return $this->resolver->inherit($user, $param, $attribute) ?? false;
}
protected function supports(string $attribute, $subject)
{
if (is_a($subject, AbstractParameter::class, true)) {
//These are the allowed attributes
return in_array($attribute, ['read', 'edit', 'delete', 'create'], true);
}
//Allow class name as subject
return false;
}
}