Applied symplify rules to codebase.

src/Form/AdminPages/AttachmentTypeAdminForm.php

@@ -46,12 +46,16 @@ class AttachmentTypeAdminForm extends BaseEntityAdminForm
     {
         $is_new = null === $entity->getID();
 
-        $builder->add('filetype_filter', TextType::class, ['required' => false,
+        $builder->add('filetype_filter', TextType::class, [
+            'required' => false,
             'label' => 'attachment_type.edit.filetype_filter',
             'help' => 'attachment_type.edit.filetype_filter.help',
-            'attr' => ['placeholder' => 'attachment_type.edit.filetype_filter.placeholder'],
+            'attr' => [
+                'placeholder' => 'attachment_type.edit.filetype_filter.placeholder',
+            ],
             'empty_data' => '',
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
         //Normalize data before writing it to database
         $builder->get('filetype_filter')->addViewTransformer(new CallbackTransformer(

src/Form/AdminPages/BaseEntityAdminForm.php

@@ -31,6 +31,7 @@ use App\Form\AttachmentFormType;
 use App\Form\Type\MasterPictureAttachmentType;
 use App\Form\Type\StructuralEntityType;
 use FOS\CKEditorBundle\Form\Type\CKEditorType;
+use function get_class;
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
@@ -66,24 +67,42 @@ class BaseEntityAdminForm extends AbstractType
         $is_new = null === $entity->getID();
 
         $builder
-            ->add('name', TextType::class, ['empty_data' => '', 'label' => 'name.label',
-                'attr' => ['placeholder' => 'part.name.placeholder'],
-                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ])
+            ->add('name', TextType::class, [
+                'empty_data' => '',
+                'label' => 'name.label',
+                'attr' => [
+                    'placeholder' => 'part.name.placeholder',
+                ],
+                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+            ])
 
-            ->add('parent', StructuralEntityType::class, ['class' => \get_class($entity),
-                'required' => false, 'label' => 'parent.label',
-                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity), ])
+            ->add('parent', StructuralEntityType::class, [
+                'class' => get_class($entity),
+                'required' => false,
+                'label' => 'parent.label',
+                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
+            ])
 
-            ->add('not_selectable', CheckboxType::class, ['required' => false,
+            ->add('not_selectable', CheckboxType::class, [
+                'required' => false,
                 'label' => 'entity.edit.not_selectable',
                 'help' => 'entity.edit.not_selectable.help',
-                'label_attr' => ['class' => 'checkbox-custom'],
-                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ])
+                'label_attr' => [
+                    'class' => 'checkbox-custom',
+                ],
+                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+            ])
 
-            ->add('comment', CKEditorType::class, ['required' => false, 'empty_data' => '',
+            ->add('comment', CKEditorType::class, [
+                'required' => false,
+                'empty_data' => '',
                 'label' => 'comment.label',
-                'attr' => ['rows' => 4], 'help' => 'bbcode.hint',
-                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+                'attr' => [
+                    'rows' => 4,
+                ],
+                'help' => 'bbcode.hint',
+                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+            ]);
 
         $this->additionalFormElements($builder, $options, $entity);
 
@@ -110,10 +129,15 @@ class BaseEntityAdminForm extends AbstractType
         //Buttons
         $builder->add('save', SubmitType::class, [
             'label' => $is_new ? 'entity.create' : 'entity.edit.save',
-            'attr' => ['class' => $is_new ? 'btn-success' : ''],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ])
-            ->add('reset', ResetType::class, ['label' => 'entity.edit.reset',
-                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'attr' => [
+                'class' => $is_new ? 'btn-success' : '',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ])
+            ->add('reset', ResetType::class, [
+                'label' => 'entity.edit.reset',
+                'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+            ]);
     }
 
     protected function additionalFormElements(FormBuilderInterface $builder, array $options, NamedDBElement $entity): void

src/Form/AdminPages/CategoryAdminForm.php

@@ -35,48 +35,84 @@ class CategoryAdminForm extends BaseEntityAdminForm
     {
         $is_new = null === $entity->getID();
 
-        $builder->add('disable_footprints', CheckboxType::class, ['required' => false,
+        $builder->add('disable_footprints', CheckboxType::class, [
+            'required' => false,
             'label' => 'category.edit.disable_footprints',
             'help' => 'category.edit.disable_footprints.help',
-            'label_attr' => ['class' => 'checkbox-custom'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'label_attr' => [
+                'class' => 'checkbox-custom',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
-        $builder->add('disable_manufacturers', CheckboxType::class, ['required' => false,
+        $builder->add('disable_manufacturers', CheckboxType::class, [
+            'required' => false,
             'label' => 'category.edit.disable_manufacturers',
             'help' => 'category.edit.disable_manufacturers.help',
-            'label_attr' => ['class' => 'checkbox-custom'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'label_attr' => [
+                'class' => 'checkbox-custom',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
-        $builder->add('disable_autodatasheets', CheckboxType::class, ['required' => false,
+        $builder->add('disable_autodatasheets', CheckboxType::class, [
+            'required' => false,
             'label' => 'category.edit.disable_autodatasheets',
             'help' => 'category.edit.disable_autodatasheets.help',
-            'label_attr' => ['class' => 'checkbox-custom'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'label_attr' => [
+                'class' => 'checkbox-custom',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
-        $builder->add('disable_properties', CheckboxType::class, ['required' => false,
+        $builder->add('disable_properties', CheckboxType::class, [
+            'required' => false,
             'label' => 'category.edit.disable_properties',
             'help' => 'category.edit.disable_properties.help',
-            'label_attr' => ['class' => 'checkbox-custom'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'label_attr' => [
+                'class' => 'checkbox-custom',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
-        $builder->add('partname_hint', TextType::class, ['required' => false, 'empty_data' => '',
+        $builder->add('partname_hint', TextType::class, [
+            'required' => false,
+            'empty_data' => '',
             'label' => 'category.edit.partname_hint',
-            'attr' => ['placeholder' => 'category.edit.partname_hint.placeholder'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'attr' => [
+                'placeholder' => 'category.edit.partname_hint.placeholder',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
-        $builder->add('partname_regex', TextType::class, ['required' => false, 'empty_data' => '',
+        $builder->add('partname_regex', TextType::class, [
+            'required' => false,
+            'empty_data' => '',
             'label' => 'category.edit.partname_regex',
-            'attr' => ['placeholder' => 'category.edit.partname_regex.placeholder'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'attr' => [
+                'placeholder' => 'category.edit.partname_regex.placeholder',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
-        $builder->add('default_description', TextType::class, ['required' => false, 'empty_data' => '',
+        $builder->add('default_description', TextType::class, [
+            'required' => false,
+            'empty_data' => '',
             'label' => 'category.edit.default_description',
-            'attr' => ['placeholder' => 'category.edit.default_description.placeholder'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'attr' => [
+                'placeholder' => 'category.edit.default_description.placeholder',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
-        $builder->add('default_comment', TextType::class, ['required' => false, 'empty_data' => '',
+        $builder->add('default_comment', TextType::class, [
+            'required' => false,
+            'empty_data' => '',
             'label' => 'category.edit.default_comment',
-            'attr' => ['placeholder' => 'category.edit.default_comment.placeholder'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'attr' => [
+                'placeholder' => 'category.edit.default_comment.placeholder',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
     }
 }

src/Form/AdminPages/CompanyForm.php

@@ -40,14 +40,19 @@ class CompanyForm extends BaseEntityAdminForm
         $builder->add('address', TextareaType::class, [
             'label' => 'company.edit.address',
             'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
-            'attr' => ['placeholder' => 'company.edit.address.placeholder'], 'required' => false,
+            'attr' => [
+                'placeholder' => 'company.edit.address.placeholder',
+            ],
+            'required' => false,
             'empty_data' => '',
         ]);
 
         $builder->add('phone_number', TelType::class, [
             'label' => 'company.edit.phone_number',
             'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
-            'attr' => ['placeholder' => 'company.edit.phone_number.placeholder'],
+            'attr' => [
+                'placeholder' => 'company.edit.phone_number.placeholder',
+            ],
             'required' => false,
             'empty_data' => '',
         ]);
@@ -55,21 +60,30 @@ class CompanyForm extends BaseEntityAdminForm
         $builder->add('fax_number', TelType::class, [
             'label' => 'company.edit.fax_number',
             'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
-            'attr' => ['placeholder' => 'company.fax_number.placeholder'], 'required' => false,
+            'attr' => [
+                'placeholder' => 'company.fax_number.placeholder',
+            ],
+            'required' => false,
             'empty_data' => '',
         ]);
 
         $builder->add('email_address', EmailType::class, [
             'label' => 'company.edit.email',
             'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
-            'attr' => ['placeholder' => 'company.edit.email.placeholder'], 'required' => false,
+            'attr' => [
+                'placeholder' => 'company.edit.email.placeholder',
+            ],
+            'required' => false,
             'empty_data' => '',
         ]);
 
         $builder->add('website', UrlType::class, [
             'label' => 'company.edit.website',
             'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
-            'attr' => ['placeholder' => 'company.edit.website.placeholder'], 'required' => false,
+            'attr' => [
+                'placeholder' => 'company.edit.website.placeholder',
+            ],
+            'required' => false,
             'empty_data' => '',
         ]);
 
@@ -77,7 +91,9 @@ class CompanyForm extends BaseEntityAdminForm
             'label' => 'company.edit.auto_product_url',
             'help' => 'company.edit.auto_product_url.help',
             'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
-            'attr' => ['placeholder' => 'company.edit.auto_product_url.placeholder'],
+            'attr' => [
+                'placeholder' => 'company.edit.auto_product_url.placeholder',
+            ],
             'required' => false,
             'empty_data' => '',
         ]);

src/Form/AdminPages/CurrencyAdminForm.php

@@ -39,14 +39,19 @@ class CurrencyAdminForm extends BaseEntityAdminForm
             'required' => false,
             'label' => 'currency.edit.iso_code',
             'preferred_choices' => ['EUR', 'USD', 'GBP', 'JPY', 'CNY'],
-            'attr' => ['class' => 'selectpicker', 'data-live-search' => true],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'attr' => [
+                'class' => 'selectpicker',
+                'data-live-search' => true,
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
         $builder->add('exchange_rate', MoneyType::class, [
             'required' => false,
             'label' => 'currency.edit.exchange_rate',
             'currency' => $this->params->get('default_currency'),
             'scale' => 6,
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
     }
 }

src/Form/AdminPages/GroupAdminForm.php

@@ -35,10 +35,13 @@ class GroupAdminForm extends BaseEntityAdminForm
     {
         $is_new = null === $entity->getID();
 
-        $builder->add('enforce2FA', CheckboxType::class, ['required' => false,
+        $builder->add('enforce2FA', CheckboxType::class, [
+            'required' => false,
             'label' => 'group.edit.enforce_2fa',
             'help' => 'entity.edit.enforce_2fa.help',
-            'label_attr' => ['class' => 'checkbox-custom'],
+            'label_attr' => [
+                'class' => 'checkbox-custom',
+            ],
             'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
         ]);
 

src/Form/AdminPages/ImportType.php

@@ -56,12 +56,20 @@ class ImportType extends AbstractType
         $builder
 
             ->add('format', ChoiceType::class, [
-                'choices' => ['JSON' => 'json', 'XML' => 'xml', 'CSV' => 'csv', 'YAML' => 'yaml'],
+                'choices' => [
+                    'JSON' => 'json',
+                    'XML' => 'xml',
+                    'CSV' => 'csv',
+                    'YAML' => 'yaml',
+                ],
                 'label' => 'export.format',
-                'disabled' => $disabled, ])
-            ->add('csv_separator', TextType::class, ['data' => ';',
+                'disabled' => $disabled,
+            ])
+            ->add('csv_separator', TextType::class, [
+                'data' => ';',
                 'label' => 'import.csv_separator',
-                'disabled' => $disabled, ]);
+                'disabled' => $disabled,
+            ]);
 
         if ($entity instanceof StructuralDBElement) {
             $builder->add('parent', StructuralEntityType::class, [
@@ -74,19 +82,38 @@ class ImportType extends AbstractType
 
         $builder->add('file', FileType::class, [
             'label' => 'import.file',
-            'attr' => ['class' => 'file', 'data-show-preview' => 'false', 'data-show-upload' => 'false'],
+            'attr' => [
+                'class' => 'file',
+                'data-show-preview' => 'false',
+                'data-show-upload' => 'false',
+            ],
             'disabled' => $disabled,
         ])
 
-            ->add('preserve_children', CheckboxType::class, ['data' => true, 'required' => false,
+            ->add('preserve_children', CheckboxType::class, [
+                'data' => true,
+                'required' => false,
                 'label' => 'import.preserve_children',
-                'label_attr' => ['class' => 'checkbox-custom'], 'disabled' => $disabled, ])
-            ->add('abort_on_validation_error', CheckboxType::class, ['data' => true, 'required' => false,
+                'label_attr' => [
+                    'class' => 'checkbox-custom',
+                ],
+                'disabled' => $disabled,
+            ])
+            ->add('abort_on_validation_error', CheckboxType::class, [
+                'data' => true,
+                'required' => false,
                 'label' => 'import.abort_on_validation',
                 'help' => 'import.abort_on_validation.help',
-                'label_attr' => ['class' => 'checkbox-custom'], 'disabled' => $disabled, ])
+                'label_attr' => [
+                    'class' => 'checkbox-custom',
+                ],
+                'disabled' => $disabled,
+            ])
 
             //Buttons
-            ->add('import', SubmitType::class, ['label' => 'import.btn', 'disabled' => $disabled]);
+            ->add('import', SubmitType::class, [
+                'label' => 'import.btn',
+                'disabled' => $disabled,
+            ]);
     }
 }

src/Form/AdminPages/MassCreationForm.php

@@ -51,9 +51,11 @@ class MassCreationForm extends AbstractType
         $disabled = ! $this->security->isGranted($perm_name, $entity);
 
         $builder
-            ->add('lines', TextareaType::class, ['data' => '',
+            ->add('lines', TextareaType::class, [
+                'data' => '',
                 'label' => 'mass_creation.lines',
-                'disabled' => $disabled, 'required' => true,
+                'disabled' => $disabled,
+                'required' => true,
                 'attr' => [
                     'placeholder' => 'mass_creation.lines.placeholder',
                     'rows' => 10,
@@ -64,7 +66,8 @@ class MassCreationForm extends AbstractType
                 'class' => $data['entity_class'],
                 'required' => false,
                 'label' => 'parent.label',
-                'disabled' => $disabled, ]);
+                'disabled' => $disabled,
+            ]);
         }
 
         //Buttons

src/Form/AdminPages/MeasurementUnitAdminForm.php

@@ -35,21 +35,33 @@ class MeasurementUnitAdminForm extends BaseEntityAdminForm
     {
         $is_new = null === $entity->getID();
 
-        $builder->add('is_integer', CheckboxType::class, ['required' => false,
+        $builder->add('is_integer', CheckboxType::class, [
+            'required' => false,
             'label' => 'measurement_unit.edit.is_integer',
             'help' => 'measurement_unit.edit.is_integer.help',
-            'label_attr' => ['class' => 'checkbox-custom'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'label_attr' => [
+                'class' => 'checkbox-custom',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
-        $builder->add('use_si_prefix', CheckboxType::class, ['required' => false,
+        $builder->add('use_si_prefix', CheckboxType::class, [
+            'required' => false,
             'label' => 'measurement_unit.edit.use_si_prefix',
             'help' => 'measurement_unit.edit.use_si_prefix.help',
-            'label_attr' => ['class' => 'checkbox-custom'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'label_attr' => [
+                'class' => 'checkbox-custom',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
 
-        $builder->add('unit', TextType::class, ['required' => false,
+        $builder->add('unit', TextType::class, [
+            'required' => false,
             'label' => 'measurement_unit.edit.unit_symbol',
-            'attr' => ['placeholder' => 'measurement_unit.edit.unit_symbol.placeholder'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity), ]);
+            'attr' => [
+                'placeholder' => 'measurement_unit.edit.unit_symbol.placeholder',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'edit', $entity),
+        ]);
     }
 }

src/Form/AdminPages/StorelocationAdminForm.php

@@ -40,28 +40,39 @@ class StorelocationAdminForm extends BaseEntityAdminForm
             'required' => false,
             'label' => 'storelocation.edit.is_full.label',
             'help' => 'storelocation.edit.is_full.help',
-            'label_attr' => ['class' => 'checkbox-custom'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity), ]);
+            'label_attr' => [
+                'class' => 'checkbox-custom',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
+        ]);
 
         $builder->add('limit_to_existing_parts', CheckboxType::class, [
             'required' => false,
             'label' => 'storelocation.limit_to_existing.label',
             'help' => 'storelocation.limit_to_existing.help',
-            'label_attr' => ['class' => 'checkbox-custom'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity), ]);
+            'label_attr' => [
+                'class' => 'checkbox-custom',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
+        ]);
 
         $builder->add('only_single_part', CheckboxType::class, [
             'required' => false,
             'label' => 'storelocation.only_single_part.label',
             'help' => 'storelocation.only_single_part.help',
-            'label_attr' => ['class' => 'checkbox-custom'],
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity), ]);
+            'label_attr' => [
+                'class' => 'checkbox-custom',
+            ],
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
+        ]);
 
         $builder->add('storage_type', StructuralEntityType::class, [
             'required' => false,
             'label' => 'storelocation.storage_type.label',
             'help' => 'storelocation.storage_type.help',
-            'class' => MeasurementUnit::class, 'disable_not_selectable' => true,
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity), ]);
+            'class' => MeasurementUnit::class,
+            'disable_not_selectable' => true,
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
+        ]);
     }
 }

src/Form/AdminPages/SupplierForm.php

@@ -43,7 +43,8 @@ class SupplierForm extends CompanyForm
             'required' => false,
             'label' => 'supplier.edit.default_currency',
             'disable_not_selectable' => true,
-            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity), ]);
+            'disabled' => ! $this->security->isGranted($is_new ? 'create' : 'move', $entity),
+        ]);
 
         $builder->add('shipping_costs', MoneyType::class, [
             'required' => false,