mirror/Part-DB.Part-DB-server
1
0
Fork 1
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2025-06-21 01:25:55 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Implemented proper voters for attachments and parameters, so we can decide access for log details

Browse source
This commit is contained in:
Jan Böhmer 2023-05-27 19:17:27 +02:00
parent 427f6e4d55
commit 379f7ef865
2 changed files with 120 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

83
src/Security/Voter/AttachmentVoter.php
View file

@ -23,9 +23,22 @@ declare(strict_types=1);
namespace App\Security\Voter;
use App\Entity\Attachments\Attachment;
use App\Entity\Attachments\AttachmentTypeAttachment;
use App\Entity\Attachments\CategoryAttachment;
use App\Entity\Attachments\CurrencyAttachment;
use App\Entity\Attachments\FootprintAttachment;
use App\Entity\Attachments\GroupAttachment;
use App\Entity\Attachments\ManufacturerAttachment;
use App\Entity\Attachments\MeasurementUnitAttachment;
use App\Entity\Attachments\PartAttachment;
use App\Entity\Attachments\ProjectAttachment;
use App\Entity\Attachments\StorelocationAttachment;
use App\Entity\Attachments\SupplierAttachment;
use App\Entity\Attachments\UserAttachment;
use App\Entity\UserSystem\User;
use App\Services\UserSystem\PermissionManager;
use Doctrine\ORM\EntityManagerInterface;
use RuntimeException;
use Symfony\Component\Security\Core\Security;
use function in_array;
@ -50,26 +63,76 @@ class AttachmentVoter extends ExtendedVoter
{
//return $this->resolver->inherit($user, 'attachments', $attribute) ?? false;
//If the attachment has no element (which should not happen), we deny access, as we can not determine if the user is allowed to access the associated element
$target_element = $subject->getElement();
if (! $subject instanceof Attachment || null === $target_element) {
//This voter only works for attachments
if (!is_a($subject, Attachment::class, true)) {
return false;
}
//Depending on the operation delegate either to the attachments element or to the attachment permission
if ($attribute === 'show_private') {
return $this->resolver->inherit($user, 'attachments', 'show_private') ?? false;
}
if (is_object($subject)) {
//If the attachment has no element (which should not happen), we deny access, as we can not determine if the user is allowed to access the associated element
$target_element = $subject->getElement();
if ($target_element) {
return $this->security->isGranted($this->mapOperation($attribute), $target_element);
}
}
if (is_string($subject)) {
//If we do not have a concrete element (or we just got a string as value), we delegate to the different categories
if (is_a($subject, AttachmentTypeAttachment::class, true)) {
$param = 'attachment_types';
} elseif (is_a($subject, CategoryAttachment::class, true)) {
$param = 'categories';
} elseif (is_a($subject, CurrencyAttachment::class, true)) {
$param = 'currencies';
} elseif (is_a($subject, ProjectAttachment::class, true)) {
$param = 'projects';
} elseif (is_a($subject, FootprintAttachment::class, true)) {
$param = 'footprints';
} elseif (is_a($subject, GroupAttachment::class, true)) {
$param = 'groups';
} elseif (is_a($subject, ManufacturerAttachment::class, true)) {
$param = 'manufacturers';
} elseif (is_a($subject, MeasurementUnitAttachment::class, true)) {
$param = 'measurement_units';
} elseif (is_a($subject, PartAttachment::class, true)) {
$param = 'parts';
} elseif (is_a($subject, StorelocationAttachment::class, true)) {
$param = 'storelocations';
} elseif (is_a($subject, SupplierAttachment::class, true)) {
$param = 'suppliers';
} elseif (is_a($subject, UserAttachment::class, true)) {
$param = 'users';
} elseif ($subject === Attachment::class) {
//If the subject was deleted, we can not determine the type properly, so we just use the parts permission
$param = 'parts';
}
else {
throw new RuntimeException('Encountered unknown Parameter type: ' . (is_object($subject) ? get_class($subject) : $subject));
}
return $this->resolver->inherit($user, $param, $this->mapOperation($attribute)) ?? false;
}
}
private function mapOperation(string $attribute): string
{
switch ($attribute) {
//We can view the attachment if we can view the element
case 'read':
case 'view':
return $this->security->isGranted('read', $target_element);
return 'read';
//We can edit/create/delete the attachment if we can edit the element
case 'edit':
case 'create':
case 'delete':
return $this->security->isGranted('edit', $target_element);
case 'show_private':
return $this->resolver->inherit($user, 'attachments', 'show_private') ?? false;
return 'edit';
case 'show_history':
return 'show_history';
}
throw new \RuntimeException('Encountered unknown attribute "'.$attribute.'" in AttachmentVoter!');
@ -87,7 +150,7 @@ class AttachmentVoter extends ExtendedVoter
{
if (is_a($subject, Attachment::class, true)) {
//These are the allowed attributes
return in_array($attribute, ['read', 'view', 'edit', 'delete', 'create', 'show_private'], true);
return in_array($attribute, ['read', 'view', 'edit', 'delete', 'create', 'show_private', 'show_history'], true);
}
//Allow class name as subject

36
src/Security/Voter/ParameterVoter.php
View file

@ -53,10 +53,11 @@ class ParameterVoter extends ExtendedVoter
{
//return $this->resolver->inherit($user, 'attachments', $attribute) ?? false;
if (!$subject instanceof AbstractParameter) {
if (!is_a($subject, AbstractParameter::class, true)) {
return false;
}
if (is_object($subject)) {
//If the attachment has no element (which should not happen), we deny access, as we can not determine if the user is allowed to access the associated element
$target_element = $subject->getElement();
if ($target_element !== null) {
@ -87,32 +88,37 @@ class ParameterVoter extends ExtendedVoter
return $this->security->isGranted($operation, $target_element);
}
}
//If we do not have a concrete element, we delegate to the different categories
if ($subject instanceof AttachmentTypeParameter) {
//If we do not have a concrete element (or we just got a string as value), we delegate to the different categories
if (is_a($subject, AttachmentTypeParameter::class, true)) {
$param = 'attachment_types';
} elseif ($subject instanceof CategoryParameter) {
} elseif (is_a($subject, CategoryParameter::class, true)) {
$param = 'categories';
} elseif ($subject instanceof CurrencyParameter) {
} elseif (is_a($subject, CurrencyParameter::class, true)) {
$param = 'currencies';
} elseif ($subject instanceof ProjectParameter) {
} elseif (is_a($subject, ProjectParameter::class, true)) {
$param = 'projects';
} elseif ($subject instanceof FootprintParameter) {
} elseif (is_a($subject, FootprintParameter::class, true)) {
$param = 'footprints';
} elseif ($subject instanceof GroupParameter) {
} elseif (is_a($subject, GroupParameter::class, true)) {
$param = 'groups';
} elseif ($subject instanceof ManufacturerParameter) {
} elseif (is_a($subject, ManufacturerParameter::class, true)) {
$param = 'manufacturers';
} elseif ($subject instanceof MeasurementUnitParameter) {
} elseif (is_a($subject, MeasurementUnitParameter::class, true)) {
$param = 'measurement_units';
} elseif ($subject instanceof PartParameter) {
} elseif (is_a($subject, PartParameter::class, true)) {
$param = 'parts';
} elseif ($subject instanceof StorelocationParameter) {
} elseif (is_a($subject, StorelocationParameter::class, true)) {
$param = 'storelocations';
} elseif ($subject instanceof SupplierParameter) {
} elseif (is_a($subject, SupplierParameter::class, true)) {
$param = 'suppliers';
} else {
throw new RuntimeException('Encountered unknown Parameter type: ' . get_class($subject));
} elseif ($subject === AbstractParameter::class) {
//If the subject was deleted, we can not determine the type properly, so we just use the parts permission
$param = 'parts';
}
else {
throw new RuntimeException('Encountered unknown Parameter type: ' . (is_object($subject) ? get_class($subject) : $subject));
}
return $this->resolver->inherit($user, $param, $attribute) ?? false;