mirror/Part-DB.Part-DB-server
1
0
Fork 1
mirror of https://github.com/Part-DB/Part-DB-server.git synced 2025-06-21 01:25:55 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Only check every 10 minutes if the user needs to setup a 2FA method enforced by its group

Browse source 
That saves us 3 database queries on many requests.
This commit is contained in:
Jan Böhmer 2023-07-19 00:56:28 +02:00
parent 87cf4c2d08
commit 2c6de84c9a
2 changed files with 47 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

28
tests/EventSubscriber/PasswordChangeNeededSubscriberTest.php
View file

@ -27,6 +27,9 @@ use App\Entity\UserSystem\User;
use App\Entity\UserSystem\WebauthnKey;
use App\EventSubscriber\UserSystem\PasswordChangeNeededSubscriber;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
use Symfony\Component\Uid\Uuid;
use Webauthn\TrustPath\EmptyTrustPath;
@ -37,21 +40,33 @@ class PasswordChangeNeededSubscriberTest extends TestCase
$user = new User();
$group = new Group();
$request = new Request();
$session = new Session(new MockArraySessionStorage());
$request->setSession($session);
//A user without a group must not redirect
$user->setGroup(null);
$this->assertFalse(PasswordChangeNeededSubscriber::TFARedirectNeeded($user));
$this->assertFalse(PasswordChangeNeededSubscriber::TFARedirectNeeded($user, $request));
$session->clear();
//When the group does not enforce the redirect the user must not be redirected
$user->setGroup($group);
$this->assertFalse(PasswordChangeNeededSubscriber::TFARedirectNeeded($user));
$this->assertFalse(PasswordChangeNeededSubscriber::TFARedirectNeeded($user, $request));
$session->clear();
//The user must be redirected if the group enforces 2FA, and it does not have a method
$group->setEnforce2FA(true);
$this->assertTrue(PasswordChangeNeededSubscriber::TFARedirectNeeded($user));
$this->assertTrue(PasswordChangeNeededSubscriber::TFARedirectNeeded($user, $request));
$session->clear();
//User must not be redirect if google authenticator is set up
$user->setGoogleAuthenticatorSecret('abcd');
$this->assertFalse(PasswordChangeNeededSubscriber::TFARedirectNeeded($user));
$this->assertFalse(PasswordChangeNeededSubscriber::TFARedirectNeeded($user, $request));
$session->clear();
//User must not be redirect if 2FA is set up
$user->setGoogleAuthenticatorSecret(null);
@ -66,6 +81,9 @@ class PasswordChangeNeededSubscriberTest extends TestCase
"",
0
));
$this->assertFalse(PasswordChangeNeededSubscriber::TFARedirectNeeded($user));
$session->clear();
$this->assertFalse(PasswordChangeNeededSubscriber::TFARedirectNeeded($user, $request));
}
}