From 218b0adb8f068426957ba6d6166483bad1c6f1c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20B=C3=B6hmer?= Date: Sun, 18 Jun 2023 21:20:07 +0200 Subject: [PATCH] Only enable Choice and InstanceOfConstraints if a value is provided --- src/DataTables/Filters/Constraints/ChoiceConstraint.php | 2 +- src/DataTables/Filters/Constraints/InstanceOfConstraint.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DataTables/Filters/Constraints/ChoiceConstraint.php b/src/DataTables/Filters/Constraints/ChoiceConstraint.php index 621edfe9..cce7ce2c 100644 --- a/src/DataTables/Filters/Constraints/ChoiceConstraint.php +++ b/src/DataTables/Filters/Constraints/ChoiceConstraint.php @@ -70,7 +70,7 @@ class ChoiceConstraint extends AbstractConstraint public function isEnabled(): bool { - return $this->operator !== ''; + return $this->operator !== '' && count($this->value) > 0; } public function apply(QueryBuilder $queryBuilder): void diff --git a/src/DataTables/Filters/Constraints/InstanceOfConstraint.php b/src/DataTables/Filters/Constraints/InstanceOfConstraint.php index 410716d4..7fc242d7 100644 --- a/src/DataTables/Filters/Constraints/InstanceOfConstraint.php +++ b/src/DataTables/Filters/Constraints/InstanceOfConstraint.php @@ -77,7 +77,7 @@ class InstanceOfConstraint extends AbstractConstraint public function isEnabled(): bool { - return $this->operator !== ''; + return $this->operator !== '' && count($this->value) > 0; } public function apply(QueryBuilder $queryBuilder): void